Bug 1141446 - Review Request: perl-Pod-Snippets - Extract and reformat snippets of POD
Summary: Review Request: perl-Pod-Snippets - Extract and reformat snippets of POD
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-13 14:21 UTC by Robin Lee
Modified: 2014-10-14 04:40 UTC (History)
2 users (show)

Fixed In Version: perl-Pod-Snippets-0.14-3.fc19
Clone Of:
Environment:
Last Closed: 2014-10-14 04:36:19 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Robin Lee 2014-09-13 14:21:33 UTC
Spec URL: http://cheeselee.fedorapeople.org/perl-Pod-Snippets.spec
SRPM URL: http://cheeselee.fedorapeople.org/perl-Pod-Snippets-0.14-1.fc20.src.rpm
Description:
This class is a very simple extension of Pod::Parser that extracts POD
snippets from Perl code, and pretty-prints it so as to make it usable from
other Perl code. As demonstrated above, Pod::Snippets is immediately useful
to test-driven-development nutcases who want to put every single line of
Perl code under test, including code that is in the POD (typically a
SYNOPSIS section). There are other uses, such as storing a piece of
information that is both human- and machine-readable (e.g. an XML schema)
simultaneously as documentation and code.

Fedora Account System Username: cheeselee

Comment 1 David Dick 2014-09-14 11:27:54 UTC
Fails to build in rawhide.

The SRPM does not build in EPEL5, so you can remove the EPEL5 (and below) specific sections, specifically, the following lines;

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

rm -rf $RPM_BUILD_ROOT

%clean
rm -rf $RPM_BUILD_ROOT

%defattr(-,root,root,-)

Add the following BRs

BuildRequires: perl(base)
BuildRequires: perl(File::Path)
BuildRequires: perl(File::Spec::Functions)
BuildRequires: perl(File::Temp)
BuildRequires: perl(overload)
BuildRequires: perl(Pod::Parser)
BuildRequires: perl(strict)
BuildRequires: perl(Test::More)
BuildRequires: perl(vars)
BuildRequires: perl(warnings)

Comment 2 Robin Lee 2014-09-18 13:25:34 UTC
Changes:
- BR: perl(base) perl(File::Path) perl(File::Spec::Functions)
  perl(File::Temp) perl(overload) perl(strict) perl(Test::More)
  perl(vars) perl(warnings)
- specfile cleanup

Spec URL: http://cheeselee.fedorapeople.org/perl-Pod-Snippets.spec
SRPM URL: http://cheeselee.fedorapeople.org/perl-Pod-Snippets-0.14-2.fc20.src.rpm

Comment 3 David Dick 2014-09-19 10:16:40 UTC
Okay.  Looking good.  

Builds successfully at http://koji.fedoraproject.org/koji/taskinfo?taskID=7628756

Last cleanups.

Remove the "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line.

Add the "eg" directory to %doc

Remove the "Requires: perl(Pod::Parser)" line, rpm auto-detects this requirement.

Comment 4 Robin Lee 2014-09-19 14:01:53 UTC
Changes:
- Additional cleanup
- Remove Requires perl(Pod::Parser)


Spec URL: http://cheeselee.fedorapeople.org/perl-Pod-Snippets.spec
SRPM URL: http://cheeselee.fedorapeople.org/perl-Pod-Snippets-0.14-3.fc20.src.rpm

Comment 5 David Dick 2014-09-19 21:55:49 UTC
Packages builds at http://koji.fedoraproject.org/koji/taskinfo?taskID=7634680

Licensing is correct

rpmlint is clean

Run and Build time requires look good

Package APPROVED!

Comment 6 Robin Lee 2014-09-21 06:19:05 UTC
New Package SCM Request
=======================
Package Name: perl-Pod-Snippets
Short Description: Extract and reformat snippets of POD
Upstream URL: http://search.cpan.org/dist/Pod-Snippets/
Owners: cheeselee
Branches: f19 f20 f21
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2014-09-21 15:34:46 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2014-10-05 17:35:11 UTC
perl-Pod-Snippets-0.14-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Pod-Snippets-0.14-3.fc21

Comment 9 Fedora Update System 2014-10-05 17:36:36 UTC
perl-Pod-Snippets-0.14-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Pod-Snippets-0.14-3.fc20

Comment 10 Fedora Update System 2014-10-05 17:38:14 UTC
perl-Pod-Snippets-0.14-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Pod-Snippets-0.14-3.fc19

Comment 11 Fedora Update System 2014-10-06 05:04:41 UTC
perl-Pod-Snippets-0.14-3.fc19 has been pushed to the Fedora 19 testing repository.

Comment 12 Fedora Update System 2014-10-14 04:32:49 UTC
perl-Pod-Snippets-0.14-3.fc21 has been pushed to the Fedora 21 stable repository.

Comment 13 Fedora Update System 2014-10-14 04:36:19 UTC
perl-Pod-Snippets-0.14-3.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2014-10-14 04:40:08 UTC
perl-Pod-Snippets-0.14-3.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.