Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1141512

Summary: Error message for adding label to the Host NIC is too long
Product: Red Hat Enterprise Virtualization Manager Reporter: GenadiC <gcheresh>
Component: ovirt-engineAssignee: Dan Kenigsberg <danken>
Status: CLOSED CURRENTRELEASE QA Contact: GenadiC <gcheresh>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.5.0CC: bazulay, gcheresh, gklein, lsurette, mburman, nyechiel, rbalakri, Rhev-m-bugs, srevivo, ykaul, ylavi
Target Milestone: ovirt-3.6.0-rc3Flags: ylavi: Triaged+
Target Release: 3.6.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-20 01:26:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screen shot with a problem
none
fix for lable long error message
none
misleading hint case more than one nonvlan
none
fix for label long message case more than one nonvlan none

Description GenadiC 2014-09-14 08:58:38 UTC
Created attachment 937295 [details]
screen shot with a problem

Description of problem:
If you try to add label to the Host NIC when 2 networks that cannot coexist on the same NIC have that label, you get an error message that occupies 2 lines and looks messy.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Create VM and VLAN networks with the same label and long names
2. Add the same label to the Host NIC
3.

Actual results:


Expected results:
Get an error message in the upper field of the setupNetworks window that occupies 2 lines

Additional info:
Error message should be presented in one line only

Comment 1 Barak 2015-05-03 13:32:48 UTC
Yaniv, please provide a text that will fit into a single line ... or change of the UI to contain longer messages.

Comment 2 Yaniv Lavi 2015-05-05 08:16:30 UTC
What is the full text of the message?

Comment 3 GenadiC 2015-05-05 10:41:27 UTC
The full message is in the attachment

Comment 4 Yaniv Lavi 2015-05-05 10:54:30 UTC
(In reply to GenadiC from comment #3)
> The full message is in the attachment

No seeing it can you please paste it here?

Comment 5 GenadiC 2015-05-05 11:49:31 UTC
Cannot have a non-VLAN VM network and VLAN-tagged networks on the interface. This might work without network sw1

Comment 6 Yaniv Lavi 2015-06-21 15:18:04 UTC
Proposed text:
"Can't mix non-VLAN VM network and VLAN-tagged networks on same NIC (hint: remove sw1)"

What do you think?

Comment 7 GenadiC 2015-06-22 06:30:36 UTC
I am ok with the message, but without the hint part
If the users will know that he can't mix such networks it's up to him to decide which network to remove - or VM or VLAN, so hint doesn't help in here

Comment 8 Eliraz Levi 2015-08-10 15:59:08 UTC
Created attachment 1061141 [details]
fix for lable long error message

Comment 9 Eliraz Levi 2015-08-10 15:59:33 UTC
Created attachment 1061142 [details]
misleading hint case more than one nonvlan

Comment 10 Eliraz Levi 2015-08-10 16:00:28 UTC
Created attachment 1061143 [details]
fix for label long message case more than one nonvlan

Comment 11 Eliraz Levi 2015-08-10 16:04:37 UTC
in addition, added fix for more than one non vlan network as the "hint" is misleading as same as described in Comment7.
please approve.

Comment 12 GenadiC 2015-08-12 09:11:37 UTC
Indeed
You just need to check the following cases (as we talked yesterday):
1) VM network with VLAN network
2) VM network with non-VM network
3) 2 non-VM networks

Comment 13 Michael Burman 2015-10-18 08:19:09 UTC
Verified on - 3.6.0.1-0.1.el6