Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1141797

Summary: Dialog screens come up with full set of options and enabled OK button even when no action can be performed (such as with Add Virtual Disk with no active Data Center)
Product: Red Hat Enterprise Virtualization Manager Reporter: Gilad Lazarovich <glazarov>
Component: ovirt-engineAssignee: Daniel Erez <derez>
Status: CLOSED CURRENTRELEASE QA Contact: Kevin Alon Goldblatt <kgoldbla>
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: acanan, amureini, gklein, lsurette, rbalakri, Rhev-m-bugs, yeylon, ykaul
Target Milestone: ovirt-3.6.0-rc   
Target Release: 3.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Add Disk with no active Data Center - nothing to do
none
screen-shot: New VM dialog, no active Data Center
none
Added screen shot of fixed dialog none

Description Gilad Lazarovich 2014-09-15 13:27:38 UTC
Created attachment 937620 [details]
Add Disk with no active Data Center - nothing to do

Description of problem:
Dialog screens come up with full set of options and enabled OK button even when no action can be performed (such as with Add Virtual Disk with no active Data Center)

Version-Release number of selected component (if applicable):
3.5 vt3.1

How reproducible:
100%

Steps to Reproduce:
1. On a system with no active Data Center, navigate to the Disks tab and click on Add
2. Note the dialog that comes up

Actual results:
The OK button is enabled as are the full dialog options though no choices can be made.  When clicking on the OK button, it looks like not all required options are highlighted

Expected results:
Block the Add button for Add Virtual Disk (and the relevant tooltip) or alternatively, bring up a standard dialog should come up with only the info regarding inactive Data Center and an OK or Close button

Additional information:
On the New Pool screen and the New Virtual Machine screen, the OK button is disabled in this scenario where no active Data Center exists

Comment 1 Einav Cohen 2014-09-19 15:56:58 UTC
Created attachment 939390 [details]
screen-shot: New VM dialog, no active Data Center

Comment 2 Einav Cohen 2014-09-19 15:58:27 UTC
need to disable the "OK" button in this case, much like the "New VM" dialog, in which the "OK" button is disabled under similar circumstances (i.e. no active Data Center) - see attachment 939390 [details]

Comment 3 Allon Mureinik 2014-09-22 17:11:47 UTC
Daniel, IIUC, your work on bug 1144848 will solve many of these issues in a cleaner fashion for 3.6.0 - please make sure it covers these issues too.

Comment 4 Kevin Alon Goldblatt 2015-04-29 12:47:08 UTC
Verifieid with version:
-----------------------
v3.6
ovirt-engine-3.6.0-0.0.master.20150412172306.git55ba764.el6.noarch
vdsm-4.17.0-632.git19a83a2.el7.x86_64

Verified with the following scenario:
---------------------------------------
Steps to Reproduce:
1. On a system with no active Data Center, navigate to the Disks tab and click on Add
2. Note the dialog that comes up.

The OK button is no longer Active, it is greyed out and a suitable error is displayed reporting "There are no active data centers in the system."

All other fields in the dialog are also correctly Inactive.


Moving to Verified!

Comment 5 Kevin Alon Goldblatt 2015-04-29 12:53:41 UTC
Created attachment 1020124 [details]
Added screen shot of fixed dialog

Added screenshot displaying the new dialog with the OK button disabled and the error message displayed indicating that no Active Data center is available on the system.

Comment 7 Allon Mureinik 2016-03-10 10:36:57 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 8 Allon Mureinik 2016-03-10 10:37:53 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 9 Allon Mureinik 2016-03-10 10:43:37 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 10 Allon Mureinik 2016-03-10 12:00:23 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE