Spec URL: http://ralph.fedorapeople.org//nodejs-es6-transpiler.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-es6-transpiler-0.7.8-1.fc20.src.rpm Description: es6 -> es5
some comments: - update to latest upstream - Requires can be omitted, they should be generated automatically from package.json - cannot install on f21: Error: nothing provides npm(es5-shim) < 3 needed by nodejs-es6-transpiler-0.7.8-1.fc21.noarch - es6toes5 should be installed with executable bit in %install
Hi Piotr: Here's a new release: - I neglected to package the latest upstream as it has new requirements that would also need to be packaged (es6-shim, for one). - I commented out the Requires. - I got around the es5-shim requirement with a nodejs_fixdep - es6toes5 should have the executable bit set now. Spec URL: http://threebean.org/rpm/SPECS/nodejs-es6-transpiler.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-es6-transpiler-0.7.8-2.fc20.src.rpm
Hi Ralph, When I run the tests they fail, any idea why? All requirements for the tests are satisfied.
No idea off hand.. :/
It seems that there are bundled libraries in the package. See jshint_global and lib dirs. I think you should work with upstream to unbundle them or could they be marked as copylibs? I am not sure how to handle this, will ask my sponsor (Parag) if he is willing to take a look. Besides the bundled libs I found some other issues which are fixable, see: When running the binary I get this error: ~ /usr/bin/es6toes5 /usr/bin/env: node --harmony: No such file or directory I can get around it by changing #!/usr/bin/env node --harmony to #!/usr/bin/node --harmony After that it fails with: Error: Cannot find module './es6-transpiler' You can fix that by installing es6toes5 in the module directory and making a symlink in /usr/bin/ There are two directories not packaged which are needed for functioning: - transpiler - jshint_globals Bundled libraries: jshint_globals is a bundled library, I think this could be fixed by using https://www.npmjs.com/package/jshint-globals or could it be marked as a copylib? lib dir: I have checked two files in lib dir which were both bundled libraries. - esprima_harmony.js - error.js is from lib/esprima_harmony is a bundled library All files have windows line endings, rpmlint warns about: nodejs-es6-transpiler.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodejs-es6-transpiler/README.md nodejs-es6-transpiler.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodejs-es6-transpiler/LICENSE
Without having looked more deeply at it yet, the approach I've used on other packages is to: 1) package the bundled dep 2) symlink the dep into %{nodejs_sitelib}/es6-transpiler/BUNDLED_LIB_NAME Would that be acceptable to you, Piotr, Parag?
The files in lib directory are not full packages but single files from other modules. I think the way they are included from source will have to be modified to make it work. Or could they be treated as copylibs? I think upstream should at least specify from where they are taken and add their license. jshint_globals contains one file from jshint. jshint contains one file with an incompatible license (for good not for evil). Packaging jshint is currently not possible. I see that es6-transpiler is based on nodejs-defs which is approved by Parag in 1122219. Parag, what do you think?
I am sorry but currently I can't have time and full speed internet to look here. Since last 3 days I am in the hospital to take care of my father. I can look here by next week. Thanks.
For nodejs-defs, See $ ls jshint_globals/ LICENSE.jshint README vars.js shows license is same MIT Piotr, Can you provide me which files looks bundled along with their package names? I tried to search esprima_harmony.js in Fedora but could not find which package already installing it.
Haven't checked before if they are already in Fedora lib/ error.js: is in Fedora nodejs-defs, MIT license esprima_harmony.js: is from https://www.npmjs.com/package/esprima and has BSD license. node_inject.js: unknown regjsparser.js: is from https://www.npmjs.com/package/regjsparser, BSD license scope.js: unknown stats.js: nodejs-defs tmpl.js: unknown
Okay then this need to be clarified by upstream if the sources are taken from other modules.
also, lets take advice from more experienced nodejs module maintainers. I have added them in this review. I have started work with nodejs modules since last few months only.
Noting here that Parag filed a bug upstream asking about the bundling: https://github.com/termi/es6-transpiler/issues/71 Thanks for that!
Don't think we need this as the blocking package doesn't need this anymore. Upstream also seems dead. OK if I close/wontfix this one?
Yeah, let's drop it. Thanks Piotr!