Bug 1141981 - Linux HFS+ ESP is an "Unacceptable label format for filesystem"
Summary: Linux HFS+ ESP is an "Unacceptable label format for filesystem"
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Brian Lane
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-15 22:41 UTC by Chris Murphy
Modified: 2015-10-21 16:09 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-10-21 16:09:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
anaconda.log (23.08 KB, text/plain)
2014-09-15 22:42 UTC, Chris Murphy
no flags Details
program.log (26.30 KB, text/plain)
2014-09-15 22:42 UTC, Chris Murphy
no flags Details
storage.log (335.31 KB, text/plain)
2014-09-15 22:42 UTC, Chris Murphy
no flags Details

Description Chris Murphy 2014-09-15 22:41:53 UTC
Description of problem: The installer complains and will not add a /boot/efi mount point with file system Linux HFS+ ESP because it's an "Unacceptable label format for filesystem".


Version-Release number of selected component (if applicable):
Fedora-Live-Workstation-x86_64-21_Alpha-TC7.iso
anaconda-21.48.6-1.fc21
python-blivet-0.61.1-1.fc21


How reproducible:
Always


Steps to Reproduce:
1. Click on an existing, wiped 100MiB partition
2. Check Reformat, and change File System pop-up to Linux HFS+ ESP
3. Click on Mount Point field and set it to /boot/efi
4. Click Update Settings button

Actual results:

Message banner reads Unacceptable label format for filesystem.

Expected results:

Not this, but I'm not familiar with the term "label format" makes me think it has a problem with the encoding for the mkfs.hfsplus -n flag for setting the volume name/label? This was working for a prior TC though, maybe TC5, because prior to this installation attempt this partition was labeled something like "Linux HFS+ ESP" as it appeared in OS X, in contrast to past builds where this has shown up as "Untitled".


Additional info:

Comment 1 Chris Murphy 2014-09-15 22:42:24 UTC
Created attachment 937735 [details]
anaconda.log

Comment 2 Chris Murphy 2014-09-15 22:42:39 UTC
Created attachment 937736 [details]
program.log

Comment 3 Chris Murphy 2014-09-15 22:42:51 UTC
Created attachment 937737 [details]
storage.log

Comment 4 Chris Murphy 2014-09-15 23:42:44 UTC
This doesn't happen when installing to free space, and clicking the blue link option within Manual Partitioning to automatically create partitions.

Comment 5 Brian Lane 2014-12-09 22:10:06 UTC
Is this still happening with the final F21 release?

Comment 6 Chris Murphy 2014-12-09 22:58:08 UTC
Yes.

17:45:44,866 INFO anaconda: /sbin/anaconda 21.48.21-1
[...]
17:46:31,992 DEBUG anaconda: new selector: existing 200 MiB partition sda4 (27)
17:46:32,014 DEBUG anaconda: populate_right_side: existing 200 MiB partition sda4 (27)
17:46:32,033 DEBUG anaconda: updated device_disks to ['sda']
17:46:32,033 DEBUG anaconda: updated device_container_name to None
17:46:32,033 DEBUG anaconda: updated device_container_raid_level to None
17:46:32,033 DEBUG anaconda: updated device_container_encrypted to False
17:46:32,034 DEBUG anaconda: updated device_container_size to 0
17:46:32,041 DEBUG anaconda: fs type changed: Unknown
17:46:32,043 DEBUG anaconda: populate_raid: 2, None
17:46:35,878 DEBUG anaconda: fs type changed: Linux HFS+ ESP
17:46:43,780 INFO anaconda: ui: saving changes to device sda4
17:46:43,781 DEBUG anaconda: reformat: True
17:46:43,788 DEBUG anaconda: populate_right_side: existing 200 MiB partition sda4 (27)
17:46:43,809 DEBUG anaconda: updated device_disks to ['sda']
17:46:43,809 DEBUG anaconda: updated device_container_name to None
17:46:43,809 DEBUG anaconda: updated device_container_raid_level to None
17:46:43,810 DEBUG anaconda: updated device_container_encrypted to False
17:46:43,810 DEBUG anaconda: updated device_container_size to 0
17:46:43,820 DEBUG anaconda: fs type changed: Unknown


That last line is bogus, I didn't change it back to Unknown. I changed it from Unknown to Linux hFS+ ESP, then clicked Update Settings. It's like it's snapping back to Unknown and the error message is that fs type Unknown isn't acceptable. So strictly speaking the error message is correct, the problem is the UI is somehow now changing the fs type from Unknown to Linux hFS+ ESP and leaving it there (it reverts to Unknown upon clicking Update Settings).

Also, if the fs type is HFS+ to start with, the bug doesn't happen. Only if the selected partition's fs type is Unknown (i.e. use wipefs -a on the partition in advance) does this bug get triggered.

Comment 7 Chris Murphy 2014-12-09 22:59:24 UTC
"is somehow now changing"
should be
"is somehow not changing"

Comment 8 Brian Lane 2015-03-10 22:05:10 UTC
https://github.com/rhinstaller/anaconda/pull/33


Note You need to log in before you can comment on or make changes to this bug.