Bug 1142050 - Review Request: nodejs-seq - An asynchronous flow control library
Summary: Review Request: nodejs-seq - An asynchronous flow control library
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Tomas Hrcka
QA Contact: Fedora Extras Quality Assurance
Depends On: 1142049
Blocks: nodejs-reviews
TreeView+ depends on / blocked
Reported: 2014-09-16 05:24 UTC by Parag Nemade
Modified: 2014-11-18 08:10 UTC (History)
2 users (show)

Fixed In Version: nodejs-seq-0.3.5-3.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-11-10 06:40:04 UTC
Type: ---
thrcka: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Parag Nemade 2014-09-16 05:24:13 UTC
Spec URL: https://paragn.fedorapeople.org/fedora-work/SPECS/nodejs-seq.spec
SRPM URL: https://paragn.fedorapeople.org/fedora-work/SRPMS/nodejs-seq-0.3.5-1.fc21.src.rpm
Description: Chainable asynchronous flow control with sequential and parallel primitives and pipeline-style error handling.

Fedora Account System Username: pnemade

Comment 2 Parag Nemade 2014-10-24 08:55:30 UTC
Hi Tomas,
   Can you please review this package?

Comment 3 Tomas Hrcka 2014-10-24 12:56:27 UTC
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.sRYMWj
+ umask 022
+ cd /home/thrcka/rpmbuild/BUILD
+ cd /home/thrcka/rpmbuild/BUILD
+ rm -rf package
+ /usr/bin/gzip -dc /home/thrcka/rpmbuild/SOURCES/seq-0.3.5.tgz
+ /usr/bin/tar -xf -
+ '[' 0 -ne 0 ']'
+ cd package
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ rm -rf node_modules
+ chmod 644 index.js
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.3Vb541
+ umask 022
+ cd /home/thrcka/rpmbuild/BUILD
+ cd package
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.F0wYdK
+ umask 022
+ cd /home/thrcka/rpmbuild/BUILD
+ '[' /home/thrcka/rpmbuild/BUILDROOT/nodejs-seq-0.3.5-1.fc21.x86_64 '!=' / ']'
+ rm -rf /home/thrcka/rpmbuild/BUILDROOT/nodejs-seq-0.3.5-1.fc21.x86_64
++ dirname /home/thrcka/rpmbuild/BUILDROOT/nodejs-seq-0.3.5-1.fc21.x86_64
+ mkdir -p /home/thrcka/rpmbuild/BUILDROOT
+ mkdir /home/thrcka/rpmbuild/BUILDROOT/nodejs-seq-0.3.5-1.fc21.x86_64
+ cd package
+ mkdir -p /home/thrcka/rpmbuild/BUILDROOT/nodejs-seq-0.3.5-1.fc21.x86_64/usr/lib/node_modules/seq
+ cp -pr package.json index.js /home/thrcka/rpmbuild/BUILDROOT/nodejs-seq-0.3.5-1.fc21.x86_64/usr/lib/node_modules/seq
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules
+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id -m --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 110000000 /home/thrcka/rpmbuild/BUILD/package
/usr/lib/rpm/sepdebugcrcfix: Updated 0 CRC32s, 0 CRC32s did match.
find: 'debug': No such file or directory
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/brp-compress
+ /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
+ /usr/lib/rpm/brp-python-hardlink
+ /usr/lib/rpm/redhat/brp-java-repack-jars
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.jMF2Os
+ umask 022
+ cd /home/thrcka/rpmbuild/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ node test/readdir.js test/seq.js test/seq_.js

    throw err;
Error: Cannot find module 'seq'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/thrcka/rpmbuild/BUILD/package/test/readdir.js:2:11)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
error: Bad exit status from /var/tmp/rpm-tmp.jMF2Os (%check)

Comment 4 Parag Nemade 2014-10-25 04:12:38 UTC
Looks like some issues with the test files. Lets remove %check

Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-seq.spec
SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-seq-0.3.5-2.fc21.src.rpm

Comment 5 Parag Nemade 2014-10-29 11:27:18 UTC
Hi Tomas,
   Can you review this please?

Comment 6 Tomas Hrcka 2014-10-29 12:16:45 UTC
Sorry Parag I was occupied for last few days, I am running fedora-review tool right now.

Comment 7 Tomas Hrcka 2014-10-29 13:17:22 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 7 files have unknown license. Detailed output of
     licensecheck in /home/thrcka/1142050-nodejs-seq/licensecheck.txt
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.

Checking: nodejs-seq-0.3.5-2.fc21.noarch.rpm
nodejs-seq.noarch: W: spelling-error %description -l en_US Chainable -> Chain able, Chain-able, Changeable
nodejs-seq.noarch: W: only-non-binary-in-usr-lib
nodejs-seq.noarch: W: dangling-symlink /usr/lib/node_modules/seq/node_modules/chainsaw /usr/lib/node_modules/chainsaw
nodejs-seq.noarch: W: dangling-symlink /usr/lib/node_modules/seq/node_modules/hashish /usr/lib/node_modules/hashish
nodejs-seq.src: W: spelling-error %description -l en_US Chainable -> Chain able, Chain-able, Changeable
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

nodejs-seq (rpmlib, GLIBC filtered):


Source checksums
http://registry.npmjs.org/seq/-/seq-0.3.5.tgz :
  CHECKSUM(SHA256) this package     : 1dbf5efde64789117ed34a5547c1a4d8839644eb40765a2b3a9a6d48bdf4eda0
  CHECKSUM(SHA256) upstream package : 1dbf5efde64789117ed34a5547c1a4d8839644eb40765a2b3a9a6d48bdf4eda0

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1142050 --mock-config fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Comment 8 Parag Nemade 2014-10-29 13:27:09 UTC
Thank you Tomas for finding time to review this package.

New Package SCM Request
Package Name: nodejs-seq
Short Description: An asynchronous flow control library
Upstream URL:  https://github.com/substack/node-seq
Owners: pnemade
Branches: f19 f20 f21 el6 epel7

Comment 9 Gwyn Ciesla 2014-10-29 14:11:23 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2014-10-30 13:26:54 UTC
nodejs-seq-0.3.5-2.fc19 has been submitted as an update for Fedora 19.

Comment 11 Fedora Update System 2014-10-30 13:28:19 UTC
nodejs-seq-0.3.5-2.fc21 has been submitted as an update for Fedora 21.

Comment 12 Fedora Update System 2014-10-30 13:34:11 UTC
nodejs-seq-0.3.5-2.el7 has been submitted as an update for Fedora EPEL 7.

Comment 13 Fedora Update System 2014-10-30 13:35:39 UTC
nodejs-seq-0.3.5-2.fc20 has been submitted as an update for Fedora 20.

Comment 14 Fedora Update System 2014-10-30 16:00:16 UTC
nodejs-seq-0.3.5-2.el6 has been submitted as an update for Fedora EPEL 6.

Comment 15 Fedora Update System 2014-10-31 01:23:02 UTC
nodejs-seq-0.3.5-2.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 16 Fedora Update System 2014-11-01 01:53:51 UTC
nodejs-seq-0.3.5-3.fc21 has been submitted as an update for Fedora 21.

Comment 17 Fedora Update System 2014-11-01 02:05:59 UTC
nodejs-seq-0.3.5-3.el7 has been submitted as an update for Fedora EPEL 7.

Comment 18 Fedora Update System 2014-11-01 02:06:49 UTC
nodejs-seq-0.3.5-3.fc20 has been submitted as an update for Fedora 20.

Comment 19 Fedora Update System 2014-11-01 02:07:09 UTC
nodejs-seq-0.3.5-3.el6 has been submitted as an update for Fedora EPEL 6.

Comment 20 Fedora Update System 2014-11-01 02:52:28 UTC
nodejs-seq-0.3.5-3.fc19 has been submitted as an update for Fedora 19.

Comment 21 Fedora Update System 2014-11-10 06:40:04 UTC
nodejs-seq-0.3.5-3.fc20 has been pushed to the Fedora 20 stable repository.

Comment 22 Fedora Update System 2014-11-10 06:41:14 UTC
nodejs-seq-0.3.5-3.fc21 has been pushed to the Fedora 21 stable repository.

Comment 23 Fedora Update System 2014-11-10 06:49:30 UTC
nodejs-seq-0.3.5-3.fc19 has been pushed to the Fedora 19 stable repository.

Comment 24 Fedora Update System 2014-11-18 08:09:13 UTC
nodejs-seq-0.3.5-3.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 25 Fedora Update System 2014-11-18 08:10:02 UTC
nodejs-seq-0.3.5-3.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.