Spec URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.3-1/rubygem-ox.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.3-1/rubygem-ox-2.1.3-1.fc22.src.rpm Description: A fast XML parser and object serializer that uses only standard C lib. Optimized XML (Ox), as the name implies was written to provide speed optimized XML handling. It was designed to be an alternative to Nokogiri and other Ruby XML parsers for generic XML parsing and as an alternative to Marshal for Object serialization. Fedora Account System Username: valtri koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7596555
Spec URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.6-1/rubygem-ox.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.6-1/rubygem-ox-2.1.6-1.fc22.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8508423 %changelog * Wed Dec 31 2014 František Dvořák <valtri.cz> - 2.1.6-1 - Update to 2.1.6 - Changed license from BSD to MIT (https://github.com/ohler55/ox/issues/104) - Tests added
Spec URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.7-1/rubygem-ox.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.7-1/rubygem-ox-2.1.7-1.fc22.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8884773 %changelog * Tue Feb 10 2015 František Dvořák <valtri.cz> - 2.1.7-1 - Update to 2.1.7
Spec URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.8-1/rubygem-ox.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.8-1/rubygem-ox-2.1.8-1.fc23.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8966608 %changelog * Tue Feb 17 2015 František Dvořák <valtri.cz> - 2.1.8-1 - Update to 2.1.8
Taking. I would appreciate it if you would review my review request (bug 1204009)
Some remarks: * %license - Use %license for LICENSE file * Document files placement - I would recommend to move README.md to main package because it says "README" (not a blocker) * License - And while LICENSE file is MIT, actually lib/ox.rb seems under BSD. Would you check this?
(In reply to Mamoru TASAKA from comment #5) > Some remarks: > > * %license > - Use %license for LICENSE file > Fixed. > * Document files placement > - I would recommend to move README.md to main package > because it says "README" (not a blocker) > OK. Some packagers place the README in the doc subpackage, but the main package may be slightly better. :-) > * License > - And while LICENSE file is MIT, actually lib/ox.rb seems > under BSD. Would you check this? Fixed upstream (there were change of the license to MIT recently): https://github.com/ohler55/ox/pull/108 New version: Spec URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.8-2/rubygem-ox.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ox-2.1.8-2/rubygem-ox-2.1.8-2.fc23.src.rpm %changelog * Mon Mar 23 2015 František Dvořák <valtri.cz> - 2.1.8-2 - Use the %%license tag - Move README.md to main package Thanks for the review!
Okay, I would recommend to add some comments on the spec file for license clarification until the next version. * spec file clean * source contents no problem * builds on F-23/22/21 * can be installed * at least the following works $ ruby -e "require 'ox' ; p Ox::VERSION" "2.1.8" --------------------------------------------------- This package (rubygem-ox) is APPROVED by mtasaka ----------------------------------------------------
New Package SCM Request ======================= Package Name: rubygem-ox Short Description: Fast XML parser and object serializer Upstream URL: http://www.ohler.com/ox Owners: valtri Branches: f20 f21 f22 epel7 InitialCC:
Git done (by process-git-requests).
rubygem-ox-2.1.8-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/rubygem-ox-2.1.8-2.fc22
rubygem-ox-2.1.8-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rubygem-ox-2.1.8-2.fc21
rubygem-ox-2.1.8-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-ox-2.1.8-2.fc20
rubygem-ox-2.1.8-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/rubygem-ox-2.1.8-2.el7
rubygem-ox-2.1.8-2.fc22 has been pushed to the Fedora 22 testing repository.
rubygem-ox-2.1.8-2.fc21 has been pushed to the Fedora 21 stable repository.
rubygem-ox-2.1.8-2.fc20 has been pushed to the Fedora 20 stable repository.
rubygem-ox-2.1.8-2.fc22 has been pushed to the Fedora 22 stable repository.
rubygem-ox-2.1.8-2.el7 has been pushed to the Fedora EPEL 7 stable repository.