Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1142617

Summary: [Edit VM] > Sub tab [host] > missing specific host highlight with red color but sub tab Host doesn't
Product: Red Hat Enterprise Virtualization Manager Reporter: Michael Burman <mburman>
Component: ovirt-engineAssignee: Tomas Jelinek <tjelinek>
Status: CLOSED CURRENTRELEASE QA Contact: Israel Pinto <ipinto>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.5.0CC: bazulay, gklein, lsurette, mavital, mgoldboi, michal.skrivanek, rbalakri, rgolan, Rhev-m-bugs, srevivo, tjelinek, ykaul
Target Milestone: ovirt-3.6.0-rcKeywords: Reopened
Target Release: 3.6.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-20 01:25:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshoot
none
Screenshoot
none
Screenshoot3 none

Description Michael Burman 2014-09-17 06:33:34 UTC
Created attachment 938349 [details]
Screenshoot

Description of problem:
[Edit VM] > Sub tab [host] > missing specific host highlight with red color but sub tab Host doesn't.
If you try to edit VM and move it to another cluster and specific host is required(but missing), you can't press the ok button because host is missing but you have no idea about it when standing in General sub tab. The Host sub tab doesn't highlighted with red color as it should, only when you go the Host sub tab it self you see that the layout of the host is highlighted with red color.

Version-Release number of selected component (if applicable):
3.5.0-0.12.beta.el6ev

How reproducible:
always

Steps to Reproduce:
1. Edit VM and move it to cluster with no host (specific host) 
2. Try to press ok and save the change
3.

Actual results:
Can't press ok button, no error or warning appears, no highlight with red color on the sub tabs of the window. Only after move from sub to sub you find that specific host in sub tab Host is highlighted with red color.

Expected results:
Sab tub Host should be colored with red, so if you are in general sub tab, you can know where something is missing, in this case, in the sub tab Host.

Additional info:

Comment 1 Michael Burman 2014-09-17 07:07:15 UTC
Created attachment 938362 [details]
Screenshoot

Comment 2 Michael Burman 2014-09-17 07:10:16 UTC
The behavior of the [Host] sub tab in the Edit VM window should be like in attachment from Comment 1 above. General and System sub tabs highlighted with red color when something was missing there. The Host sub tab doesn't behave this way and it should.

Comment 3 Michael Burman 2014-09-17 08:15:01 UTC
Created attachment 938383 [details]
Screenshoot3

Comment 4 Michael Burman 2014-09-17 08:16:15 UTC
This bug also happening in [New Network] window > Subnet sub tab.
The CIDR layout highlighted with red color(if enter wrong value), but the Subnet sub tab doesn't, and it should be highlighted with red color as well.

See screenshoot from Comment 3 above

Comment 5 Omer Frenkel 2014-09-21 12:46:27 UTC
i think this is common in many other places that use tabs in dialogs

Comment 6 Michal Skrivanek 2015-06-02 09:36:21 UTC
we believe it works now, fixed by ux changes

Comment 7 Michael Burman 2015-06-02 14:14:42 UTC
Michal, bug is not fixed, same issue.
3.6.0-0.0.master.20150519172219.git9a2e2b3.el6

Comment 10 Michael Burman 2015-11-03 06:42:30 UTC
Hi

This bug is ON_QA for some time now and i decided to test it, but it seems that engine is not blocking such operations any more.

If moving VM to a cluster that has no host and the 'Specific' button is checked under 'Edit VM' dialog  > [Host] sub tab > Start Running On: 
Engine is not blocking from approving operation and the VM configuration updated.

Comment 11 Israel Pinto 2015-11-16 12:52:20 UTC
Verify with:
RHEVM: 3.6.0.3-0.1.el6
VDSM:vdsm-4.17.10.1-0.el7ev
libvirt: libvirt-1.2.17-13.el7

Scenario:
1. Edit VM and move it to cluster with no host (specific host) 
2. Try to press ok and save the change

Results:
PASS

Note: I think we should show WARN to the user if the VM was pinned to
host and we update cluster to different cluster.

Comment 12 Roy Golan 2015-12-10 17:58:29 UTC
WARN as in a dialog warning or just an audit log? I'm not sure either because moving to a new cluster is for sure an action that change the host setup and I believe its trivial to the admin. Moran?

Comment 13 Moran Goldboim 2015-12-29 10:30:33 UTC
(In reply to Roy Golan from comment #12)
> WARN as in a dialog warning or just an audit log? I'm not sure either
> because moving to a new cluster is for sure an action that change the host
> setup and I believe its trivial to the admin. Moran?

as far as i see it, we should warn the user that moving the vm to a cluster that doesn't have the specific host on the time of the move, that this vm property will be removed if he decides to do so.