Description of problem: I just tried to compile package gnome-pilot-2.0.10-4, from Redhat Fedora Core 1. The compiler said 1. pilot.c(401): warning #1011: missing return statement at end of non-void function "free_conduit_list" The source code is void * free_conduit_list (GList *conduits) { /* FIXME Properly free each state */ g_list_free (conduits); } Looks like a missing return statement to me. 2. gpilotd-client.c(420): warning #140: too many arguments in function call The source code is get_system_info (gpc); but, earlier in the file static void get_system_info () { Suggest remove gpc from call to get_system_info. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
re (1): This is still present in gnome-pilot-2.0.12; capplet/pilot.[ch]: free_conduit_list: looks like a bad argument; should return void rather than void* It appears that it never gets called, so it looks like a memory leak, rather than a crash. re (2): This is also still present in gnome-pilot-2.0.12; utils/gpilotd-client.c: your suggestion of removing the gpc from the call appears to be the correct fix (should also have an explicit void in the declaration of the function) I've fixed these and rebuilt into rawhide as gnome-pilot-2.0.12-3 I've reported the patch upstream here: http://bugzilla.gnome.org/show_bug.cgi?id=153317