Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
libvirt should check right inbound and outbound range of domiftune or improve error message
Version-Release number of selected component (if applicable):
libvirt-1.2.8-2.el7.x86_64
How reproducible:
100%
Steps to Reproduce:
1.prepare a running guest have virtual NIC
# virsh domiflist r7
Interface Type Source Model MAC
-------------------------------------------------------
vnet0 network default rtl8139 52:54:00:D0:D6:3e
2.# virsh domiftune r7 vnet0 -1
error: inbound rate larger than maximum 4294967295
3.# virsh domiftune r7 vnet0 42949672
error: Unable to set interface parameters
error: internal error: Child process (/sbin/tc class add dev vnet0 parent 1: classid 1:1 htb rate 42949672kbps) unexpected exit status 1: Illegal "rate"
Usage: ... qdisc add ... htb [default N] [r2q N]
default minor id of class to which unclassified packets are sent {0}
r2q DRR quantums are computed as rate in Bps/r2q {10}
debug string of 16 numbers each 0-3 {0}
... class add ... htb rate R1 [burst B1] [mpu B] [overhead O]
[prio P] [slot S] [pslot PS]
[ceil R2] [cburst B2] [mtu MTU] [quantum Q]
rate rate allocated to this class (class can still borrow)
burst max bytes burst which can be accumulated during idle period {computed}
mpu minimum packet size used in rate computations
overhead per-packet size overhead used in rate computations
linklay adapting to a linklayer e.g. atm
ceil definite upper class rate (no borrows) {rate}
cburst burst but for ceil {computed}
mtu max packet size we create rate map for {1600}
prio priority of leaf; low
4.# virsh domiftune r6 vnet1 4294967
5.# virsh domiftune r6 vnet1
inbound.average: 4294967
inbound.peak : 0
inbound.burst : 0
outbound.average: 0
outbound.peak : 0
outbound.burst : 0
Actual results:
TC store rates as a 32-bit unsigned integer in bps internally, so we can specify a max rate of 4294967295 bps.And libvirt range check maxmum is 4294967295 kbps now. So we cannot set a number which lower than 4294967295 and biger than 4294967.
Expected results:
change maxmum to 4294967 or change the kbps to bps or just improve error massage
Additional info:
Description of problem: libvirt should check right inbound and outbound range of domiftune or improve error message Version-Release number of selected component (if applicable): libvirt-1.2.8-2.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1.prepare a running guest have virtual NIC # virsh domiflist r7 Interface Type Source Model MAC ------------------------------------------------------- vnet0 network default rtl8139 52:54:00:D0:D6:3e 2.# virsh domiftune r7 vnet0 -1 error: inbound rate larger than maximum 4294967295 3.# virsh domiftune r7 vnet0 42949672 error: Unable to set interface parameters error: internal error: Child process (/sbin/tc class add dev vnet0 parent 1: classid 1:1 htb rate 42949672kbps) unexpected exit status 1: Illegal "rate" Usage: ... qdisc add ... htb [default N] [r2q N] default minor id of class to which unclassified packets are sent {0} r2q DRR quantums are computed as rate in Bps/r2q {10} debug string of 16 numbers each 0-3 {0} ... class add ... htb rate R1 [burst B1] [mpu B] [overhead O] [prio P] [slot S] [pslot PS] [ceil R2] [cburst B2] [mtu MTU] [quantum Q] rate rate allocated to this class (class can still borrow) burst max bytes burst which can be accumulated during idle period {computed} mpu minimum packet size used in rate computations overhead per-packet size overhead used in rate computations linklay adapting to a linklayer e.g. atm ceil definite upper class rate (no borrows) {rate} cburst burst but for ceil {computed} mtu max packet size we create rate map for {1600} prio priority of leaf; low 4.# virsh domiftune r6 vnet1 4294967 5.# virsh domiftune r6 vnet1 inbound.average: 4294967 inbound.peak : 0 inbound.burst : 0 outbound.average: 0 outbound.peak : 0 outbound.burst : 0 Actual results: TC store rates as a 32-bit unsigned integer in bps internally, so we can specify a max rate of 4294967295 bps.And libvirt range check maxmum is 4294967295 kbps now. So we cannot set a number which lower than 4294967295 and biger than 4294967. Expected results: change maxmum to 4294967 or change the kbps to bps or just improve error massage Additional info: