Bug 114286 - used before set && missing return statement
used before set && missing return statement
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: gnome-vfs-extras (Show other bugs)
1
All Linux
medium Severity medium
: ---
: ---
Assigned To: Alexander Larsson
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2004-01-26 05:38 EST by d.binderman
Modified: 2007-11-30 17:10 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-04-22 01:01:37 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description d.binderman 2004-01-26 05:38:32 EST
Description of problem:

I just tried to compile package gnome-vfs-extras-0.2.0-7, from Redhat
Fedora Core 1.

The compiler said

1.

smb-method.c(196): warning #1011: missing return statement at end of
non-void function "smb_virtual_file_new"
set

The source code is

static SmbVirtualFile *
smb_virtual_file_new (SmbVirtualFileType type)
{
        SmbVirtualFile *file;

        file = g_new0 (SmbVirtualFile, 1);
        file->virtual_type = type;
}

Seems to be missing a return statment.

2.

smb-method.c(1674): remark #592: variable "content" is used before its
value is

Source code is

	SmbDirContent *content;

	/* more code */

    if (content->mode & aDIR)

Clearly broken code. I'm not sure what the fix is for this.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 David Binderman 2004-11-18 04:50:59 EST
I can confirm that these bugs still exist in Fedora Core 3.

Nothing seems to have happened in the last ten months.
Comment 2 John Thacker 2006-04-22 01:01:37 EDT
Not going to patch upstream code to quiet a compiler warning rather 
than fix a bug or error.

Note You need to log in before you can comment on or make changes to this bug.