Bug 1143888 - Faulty storage allocation checks when adding a VM Pool with VMs.
Summary: Faulty storage allocation checks when adding a VM Pool with VMs.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.5.1
Assignee: Vered Volansky
QA Contact: Aharon Canan
URL:
Whiteboard: storage
Depends On:
Blocks: 1178021 1193195
TreeView+ depends on / blocked
 
Reported: 2014-09-18 08:16 UTC by Vered Volansky
Modified: 2016-02-10 16:56 UTC (History)
8 users (show)

Fixed In Version: ovirt-3.5.1_rc1
Clone Of:
: 1178021 (view as bug list)
Environment:
Last Closed: 2015-01-21 16:02:55 UTC
oVirt Team: Storage
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 33525 0 master MERGED core: AddVmPoolWithVmsCommand storage allocation Never
oVirt gerrit 33694 0 ovirt-engine-3.5 MERGED core: AddVmPoolWithVmsCommand storage allocation Never

Description Vered Volansky 2014-09-18 08:16:52 UTC
AddVmPoolWithVmsCommand - VMs in the pool are added with empty disks (Thinly provisioned from the template). There are no memory volumes not snapshots.
Storage allocation validation should be applied - StorageDomainValidator.HadSpaceForNewDisks(). Current validation is using old deprecated code.

Verification of this bug should follow the following table:

      | File Domain                             | Block Domain
 -----|-----------------------------------------|-------------
 qcow | 1M (header size)                        | 1G
 -----|-----------------------------------------|-------------
 raw  | preallocated: disk capacity (getSize()) | disk capacity
      | thin (sparse): 1M                       | (there is no raw sparse on 
                                                   block domains)


Verification should include a storage domain with and without enough space for all the vm (with disks) in the pool .
In case of insufficient space a relevant CDA message should pop.

Comment 1 Vered Volansky 2014-09-29 08:33:19 UTC
Since this is thinly provisioned, only sparse-qcow is in use here (from above table). Note in this flow the template already exist, so no allocation checks for it, and the allocation checks taken from the table above should be applied to all VMs (empty volume space* numOfVms).

Comment 2 Sandro Bonazzola 2015-01-15 14:15:00 UTC
This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA

Comment 3 Aharon Canan 2015-01-21 11:19:27 UTC
Verified downstream 
https://bugzilla.redhat.com/show_bug.cgi?id=1178021

Comment 4 Sandro Bonazzola 2015-01-21 16:02:55 UTC
oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.