Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1143888

Summary: Faulty storage allocation checks when adding a VM Pool with VMs.
Product: [Retired] oVirt Reporter: Vered Volansky <vered>
Component: ovirt-engine-coreAssignee: Vered Volansky <vered>
Status: CLOSED CURRENTRELEASE QA Contact: Aharon Canan <acanan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.5CC: amureini, bugs, ecohen, gklein, iheim, lsurette, rbalakri, yeylon
Target Milestone: ---   
Target Release: 3.5.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: ovirt-3.5.1_rc1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1178021 (view as bug list) Environment:
Last Closed: 2015-01-21 16:02:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1178021, 1193195    

Description Vered Volansky 2014-09-18 08:16:52 UTC
AddVmPoolWithVmsCommand - VMs in the pool are added with empty disks (Thinly provisioned from the template). There are no memory volumes not snapshots.
Storage allocation validation should be applied - StorageDomainValidator.HadSpaceForNewDisks(). Current validation is using old deprecated code.

Verification of this bug should follow the following table:

      | File Domain                             | Block Domain
 -----|-----------------------------------------|-------------
 qcow | 1M (header size)                        | 1G
 -----|-----------------------------------------|-------------
 raw  | preallocated: disk capacity (getSize()) | disk capacity
      | thin (sparse): 1M                       | (there is no raw sparse on 
                                                   block domains)


Verification should include a storage domain with and without enough space for all the vm (with disks) in the pool .
In case of insufficient space a relevant CDA message should pop.

Comment 1 Vered Volansky 2014-09-29 08:33:19 UTC
Since this is thinly provisioned, only sparse-qcow is in use here (from above table). Note in this flow the template already exist, so no allocation checks for it, and the allocation checks taken from the table above should be applied to all VMs (empty volume space* numOfVms).

Comment 2 Sandro Bonazzola 2015-01-15 14:15:00 UTC
This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA

Comment 3 Aharon Canan 2015-01-21 11:19:27 UTC
Verified downstream 
https://bugzilla.redhat.com/show_bug.cgi?id=1178021

Comment 4 Sandro Bonazzola 2015-01-21 16:02:55 UTC
oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.