Bug 1144111 - Review Request: copr-keygen - Copr aux service that generate keys for sign.
Summary: Review Request: copr-keygen - Copr aux service that generate keys for sign.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-18 16:55 UTC by Valentin Gologuzov
Modified: 2016-02-08 23:46 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-02-08 23:46:30 UTC
Type: ---
Embargoed:
msuchy: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Valentin Gologuzov 2014-09-18 16:55:25 UTC
Spec URL: http://people.redhat.com/~vgologuz/copr-keygen-1.55/copr-keygen.spec
SRPM URL: http://people.redhat.com/~vgologuz/copr-keygen-1.55/copr-keygen-1.55-1.fc20.src.rpm
Description: 

COPR is lightweight build system. It allows you to create new project in WebUI,
and submit new builds and COPR will create yum repository from latest builds.
This package contains aux service that generate keys for package signing.
Scratch build in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7618736

Fedora Account System Username: vgologuz

Comment 1 Miroslav Suchý 2014-09-18 16:58:24 UTC
taking

Comment 2 Valentin Gologuzov 2014-09-22 17:11:50 UTC
Covered with basic unittests, added support for python3. Not sure about python3 version naming: python3-copr-keygen

SRPM: http://people.redhat.com/~vgologuz/copr-keygen-1.56/copr-keygen-1.56-1.fc20.src.rpm
SPEC: http://people.redhat.com/~vgologuz/copr-keygen-1.56/copr-keygen.spec

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7650544

Comment 4 Miroslav Suchý 2014-10-09 10:29:42 UTC
copr-keygen.noarch: W: summary-ended-with-dot C Part of Copr build system. Aux service that generate keys for sign.

copr-keygen.noarch: E: non-executable-script /usr/share/copr-keygen/application.py 0644L /usr/bin/python3

copr-keygen.noarch: W: file-not-utf8 /usr/share/doc/copr-keygen/html/objects.inv

copr-keygen.noarch: W: non-executable-in-bin /usr/bin/gpg_copr.sh 0644L
copr-keygen.noarch: E: non-executable-script /usr/bin/gpg_copr.sh 0644L /bin/bash

copr-keygen.noarch: W: hidden-file-or-dir /usr/share/doc/copr-keygen/html/.buildinfo

copr-keygen.noarch: W: log-files-without-logrotate /var/log/copr-keygen

wrong-file-end-of-line-encoding /usr/share/doc/copr-keygen/html/_static/jquery.js
and bundled jquery.

Comment 5 Valentin Gologuzov 2014-10-09 11:59:20 UTC
SRPM: http://people.redhat.com/~vgologuz/keygen-1.58_WIP/copr-keygen-1.58-1.git.47.af3ad7e.fc20.src.rpm
SPEC: http://people.redhat.com/~vgologuz/keygen-1.58_WIP/copr-keygen.spec

>>> copr-keygen.noarch: W: summary-ended-with-dot C Part of Copr build system. 

Fixed 

>>> copr-keygen.noarch: E: non-executable-script ...

Fixed 

>>> copr-keygen.noarch: W: hidden-file-or-dir /usr/share/doc/copr-keygen/html/.buildinfo

Fixed by cleanup of .buildinfo

>>> copr-keygen.noarch: W: log-files-without-logrotate /var/log/copr-keygen

Logs are rotated by python log handler

>>> copr-keygen.noarch: W: file-not-utf8 /usr/share/doc/copr-keygen/html/objects.inv

This file is binary in fact ( mix of text header and zlib compressed data)

>>> wrong-file-end-of-line-encoding /usr/share/doc/copr-keygen/html/_static/jquery.js

This file produced by python-sphinx, so accept that or remove all sphinx generated documentation and only publish docs to readthedocs.org .
About end-of-line is jquery.js: https://bugzilla.redhat.com/show_bug.cgi?id=1107813

Comment 6 Miroslav Suchý 2014-10-20 11:48:33 UTC
APPROVED

Comment 7 Valentin Gologuzov 2014-10-21 11:22:56 UTC
New Package SCM Request
=======================
Package Name: copr-keygen
Short Description: Part of Copr build system. Aux service that generate keys for signd
Upstream URL: https://git.fedorahosted.org/cgit/copr.git/ 
Owners: msuchy vgologuz
Branches: f19 f20
InitialCC:

Comment 8 Gwyn Ciesla 2014-10-21 11:50:38 UTC
Git done (by process-git-requests).

Added f21.

Comment 9 Fedora Update System 2014-10-30 12:06:28 UTC
copr-keygen-1.60-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/copr-keygen-1.60-1.fc20

Comment 10 Fedora Update System 2014-10-30 12:45:00 UTC
copr-keygen-1.60-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/copr-keygen-1.60-1.fc21

Comment 11 Fedora Update System 2014-11-01 01:46:20 UTC
copr-keygen-1.60-1.fc20 has been pushed to the Fedora 20 testing repository.


Note You need to log in before you can comment on or make changes to this bug.