Bug 1144895 - RFE: Track OS name in the guest XML
Summary: RFE: Track OS name in the guest XML
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-21 22:09 UTC by Cole Robinson
Modified: 2018-10-03 23:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-03 23:21:11 UTC
Embargoed:


Attachments (Terms of Use)

Description Cole Robinson 2014-09-21 22:09:06 UTC
virt-manager needs to track the VMs OS name in the libvirt XML so we can make post-install decisions about what defaults to suggest when adding hardware, etc.

There's various bits to consider here:

- Do we use the arbitrary metadata XML approach that boxes uses?
- Do we consume boxes XML format?
- Do we push for libvirt to track this natively, like https://bugzilla.redhat.com/show_bug.cgi?id=509164 ?

- Need to add UI for users to manually set it for pre-existing VMs
- Need to consider how to store what libguestfs detects in the XML without user intervention

Comment 1 Daniel Berrangé 2014-09-22 08:34:28 UTC
I think we need the libosinfo project to define a standard schema for recording information related to libosinfo in the libvirt domain <metadata> block. That way all apps using libosinfo wil be able to interoperate nicely.

Comment 2 Cole Robinson 2018-10-03 23:21:11 UTC
This is upstream now, starting with:

commit bad5eabd93118e23e7ea0a27ffe3d93f4db9960f
Author: Cole Robinson <crobinso>
Date:   Wed Sep 12 17:10:54 2018 -0400

    domain: Add metadata.libosinfo
    
    From the libosinfo discussion here:
    https://www.redhat.com/archives/libosinfo/2018-September/msg00003.html
    
    This is a cross-app schema for tracking libosinfo OS ID in the
    domain <metadata> XML. Example:
    
       <metadata>
         <libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0">
           <libosinfo:os id="http://fedoraproject.org/fedora/17"/>
         </libosinfo:libosinfo>
       </metadata>


Note You need to log in before you can comment on or make changes to this bug.