+++ This bug was initially created as a clone of Bug #1113476 +++ Description of problem: Currently snap-max-hard-limit, snap-max-soft-limit, and auto-delete values are getting displayed in gluster volume info even though they are not set explicitly. Version-Release number of selected component (if applicable): How reproducible: 1/1 Steps to Reproduce: 1. create a volume 2. gluster volume info Actual results: Even though value is not set explicitly, they are getting displayed. Expected results: Default values should not be displayed in gluster volume info. Display the value only when it is set explicitly by user. Additional info: [root@snapshot-24 glusterfs]# gluster v i Volume Name: vol1 Type: Distribute Volume ID: 0e2113bc-4489-4d38-a2a0-b31ddba76ec2 Status: Started Number of Bricks: 1 Transport-type: tcp Bricks: Brick1: 10.70.43.192:/brick0/b0 Options Reconfigured: features.barrier: disable snap-max-hard-limit: 100 snap-max-soft-limit: 90 auto-delete: enable Volume Name: vol2 Type: Distribute Volume ID: 1d76568a-50d4-418d-bff3-12b33ce972be Status: Started Number of Bricks: 1 Transport-type: tcp Bricks: Brick1: 10.70.43.192:/brick4/b4 Options Reconfigured: features.barrier: disable snap-max-hard-limit: 100 snap-max-soft-limit: 90 auto-delete: enable ------------------------------------------------------ --- Additional comment from Anand Avati on 2014-06-27 07:34:16 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit and soft-limit and auto-delete value in gluster volume info.) posted (#1) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-06-30 05:37:01 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit and soft-limit and auto-delete value in gluster volume info.) posted (#2) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-01 06:33:11 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit and soft-limit and auto-delete value in gluster volume info.) posted (#3) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-03 02:15:34 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.) posted (#4) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-03 02:17:44 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.) posted (#5) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-15 02:01:52 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.) posted (#6) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-15 05:18:44 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.) posted (#7) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-15 06:26:30 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info) posted (#8) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-15 15:08:44 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.) posted (#9) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-16 06:19:57 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.) posted (#10) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-17 01:52:39 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.) posted (#11) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-18 02:15:29 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.) posted (#12) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-18 06:25:14 EDT --- REVIEW: http://review.gluster.org/8191 (cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info.) posted (#13) for review on master by Sachin Pandit (spandit) --- Additional comment from Anand Avati on 2014-07-24 06:04:00 EDT --- COMMIT: http://review.gluster.org/8191 committed in master by Kaushal M (kaushal) ------ commit 00bcf8e80bd65de7a8a102b137d35af3ba2cc3c1 Author: Sachin Pandit <spandit> Date: Thu Jun 26 07:51:02 2014 +0530 cli/snapshot : Dont display the snapshot hard-limit, soft-limit and auto-delete value in gluster volume info. Problem : Even though snap-max-hard-limit, snap-max-soft-limit and auto-delete values were not set explicitly, It was getting showed in the output of gluster volume info. Solution : Check if the value is already present in dictionary (That means, it is set), If value is not present then consider the default value, NOTE : This patch doesn't solve the problem where the values which is set globally are being displayed in gluster volume info Change-Id: I61445b3d2a12eb68c38a19bea53b9051ad028050 BUG: 1113476 Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/8191 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj> Reviewed-by: Avra Sengupta <asengupt> Reviewed-by: Raghavendra Bhat <raghavendra> Reviewed-by: Kaushal M <kaushal>
REVIEW: http://review.gluster.org/8793 (cli/snapshot : gluster volume info should not show the value which are not set explicitly.) posted (#1) for review on release-3.6 by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/8793 (cli/snapshot : gluster volume info should not show the options which are not set explicitly.) posted (#2) for review on release-3.6 by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/8793 (cli/snapshot : gluster volume info should not show the value which are not set explicitly.) posted (#3) for review on release-3.6 by Sachin Pandit (spandit)
REVIEW: http://review.gluster.org/8793 (cli/snapshot : gluster volume info should not show the options which are not set explicitly.) posted (#4) for review on release-3.6 by Sachin Pandit (spandit)
COMMIT: http://review.gluster.org/8793 committed in release-3.6 by Vijay Bellur (vbellur) ------ commit b98ed29cf6c1b999a025dff2269118a9198bd987 Author: Sachin Pandit <spandit> Date: Thu Jun 26 07:51:02 2014 +0530 cli/snapshot : gluster volume info should not show the options which are not set explicitly. Problem : Even though snap-max-hard-limit, snap-max-soft-limit and auto-delete values were not set explicitly, It was getting showed in the output of gluster volume info. Solution : Check if the value is already present in dictionary (That means, it is set), If value is not present then consider the default value, NOTE : This patch doesn't solve the problem where the values which is set globally are being displayed in gluster volume info Change-Id: I61445b3d2a12eb68c38a19bea53b9051ad028050 BUG: 1145020 Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/8191 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj> Reviewed-by: Avra Sengupta <asengupt> Reviewed-by: Raghavendra Bhat <raghavendra> Reviewed-by: Kaushal M <kaushal> Signed-off-by: Sachin Pandit <spandit> Reviewed-on: http://review.gluster.org/8793 Reviewed-by: Vijaikumar Mallikarjuna <vmallika>
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018883.html [2] http://supercolony.gluster.org/pipermail/gluster-users/
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report. glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html [2] http://supercolony.gluster.org/mailman/listinfo/gluster-users