Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit-0.4.1-1.fc20.src.rpm Description: Python 2 wrapper for wkhtmltopdf utility to convert HTML to PDF Fedora Account System Username: williamjmorenor
This is my first package and I need a Sponsoor
Koji build completed ok on rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=7707694
Some initial comments: - The upstream summary is better IMO. It actually describes the package. - Your are missing a Requires. >>> import pdfkit >>> pdfkit.from_url('http://google.com', 'out.pdf') which: no wkhtmltopdf in (/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/usr/bin/mozart2-2.0.0-alpha.0+build.3777.62f3ec5-x86_64-linux/bin:/home/mayorga/.local/bin:/home/mayorga/bin:/usr/bin/mozart2-2.0.0-alpha.0+build.3777.62f3ec5-x86_64-linux/bin) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python2.7/site-packages/pdfkit/api.py", line 22, in from_url configuration=configuration) File "/usr/lib/python2.7/site-packages/pdfkit/pdfkit.py", line 39, in __init__ self.configuration = (Configuration() if configuration is None File "/usr/lib/python2.7/site-packages/pdfkit/configuration.py", line 27, in __init__ 'https://github.com/JazzCore/python-pdfkit/wiki/Installing-wkhtmltopdf' % self.wkhtmltopdf) IOError: No wkhtmltopdf executable found: "" If this file exists please check that this process can read it. Otherwise please install wkhtmltopdf - https://github.com/JazzCore/python-pdfkit/wiki/Installing-wkhtmltopdf wkhtmltopdf is needed at runtime. Otherwise, it looks fine.
So Requires: wkhtmltopdf The requires is on the .spec Can you please check if wkhtmltopdf http://google.com google.pdf Is working OK on your machine
It is look like is fixed: >>> import pdfkit >>> pdfkit.from_url('http://google.com', 'out.pdf') loaded the Generic plugin Loading page (1/2) Printing pages (2/2) Done True
Fixed %doc macro: Updated .spec: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit.spec Updater .src.rpm: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit-0.4.1-2.fc20.src.rpm Koji bluid on rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=7736964
0.4.1-3 Subpackage for Python3 and conditionals for Epel6 Updated .spec: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit.spec Updater .src.rpm: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit-0.4.1-3.fc20.src.rpm Koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=7765543
Hi William Some comments. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4 - You need python3-setuptools too, as buildrequires. why do you use --prefix=%{_prefix} - in py3 build?
I have added python3-setuptools as builrequires and --prefix=%{_prefix} is not necesary. Updated .spec: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit.spec Updater .src.rpm: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit-0.4.1-4.fc20.src.rpm
Koji builds: Rawhide OK http://koji.fedoraproject.org/koji/taskinfo?taskID=7891293 Epel 6 OK http://koji.fedoraproject.org/koji/taskinfo?taskID=7891430 Epel 5 Failled (arch noarch) http://koji.fedoraproject.org/koji/taskinfo?taskID=7891400
I have added python3 as requires in python3 subpackage. Updated .spec: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit.spec Updater .src.rpm: https://williamjmorenor.fedorapeople.org/rpmdev/python-pdfkit-0.4.1-5.fc20.src.rpm
Hi william, your package looks fine; so it is approved, I will sponsor you, welcome to the package maintainer group Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /home/makerpm/pdfkit/1145443-python- pdfkit/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pdfkit [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-pdfkit-0.4.1-5.fc20.noarch.rpm python3-pdfkit-0.4.1-5.fc20.noarch.rpm python-pdfkit-0.4.1-5.fc20.src.rpm python-pdfkit.noarch: W: spelling-error Summary(en_US) Wkhtmltopdf python3-pdfkit.noarch: W: spelling-error Summary(en_US) Wkhtmltopdf python3-pdfkit.noarch: W: spelling-error %description -l en_US wkhtmltopdf python-pdfkit.src: W: spelling-error Summary(en_US) Wkhtmltopdf python-pdfkit.src: W: spelling-error %description -l en_US wkhtmltopdf 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-pdfkit python3-pdfkit python-pdfkit.noarch: W: spelling-error Summary(en_US) Wkhtmltopdf python3-pdfkit.noarch: W: spelling-error Summary(en_US) Wkhtmltopdf python3-pdfkit.noarch: W: spelling-error %description -l en_US wkhtmltopdf 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- python-pdfkit (rpmlib, GLIBC filtered): python(abi) python3 wkhtmltopdf python3-pdfkit (rpmlib, GLIBC filtered): python(abi) Provides -------- python-pdfkit: python-pdfkit python3-pdfkit: python3-pdfkit Source checksums ---------------- https://pypi.python.org/packages/source/p/pdfkit/pdfkit-0.4.1.tar.gz : CHECKSUM(SHA256) this package : de930d07aa13be4828659c37187d2cd2579319accaacd599b1287a78878440d4 CHECKSUM(SHA256) upstream package : de930d07aa13be4828659c37187d2cd2579319accaacd599b1287a78878440d4 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/bin/fedora-review -b 1145443 -m fedora-20-x86_64 Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG == APPROVED == See this information for add your package to the collection https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner
New Package SCM Request ======================= Package Name: python-pdfkit Short Description: Python 2 wrapper for wkhtmltopdf utility to convert HTML to PDF Upstream URL: https://github.com/JazzCore/python-pdfkit Owners: williamjmorenor Branches: f19 f20 f21 el6 epel7 InitialCC: williamjmorenor
Git done (by process-git-requests).
python-pdfkit-0.4.1-5.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-pdfkit-0.4.1-5.el7
python-pdfkit-0.4.1-5.el7 has been pushed to the Fedora EPEL 7 testing repository.
python-pdfkit-0.4.1-5.el7 has been pushed to the Fedora EPEL 7 stable repository.