Bug 1145460 - mingw-virt-viewer improvement - removing unused dlls
Summary: mingw-virt-viewer improvement - removing unused dlls
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: mingw-virt-viewer
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.6.0
Assignee: Default Assignee for SPICE Bugs
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-23 06:57 UTC by Wade Mealing
Modified: 2015-02-25 06:54 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-25 06:54:12 UTC
oVirt Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Wade Mealing 2014-09-23 06:57:48 UTC
Description of problem:

Removing unused dll's and files from mingw-virt-viewer package.

For example:

msiextract *msi | grep tls
bin/libgnutls-26.dll 

According to discussion:

Remote-viewer does not use gnutls, but openssl.  gnutls should be pulled in via dependency chain as: mingw-virt-viewer -> libvirt -> gnutls.

This is being included in the mingw-virt-viewer.msi installer and is not required to be packaged.

I would like to start a conversation here about removing the unused dependencies (going forward for newer releases).

Can we put this on the roadmap for a release ?

Thanks,

Wade Mealing.

Comment 2 Marc-Andre Lureau 2014-10-06 16:16:42 UTC
(In reply to Wade Mealing from comment #0)
> Description of problem:
> 
> Removing unused dll's and files from mingw-virt-viewer package.
> 
> For example:
> 
> msiextract *msi | grep tls
> bin/libgnutls-26.dll 
> 
> According to discussion:
> 
> Remote-viewer does not use gnutls, but openssl.  gnutls should be pulled in
> via dependency chain as: mingw-virt-viewer -> libvirt -> gnutls.

Correct, so virt-viewer depends on gnutls.

If we were to package only remote-viewer we would be able to remove the dll. but this would create more complexity and would use even more size if you need both remote-viewer and virt-viewer installed.

I would rather not see that happen.
 
> 
> This is being included in the mingw-virt-viewer.msi installer and is not
> required to be packaged.
> 
> I would like to start a conversation here about removing the unused
> dependencies (going forward for newer releases).

Afaik we have only the needed dependencies for remote-viewer and virt-viewer.

We pack almost all of the runtime files from the dependenices. Some DLL might be unneeded today, but this can quickly change.

Picking manually each file is is fragile and difficult task.

Feel free to give a list of files to remove, we should be able to add a more conditions to wxi or --exculde file filter to wixl (it would need upstream support first).

> Can we put this on the roadmap for a release ?

I would say only if the gain is substantial: today disk space is really cheap.

Comment 8 Wade Mealing 2014-12-22 08:02:24 UTC
So, I'm just wondering where we are in the planning stage of this.  Can we get this in some kind of release planning ?

Comment 9 Victor Toso 2014-12-22 15:17:02 UTC
At some extension we do take care of what is packed into the msi. Only the necessary modules for gstreamer are packed, for instance.

(In reply to Wade Mealing from comment #8)
> So, I'm just wondering where we are in the planning stage of this.  Can we
> get this in some kind of release planning ?

In the next release we are changing and including a few dependencies which may include more unused dlls. We could take a further look after that?

Do you know any other besides libgnutls?

Comment 10 Wade Mealing 2015-01-30 04:30:48 UTC
Not off the top of my head Victor, I don't know how much of the libatk and gtk dlls that are included/needed.   

Thanks.

Comment 11 Wade Mealing 2015-02-12 04:53:35 UTC
Its ok, I"m going to close this issue as I dont think its important enough and we'll address this if it becomes a problem.

Thanks and sorry for the bother.


Note You need to log in before you can comment on or make changes to this bug.