Bug 1145786

Description of problem:
This is far from an exhaustive look at the validation text that can be shown when a user submits something that is blank or incorrect, but there's a large amount of overlap between strings that are essentially saying the same thing, yet worded differently, or in a different order. Other strings could be avoided with some tweaks to the UI or could be avoided with a bit more processing of inputs. All of the text starts with a lowercase word, which doesn't match the capitalization used for descriptive text that the validation text replaces when triggered.

Within the New Host dialog, we see:
is invalid
can't be blank
can't be blank and is invalid
is invalid and can't be blank
can't be blank unless a custom partition has been defined

Within New Operating System:
can't be blank or contain white spaces
is not a number and Operating System version is required
is not a number

Within Provisioning Templates:
can't be blank and can't be blank
Selecting a file will override the editor and load the file instead

Within Partition Tables:
can't be blank or contain trailing white spaces


It would be nice if we said why a given input was invalid, so the user has some idea what they need to change to provide a valid input.

'Can't be blank' is another way of saying a field is required, which we could simply indicate with text or an * next to the field label. It's important to indicate which fields are required and which aren't, prior to trying to save/submit, if not everything we're asking for is required.

It seems like it would be more maintainable if we standardized on an arrangement of words, rather than having 'can't be blank and is invalid' as well as 'is invalid and can't be blank'.

One of them is duplicated, and for a single field says 'can't be blank and can't be blank'. (name within the Provisioning template dialog)

If we did a trim() within partition table names, couldn't we avoid having to tell them to delete trailing white spaces from their provided value? That seems like something we should take care of, rather than causing a problem for the user and making them delete an extra space at the end and try again to Save.

The validation text for Major version seems to refers to itself as Operating System version. There aren't any fields named Operating System version in that dialog.

At least the 'can't be blank' string can be triggered within the New Deployment screen in Staypuft (name should just be marked as required).

Version-Release number of selected component (if applicable):
foreman-installer-1.5.0-0.6.RC2.el6ost.noarch
rhel-osp-installer-0.1.10-2.el6ost.noarch
openstack-foreman-installer-2.0.20-1.el6ost.noarch
ruby193-rubygem-staypuft-0.2.5-1.el6ost.noarch


Additional info: