Bug 1146252

rubygem-staypuft:  Selecting hosts with different interfaces in the "Configure Networks" prompts  "<hostname> does not have interfaces with same names", Exiting from that error messes up the UI.


Environment:
rhel-osp-installer-0.3.6-1.el6ost.noarch
ruby193-rubygem-foreman_openstack_simplify-0.0.6-8.el6ost.noarch
openstack-foreman-installer-2.0.26-1.el6ost.noarch
openstack-puppet-modules-2014.1-21.8.el6ost.noarch

Steps to reproduce:
1. Run rhel-osp-installer
2. Create a deployment of any type.
3. Assign hosts to deployment.
4. Go to the host tab of the deployment and click on free.
5. Select hosts with at least one different NIC and click on the "configure network" button.
6. You should get an error: <hostname> does not have interfaces with same names
7. Close that error
Result:
The UI becomes messed up. You'll see doubles of the top menu. If you redo steps 5-7, the mess will get worse and the UI will also get stuck for some time.

Expected result:
The UI shouldn't get messed up/stuck when hosts with different NICs are selected.

https://github.com/theforeman/staypuft/pull/327

Merged upstream

The error isn't thrown now at all, allowing to configure networks for hosts with different NICs, which is wrong.

Verification: FailedQA

Environment:
rhel-osp-installer-0.4.2-1.el6ost.noarch
ruby193-rubygem-foreman_openstack_simplify-0.0.6-8.el6ost.noarch
openstack-puppet-modules-2014.1-23.el6ost.noarch
openstack-foreman-installer-2.0.29-1.el6ost.noarch


The error isn't thrown now at all, allowing to configure networks for hosts with different NICs, which is wrong.

Can you verify that the error is still thrown if the assignments for the nics are different -- or whether that one is also failing to trigger? Basically take 2 hosts with the same network config, assign nics on one of them, and then attempt to assign nics to both. If this is working correctly, you should get an error message saying that the hosts have differing nic assignments.

Verified: FailedQA
Environment:
openstack-puppet-modules-2014.1-24.el6ost.noarch
rhel-osp-installer-0.4.5-1.el6ost.noarch
ruby193-rubygem-foreman_openstack_simplify-0.0.6-8.el6ost.noarch
openstack-foreman-installer-2.0.30-1.el6ost.noarch
ruby193-rubygem-staypuft-0.4.8-1.el6ost.noarch


What happens now is as following:
The following error is shown to the user:
<hostname>: does not have interfaces with same names

And then the user is redirected to the overview page of the deployment.



1. No redirection should occur. 
2. There are at least 2 hosts selected, perhaps its better just to mention that the selected hosts don't have all interfaces with same names.

This bug was filed because the UI would get messed up when the error was closed.  Based on the comments, the UI does not get get messed up anymore.  

Other issues, such as improving the message or redirection should be filed separately as new issues

Verified:
openstack-puppet-modules-2014.1-24.el6ost.noarch
rhel-osp-installer-0.4.5-1.el6ost.noarch
ruby193-rubygem-foreman_openstack_simplify-0.0.6-8.el6ost.noarch
openstack-foreman-installer-2.0.30-1.el6ost.noarch
ruby193-rubygem-staypuft-0.4.8-1.el6ost.noarch

The reported issue doesn't reproduce.
Based on comments #12 and #13 resolving the bug.
The issue from comment #12 is reported in BZ #1155646.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2014-1800.html