Bug 1146457 - [cli]storage_manager element is not validated correctly
Summary: [cli]storage_manager element is not validated correctly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-restapi
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 3.5.0
Assignee: Juan Hernández
QA Contact: Pavel Stehlik
URL:
Whiteboard: infra
Depends On: 1136061
Blocks: 1149106 1149107 rhev3.5beta3
TreeView+ depends on / blocked
 
Reported: 2014-09-25 09:47 UTC by Ondra Machacek
Modified: 2016-02-10 19:02 UTC (History)
10 users (show)

Fixed In Version: org.ovirt.engine-root-3.5.0-14
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1149106 1149107 (view as bug list)
Environment:
Last Closed: 2015-02-17 17:16:07 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 33364 0 ovirt-engine-3.5 MERGED restapi: Replace "storage_manager" with "spm" Never

Description Ondra Machacek 2014-09-25 09:47:36 UTC
Description of problem:


Version-Release number of selected component (if applicable):
rhevm-cli-3.5.0.4-1.el6ev.noarch.rpm

How reproducible:
always

Steps to Reproduce:
1. run command:
update host 'hostX' --storage_manager-priority 5

Actual results:
send: 'PUT /api/hosts/a5898cff-8836-4d60-ba85-c3219937beae HTTP/1.1\r\nHost: jenkins-vm-10.scl.lab.tlv.redhat.com\r\nAccept-Encoding: identity\r\nContent-Length: 93\r\nSession-TTL: 3600\r\nPrefer: persistent-auth\r\nCorrelation-Id: hosts_update_508dc25b-9098-4eee\r\nAccept: application/xml\r\nFilter: False\r\ncookie: JSESSIONID=EfGmN01Nlx3gddnOyjeyLCeC\r\nContent-type: application/xml\r\nAuthorization: Basic dXNlcnBvcnRhbDFAcWEubGFiLnRsdi5yZWRoYXQuY29tOjEyMzQ1Ng==\r\n\r\n'
send: '<host id="a5898cff-8836-4d60-ba85-c3219937beae">\n    <storage_manager priority="5"/>\n</host>\n'
reply: 'HTTP/1.1 400 Bad Request\r\n'
header: Date: Wed, 17 Sep 2014 20:18:34 GMT^M
header: JSESSIONID: EfGmN01Nlx3gddnOyjeyLCeC^M
header: Content-Type: application/xml^M
header: Content-Length: 179^M
header: Vary: Accept-Encoding^M
header: Connection: close^M
^MESC[KESC[?1lESC>ESC[1;31m   ERROR 
  status: 400^M
  reason: Bad Request^M
  detail: Value "" isn't a valid boolean, it should be "true" or "false"
  
ESC[1;m


Expected results:
Update successfully.

Additional info:
Works fine in javasdk.
Worked fine in 3.4 rhevm-cli.

Comment 1 Juan Hernández 2014-09-25 11:05:28 UTC
It isn't possible to restore the previous behavior, but we will introduce a new --spm-priority option that will work correctly and with the same meaning.

Comment 2 Juan Hernández 2014-09-25 11:08:35 UTC
Note that this needs to be fixed in the engine, then the Python SDK needs to be regenerated.

Comment 4 Eyal Edri 2014-10-07 07:13:00 UTC
this bug status was moved to MODIFIED before engine vt5 was built,
hence moving to on_qa, if this was mistake and the fix isn't in,
please contact rhev-integ

Comment 5 Petr Beňas 2014-10-13 13:09:07 UTC
works with --spm-priority in rhevm-sdk-python-3.5.0.7-2.el6ev.noarch

Comment 7 Eyal Edri 2015-02-17 17:16:07 UTC
rhev 3.5.0 was released. closing.


Note You need to log in before you can comment on or make changes to this bug.