Bug 1146618 - virDomainMigrateSetMaxDowntime can only be called during migration
Summary: virDomainMigrateSetMaxDowntime can only be called during migration
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-25 15:37 UTC by Chris St. Pierre
Modified: 2014-09-30 11:36 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-09-30 11:36:56 UTC
Embargoed:


Attachments (Terms of Use)
Patch to fix the bug described (990 bytes, text/plain)
2014-09-25 15:37 UTC, Chris St. Pierre
no flags Details

Description Chris St. Pierre 2014-09-25 15:37:12 UTC
Created attachment 941141 [details]
Patch to fix the bug described

Description of problem:

virDomainMigrateSetMaxDowntime can only be called during migration. Since migration is blocking, this is annoying at best, as it requires spawning a separate thread to set the max downtime. It's also an unnecessary and artificial limitation; setting the max downtime directly with qemu before migration starts works fine.

Version-Release number of selected component (if applicable):

HEAD

How reproducible:

Always

Steps to Reproduce:
1. Try to set the max downtime of a domain that is not being migrated.

Actual results:

Failure.

Expected results:

Success.

Additional info:

Patch attached.

Comment 1 Jiri Denemark 2014-09-26 16:52:54 UTC
Since you already prepared the patch in git, could you please use git to send the patch to libvir-list as described at http://libvirt.org/hacking.html#patches ?

Comment 2 Jiri Denemark 2014-09-30 11:36:56 UTC
Fixed by v1.2.9-rc2-5-gfe808d9:

commit fe808d95bf353647bb39b3bc468f5a841b5588dd
Author: Chris St. Pierre <chris.a.st.pierre>
Date:   Mon Sep 29 13:45:28 2014 +0000

    Allow setting migration max downtime any time
    
    This removes the artificial and unnecessary restriction that
    virDomainSetMaxDowntime() only be called while a migration is in
    progress.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1146618
    
    Signed-off-by: Jiri Denemark <jdenemar>


Note You need to log in before you can comment on or make changes to this bug.