Description of problem: update guide is presented even if there are no packages available for upgrading. Version-Release number of selected component (if applicable): rhevm-setup-3.5.0-0.13.beta.el6ev.noarch How reproducible: 1005 Steps to Reproduce: rhevm-setup Actual results: [root@pb-rh35 ~]# rhevm-setup [ INFO ] Stage: Initializing [ INFO ] Stage: Environment setup Configuration files: ['/etc/ovirt-engine-setup.conf.d/10-packaging.conf', '/etc/ovirt-engine-setup.conf.d/20-setup-ovirt-post.conf'] Log file: /var/log/ovirt-engine/setup/ovirt-engine-setup-20140925180339-fuc150.log Version: otopi-1.3.0_master (otopi-1.3.0-0.0.1.master.el6ev) [ INFO ] Stage: Environment packages setup [ INFO ] Stage: Programs detection [ INFO ] Stage: Environment setup [ INFO ] Stage: Environment customization Welcome to the RHEV 3.5 upgrade. Please read the RHEV 3.5 install guide https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Virtualization/3.5/html/Installation_Guide/index.html. Please refer to the RHEV Upgrade Helper application https://access.redhat.com/labs/rhevupgradehelper/ which will guide you in the upgrading process. Would you like to continue with the upgrade? (Yes, No) [Yes]: --== PRODUCT OPTIONS ==-- --== PACKAGES ==-- [ INFO ] Checking for product updates... [ INFO ] No product updates found Expected results: "|Welcome to the RHEV 3.5 upgrade." section is not shown. Additional info:
I'd personally close this bug - can be as wontfix, or as duplicate of bug 1105027. Currently, this verification question is asked at the very beginning of the customization stage, which generally means it's the first one - to make sure the user sees it before anything else. Moving it to after checking for updates, which is a quite later point, can in principle cause the user to see questions and/or face issues/problems mentioned in these links before seeing them. In bug 1105027 I suggested to ask this question only once per z-stream (i.e. ask from 3.4.z to 3.5.0 but not from it to 3.5.1 etc) and it was rejected (in a private discussion, though), suggesting that in principle we can put in these links also information relevant to upgrades inside minor. This is a bit different from this bug, but would also cover it if accepted. Petr, what do you think?
Can't you add another check for the upgrade? Just check if upgrade is availabe before displaying this info and you can leave the later check as it is. This would bring slight performance degradation, but in the worst case scenario, the download of repolists would be performed only once.
(In reply to Petr Beňas from comment #2) > Can't you add another check for the upgrade? The current code for checking for updates and this question are in two different packages, maintained separately. So doing this will either require copying the code or making it somehow available to both packages (the code, or at least the check result). I do not think it's worth it. But even if I did, > Just check if upgrade is > availabe before displaying this info and you can leave the later check as it > is. > This would bring slight performance degradation, but in the worst case > scenario, the download of repolists would be performed only once. No, in the worst case scenario this check will fail setup without telling the user where to look at upgrade issues. That's the main issue here.
I see, but still do not agree with closing the bug. The "Welcome to upgrade" info is pretty misleading and may cause a lot of customer confusion. I still think this should be solved.
(In reply to Petr Beňas from comment #4) > I see, but still do not agree with closing the bug. The "Welcome to upgrade" > info is pretty misleading and may cause a lot of customer confusion. I still > think this should be solved. Very well. I do not think it causes customer confusion, because customers generally run 'engine-setup' only when they want to upgrade after they already know there is an update, but you are more than welcome to suggest alternative text to reduce the confusion.
I don't think you're right. There are much more scenarios when rhevm-setup is being run: 1) existing setup and adding DWH 2) existing setup and adding Reports 3) restoring from backup It's not about wording, it's about workflow "Welcome to the RHEV 3.5 upgrade." -> "Would you like to continue with the upgrade? (Yes, No) [Yes]: Yes" -> "[ INFO ] No product updates found".
(In reply to Petr Beňas from comment #6) > I don't think you're right. There are much more scenarios when rhevm-setup > is being run: > 1) existing setup and adding DWH > 2) existing setup and adding Reports > 3) restoring from backup Probably should still point them at the links. We might put there info for issues found in these cases too. > It's not about wording, it's about workflow "Welcome to the RHEV 3.5 > upgrade." -> "Would you like to continue with the upgrade? (Yes, No) [Yes]: > Yes" -> "[ INFO ] No product updates found". What if the text was: "Welcome to the RHEV 3.5 Setup/Upgrade utility." ? Now it _is_ just wording :-) I guess we added this only for (what setup thinks about at that point as) an upgrade, mostly simply because in the past we had many more bugs during upgrades than during clean setups. Now, "in the future", the distinction is blurred (see e.g. your cases above), and setup/upgrade is even more complex. I really think we want to point users at these links in case they have problems, mostly always. Perhaps requiring confirmation is not as important, or can stay conditional (with conditions refined over time - although, as I said, making the condition "only if there really is an update" is too risky imo, and also not really relevant).
Agree your wording helps a bit. You may also rephrase the rest like "If you're upgrading, you probably want to check out these links ...". That's fine :) Only one issue still left, it's the ""Would you like to continue with the upgrade?" - "Yes" - "No product updates found".
(In reply to Petr Beňas from comment #8) > Agree your wording helps a bit. You may also rephrase the rest like "If > you're upgrading, you probably want to check out these links ...". That's > fine :) > > Only one issue still left, it's the ""Would you like to continue with the > upgrade?" - "Yes" - "No product updates found". I think we can solve this part with changing the text too. Given your output above, "Would you like to proceed?" instead of "Would you like to continue with the upgrade?" should be enough.
Welcome to the RHEV 3.5 setup/upgrade. Please read the RHEV 3.5 install guide https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Virtualization/3.5/html/Installation_Guide/index.html. Please refer to the RHEV Upgrade Helper application https://access.redhat.com/labs/rhevupgradehelper/ which will guide you in the upgrading process. Would you like to proceed? (Yes, No) [Yes]: Petr - ok for you?
Yes. Proceed is the right word here.
Note to QE - only the text changed, the logic remained the same. We still show the text only if we think (at that point) that it's an upgrade, but changed the text so that to not confuse the user if there actually is no real update.
Not in vt12... [root@pb-rh35 ~]# rhevm-setup [ INFO ] Stage: Initializing [ INFO ] Stage: Environment setup Configuration files: ['/etc/ovirt-engine-setup.conf.d/10-packaging-wsp.conf', '/etc/ovirt-engine-setup.conf.d/10-packaging.conf', '/etc/ovirt-engine-setup.conf.d/20-setup-ovirt-post.conf'] Log file: /var/log/ovirt-engine/setup/ovirt-engine-setup-20141203144650-lsrc8v.log Version: otopi-1.3.0 (otopi-1.3.0-1.el6ev) [ INFO ] Stage: Environment packages setup [ INFO ] Stage: Programs detection [ INFO ] Stage: Environment setup [ INFO ] Stage: Environment customization Welcome to the RHEV 3.5 upgrade. Please read the RHEV 3.5 install guide https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Virtualization/3.5/html/Installation_Guide/index.html. Please refer to the RHEV Upgrade Helper application https://access.redhat.com/labs/rhevupgradehelper/ which will guide you in the upgrading process. Would you like to continue with the upgrade? (Yes, No) [Yes]: No [ ERROR ] Failed to execute stage 'Environment customization': Upgrade aborted. [ INFO ] Stage: Clean up Log file is located at /var/log/ovirt-engine/setup/ovirt-engine-setup-20141203144650-lsrc8v.log [ INFO ] Generating answer file '/var/lib/ovirt-engine/setup/answers/20141203144805-setup.conf' [ INFO ] Stage: Pre-termination [ INFO ] Stage: Termination [ ERROR ] Execution of setup failed [root@pb-rh35 ~]# vim /etc/yum.repos.d/rhevm.repo [root@pb-rh35 ~]# rpm -qa rhevm-setup rhevm-setup-3.5.0-0.22.el6ev.noarch
needs to be tested on freshly installed vt12 and also on vt12 upgraded from 3.4
Verified in rhevm-setup-plugins-3.5.0-3.el6ev.noarch with upgrade from 3.4.4.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0196.html