Bug 1146869
| Summary: | virt-manager should show disk info for guest with disk type volume | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | tingting zheng <tzheng> | ||||||||||
| Component: | virt-manager | Assignee: | Giuseppe Scrivano <gscrivan> | ||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||||||
| Severity: | medium | Docs Contact: | |||||||||||
| Priority: | medium | ||||||||||||
| Version: | 7.1 | CC: | codong, dyuan, gscrivan, juzhou, mzhan | ||||||||||
| Target Milestone: | rc | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | virt-manager-1.1.0-5.el7 | Doc Type: | Bug Fix | ||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2015-03-05 10:07:16 UTC | Type: | Bug | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
tingting zheng
2014-09-26 09:37:56 UTC
patch series sent upstream: https://www.redhat.com/archives/virt-tools-list/2014-September/msg00247.html pushed upstream:
commit 5e8f35f5e6d2f86a6846e3725885980eb51a5eae
Author: Giuseppe Scrivano <gscrivan>
Date: Fri Sep 26 15:25:14 2014 +0200
virt-manager, details: fix path and size for disk type='volume'
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146869
Signed-off-by: Giuseppe Scrivano <gscrivan>
commit cce582719528a9f664e2064fe662ba7fa34dbb24
Author: Giuseppe Scrivano <gscrivan>
Date: Fri Sep 26 15:24:34 2014 +0200
virtinst: add support for disk type="volume"
Signed-off-by: Giuseppe Scrivano <gscrivan>
Try to verify with new build:
virt-manager-1.1.0-4.el7.noarch
steps:
1. Prepare a guest with disk type volume.
# virsh dumpxml rhel6.5-2
...
<disk type='volume' device='disk'>
<driver name='qemu' type='qcow2'/>
<source pool='default' volume='juzhou-rhel6.img'/>
<target dev='vda' bus='virtio'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
</disk>
2.Launch virt-manager,click the guest,open->show virtual hardware details->disk.
Check items "Source path" and "Storage size" showing:
（Details see Screenshot-2）
3. Try to delete guest rhel6.5-2 via virt-manager.
（Details see Screenshot-3）
Choose delete img file together (Details see Screenshot-4)
Result: Guest can be deleted with no error, but img file always existing.
# ls /var/lib/libvirt/images/juzhou-rhel6.img
/var/lib/libvirt/images/juzhou-rhel6.img
I think img file should be deleted and there is something wrong with "Source path", please help check and move this bug from ON_QA to ASSIGNED.
Created attachment 945209 [details]
Screenshot-2
Created attachment 945211 [details]
Screenshot-3
Created attachment 945212 [details]
Screenshot-4
I don't think the img file should be deleted as I see the manually configured storage pool like just a reference to a volume It seems correct to me to delete just the reference (by undefining the VM) instead of removing also the volume that is pointed to. (In reply to Giuseppe Scrivano from comment #10) > I don't think the img file should be deleted as I see the manually > configured storage pool like just a reference to a volume It seems correct > to me to delete just the reference (by undefining the VM) instead of > removing also the volume that is pointed to. From virt-manager GUI,we can choose whether delete the img file or not.For this kind of disk,if we choose delete img file when delete guest,the image is still there.BTW,we can use virsh undefine $guest --remove-all-storage to undefine and delete this kind of guest. # virsh undefine vm1 --remove-all-storage Domain vm1 has been undefined Volume 'hda'(sdl-test-sda) removed. Try to verify this issue with new build:
virt-manager-1.1.0-5.el7.noarch
steps:
1. Prepare a guest with disk type volume.
# virsh dumpxml test-rhel6-second |grep -A6 disk
<disk type='volume' device='disk'>
<driver name='qemu' type='raw' cache='none'/>
<source pool='default' volume='test-rhel6-second-sda'/>
<target dev='vda' bus='virtio'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
</disk>
<disk type='file' device='cdrom'>
<driver name='qemu' type='raw'/>
<target dev='hda' bus='ide'/>
<readonly/>
<address type='drive' controller='0' bus='0' target='0' unit='0'/>
</disk>
2.Launch virt-manager,click the guest,open->show virtual hardware details->disk.
Check items "Source path" and "Storage size" showing:
Source path: test-rhel6-second-sda
Storage size: 8.00GiB
3. Try to delete guest test-rhel6-second via virt-manager.
Result: Guest can be deleted with no error, and img file deleted together.
# ls /var/lib/libvirt/images/test-rhel6-second-sda
ls: cannot access /var/lib/libvirt/images/test-rhel6-second-sda: No such file or directory
Seen above steps and Comment 10 and Comment 11, move this bug from ON_QA to VERIFIED.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0427.html |