Bug 1147084 - RPM Build process modifies underlying code
Summary: RPM Build process modifies underlying code
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: openstack-keystone
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Alan Pevec (Fedora)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1147728
TreeView+ depends on / blocked
 
Reported: 2014-09-26 20:59 UTC by Adam Young
Modified: 2015-12-02 16:19 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1147728 (view as bug list)
Environment:
Last Closed: 2015-12-02 04:00:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Use PBR_VERSION instead of patching (3.52 KB, patch)
2014-09-26 20:59 UTC, Adam Young
no flags Details | Diff
Removes the associated patches (5.09 KB, patch)
2014-09-27 02:09 UTC, Adam Young
no flags Details | Diff
Use PBR_VERSION env var for building (2.69 KB, patch)
2014-09-30 00:40 UTC, Adam Young
no flags Details | Diff

Description Adam Young 2014-09-26 20:59:40 UTC
Created attachment 941719 [details]
Use PBR_VERSION instead of patching

Description of problem:

Due to an attempt to work around PBR, the spec file patches the code out of the git repository. This makes it very difficult for a developer to build their own RPM.  PBRO provides a means to work around this by setting the PBR_VERSION Environment  variable.

Comment 1 Adam Young 2014-09-27 02:09:51 UTC
Created attachment 941760 [details]
Removes the associated patches

Removes the associated patches

Comment 2 Adam Young 2014-09-30 00:40:56 UTC
Created attachment 942551 [details]
Use PBR_VERSION env var for building

Comment 3 Alan Pevec 2014-09-30 17:23:26 UTC
Comment on attachment 941760 [details]
Removes the associated patches

sync-parameter-values-with-keystone-dist.conf.patch is not related, but I could look into removing it and do script sync during build like in other packages
e.g. http://pkgs.fedoraproject.org/cgit/openstack-nova.git/tree/openstack-nova.spec#n437

Comment 4 Fedora End Of Life 2015-11-04 15:05:56 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2015-12-02 04:00:42 UTC
Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.