Bug 1147107 - Cannot set distribute.migrate-data xattr on a file
Summary: Cannot set distribute.migrate-data xattr on a file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
Assignee: Dan Lambright
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-26 23:05 UTC by Dan Lambright
Modified: 2015-05-14 17:35 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 17:26:13 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Dan Lambright 2014-09-26 23:05:30 UTC
Description of problem:

Cannot set distribute.migrate-data xattr on a file to make it migrate. It works when it is internally driven but cannot be set from the shell.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a <file> on a dispersed mounted volume <V>.
2. Add a brick.
3. Try to move the file using setfattr -n distribute.migrate-data -v a /mnt/<V>/<file>

Actual results:
setfattr fails.

Expected results:
File gets moved to new brick per new layout.

Additional info:
Failure appears to be due to unpopulated fields in loc_t: parent, pargfid, and name. They are needed by the rebalance task.

Comment 1 Niels de Vos 2014-09-27 18:41:47 UTC
That it fails is kind-of expected. Extended attributes (when set through the filesystem) should probably start with "trusted.". In the case of "distribute.migrate-data", there should probably be a handler for "trusted.distribute.migrate-data" too, or maybe "trusted.glusterfs.distribute.migrate-data"?

Comment 2 Dan Lambright 2014-09-29 16:30:59 UTC
yes, "trusted" makes sense. trusted.distribute,migrate-data seems like a good choice.For backward compatibility, the rebalance driver would still use distribute.migrate-data.

Comment 3 Niels de Vos 2014-11-27 14:54:55 UTC
The version that this bug has been reported against, does not get any updates from the Gluster Community anymore. Please verify if this report is still valid against a current (3.4, 3.5 or 3.6) release and update the version, or close this bug.

If there has been no update before 9 December 2014, this bug will get automatocally closed.

Comment 4 Anand Avati 2014-12-16 15:36:57 UTC
REVIEW: http://review.gluster.org/9284 ( Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data.     Modify dht_setxattr to accept trusted.distribute.mig\ rate-data xattr on a file to make it migrate.     The change makes this work both when it is internally driven and from the shell.     The problem is furthe\ r described in bugzilla # 114707.) posted (#1) for review on master by Dan Lambright (dlambrig)

Comment 5 Anand Avati 2014-12-19 13:16:09 UTC
REVIEW: http://review.gluster.org/9284 (Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data and work from CLI.) posted (#2) for review on master by Dan Lambright (dlambrig)

Comment 6 Anand Avati 2014-12-19 13:16:27 UTC
REVIEW: http://review.gluster.org/9317 (This change makes rebalancing a file invokable from the CLI.) posted (#1) for review on master by Dan Lambright (dlambrig)

Comment 7 Anand Avati 2014-12-19 14:02:58 UTC
REVIEW: http://review.gluster.org/9284 (Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data and work with CLI.) posted (#3) for review on master by Dan Lambright (dlambrig)

Comment 8 Anand Avati 2014-12-23 15:21:55 UTC
REVIEW: http://review.gluster.org/9284 (cluster/dht: Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data and work with CLI.) posted (#4) for review on master by Dan Lambright (dlambrig)

Comment 9 Anand Avati 2015-01-08 22:02:34 UTC
REVIEW: http://review.gluster.org/9284 (cluster/dht: Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data and work with CLI.) posted (#5) for review on master by Dan Lambright (dlambrig)

Comment 10 Anand Avati 2015-01-08 22:08:11 UTC
REVIEW: http://review.gluster.org/9284 (cluster/dht: Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data and work with CLI.) posted (#6) for review on master by Dan Lambright (dlambrig)

Comment 11 Anand Avati 2015-01-30 15:30:48 UTC
REVIEW: http://review.gluster.org/9284 (cluster/dht: Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data and work with CLI.) posted (#7) for review on master by Dan Lambright (dlambrig)

Comment 12 Anand Avati 2015-01-30 17:57:23 UTC
REVIEW: http://review.gluster.org/9284 (cluster/dht: Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data and work with CLI.) posted (#8) for review on master by Dan Lambright (dlambrig)

Comment 13 Anand Avati 2015-02-10 21:18:31 UTC
REVIEW: http://review.gluster.org/9284 (cluster/dht: Modify dht-rebalance.c to use trusted.distribute.migrate-data rather than distribute.migrate-data and work with CLI.) posted (#9) for review on master by Dan Lambright (dlambrig)

Comment 14 Anand Avati 2015-02-13 15:19:50 UTC
COMMIT: http://review.gluster.org/9284 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 04c4ec96b88ee6392812a511de32b48bbe63a421
Author: Dan Lambright <dlambrig>
Date:   Tue Dec 16 10:28:57 2014 -0500

    cluster/dht: Modify dht-rebalance.c to use trusted.distribute.migrate-data
    rather than distribute.migrate-data and work with CLI.
    
    The change makes this work both when it is internally driven and from the
    shell. The problem is further described in bugzilla # 1147107.
    
    Change-Id: I4fe04cae661dca25432530ddf5ac6ff2c957d6b3
    BUG: 1147107
    Signed-off-by: Dan Lambright <dlambrig>
    Reviewed-on: http://review.gluster.org/9284
    Reviewed-by: N Balachandran <nbalacha>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 15 Niels de Vos 2015-05-14 17:26:13 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 16 Niels de Vos 2015-05-14 17:28:14 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 17 Niels de Vos 2015-05-14 17:35:14 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.