Bug 1147269 - Review Request: GeographicLib - Library for geographic coordinate transformations
Summary: Review Request: GeographicLib - Library for geographic coordinate transformat...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Florian "der-flo" Lehner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-28 17:41 UTC by Rich Mattes
Modified: 2014-10-16 01:56 UTC (History)
2 users (show)

Fixed In Version: GeographicLib-1.38-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-16 01:56:54 UTC
Type: ---
Embargoed:
dev: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rich Mattes 2014-09-28 17:41:39 UTC
Spec URL: https://rmattes.fedorapeople.org/RPMS/GeographicLib/GeographicLib.spec
SRPM URL: https://rmattes.fedorapeople.org/RPMS/GeographicLib/GeographicLib-1.37-1.fc20.src.rpm

Description: 
GeographicLib is a small set of C++ classes for performing conversions
between geographic, UTM, UPS, MGRS, geocentric, and local cartesian
coordinates, for gravity (e.g., EGM2008), geoid height and geomagnetic
field (e.g., WMM2010) calculations, and for solving geodesic problems.
The emphasis is on returning accurate results with errors close to round-off
(about 5–15 nanometers). New accurate algorithms for Geodesics on an
ellipsoid of revolution and Transverse Mercator projection have been
developed for this library. The functionality of the library can be accessed
from user code, from the Utility programs provided, or via the
Implementations in other languages.

Fedora Account System Username: rmattes

Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7715931

rpmlint:$ rpmlint GeographicLib.spec ../RPMS/noarch/GeographicLib-doc-1.37-1.fc20.noarch.rpm ../RPMS/noarch/python-GeographicLib-1.37-1.fc20.noarch.rpm ../RPMS/x86_64/GeographicLib-*
GeographicLib-doc.noarch: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen
GeographicLib.x86_64: W: spelling-error %description -l en_US cartesian -> Cartesian
GeographicLib.x86_64: W: spelling-error %description -l en_US geoid -> gelid, geode
GeographicLib.x86_64: W: spelling-error %description -l en_US nanometers -> manometers, anemometers, galvanometers
GeographicLib.x86_64: W: no-manual-page-for-binary geographiclib-get-magnetic
GeographicLib.x86_64: W: no-manual-page-for-binary geographiclib-get-gravity
GeographicLib.x86_64: W: no-manual-page-for-binary geographiclib-get-geoids
GeographicLib-devel.x86_64: W: only-non-binary-in-usr-lib
GeographicLib-devel.x86_64: W: no-documentation
5 packages and 1 specfiles checked; 0 errors, 9 warnings.

Comment 1 Florian "der-flo" Lehner 2014-10-03 08:06:36 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
[ ] Package contains BR: python2-devel or python3-devel
    Please fix your BuildRequires. For more information see:
    https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
[ ] Please update to latest version 1.38
[ ] At the beginning of %install. rm -rf %{buildroot} present
    but not required

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later)", "Unknown or generated".
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/cmake(cmake),
     /usr/share/cmake/Modules(cmake)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
   ---> see BuildRequires
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     GeographicLib-doc , python-GeographicLib
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
   ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7753337
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: GeographicLib-1.37-1.fc22.x86_64.rpm
          GeographicLib-devel-1.37-1.fc22.x86_64.rpm
          GeographicLib-doc-1.37-1.fc22.noarch.rpm
          python-GeographicLib-1.37-1.fc22.noarch.rpm
          GeographicLib-1.37-1.fc22.src.rpm
GeographicLib.x86_64: W: spelling-error %description -l en_US cartesian -> Cartesian
GeographicLib.x86_64: W: spelling-error %description -l en_US geoid -> gelid, geode
GeographicLib.x86_64: W: spelling-error %description -l en_US nanometers -> manometers, anemometers, galvanometers
GeographicLib.x86_64: W: no-manual-page-for-binary geographiclib-get-magnetic
GeographicLib.x86_64: W: no-manual-page-for-binary geographiclib-get-gravity
GeographicLib.x86_64: W: no-manual-page-for-binary geographiclib-get-geoids
GeographicLib-devel.x86_64: W: only-non-binary-in-usr-lib
GeographicLib-devel.x86_64: W: no-documentation
GeographicLib-doc.noarch: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen
GeographicLib.src: W: spelling-error %description -l en_US cartesian -> Cartesian
GeographicLib.src: W: spelling-error %description -l en_US geoid -> gelid, geode
GeographicLib.src: W: spelling-error %description -l en_US nanometers -> manometers, anemometers, galvanometers
5 packages and 0 specfiles checked; 0 errors, 12 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint GeographicLib GeographicLib-devel python-GeographicLib Geog 
raphicLib-doc
GeographicLib.x86_64: W: spelling-error %description -l en_US cartesian -> Cartesian
GeographicLib.x86_64: W: spelling-error %description -l en_US geoid -> gelid, geode
GeographicLib.x86_64: W: spelling-error %description -l en_US nanometers -> manometers, anemometers, galvanometers
GeographicLib.x86_64: W: no-manual-page-for-binary geographiclib-get-magnetic
GeographicLib.x86_64: W: no-manual-page-for-binary geographiclib-get-gravity
GeographicLib.x86_64: W: no-manual-page-for-binary geographiclib-get-geoids
GeographicLib-devel.x86_64: W: only-non-binary-in-usr-lib
GeographicLib-devel.x86_64: W: no-documentation
GeographicLib-doc.noarch: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen
4 packages and 0 specfiles checked; 0 errors, 9 warnings.
# echo 'rpmlint-done:'



Requires
--------
GeographicLib (rpmlib, GLIBC filtered):
    /bin/sh
    /sbin/ldconfig
    libGeographic.so.13()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

GeographicLib-devel (rpmlib, GLIBC filtered):
    GeographicLib(x86-64)
    libGeographic.so.13()(64bit)

python-GeographicLib (rpmlib, GLIBC filtered):
    python(abi)

GeographicLib-doc (rpmlib, GLIBC filtered):



Provides
--------
GeographicLib:
    GeographicLib
    GeographicLib(x86-64)
    libGeographic.so.13()(64bit)

GeographicLib-devel:
    GeographicLib-devel
    GeographicLib-devel(x86-64)

python-GeographicLib:
    python-GeographicLib

GeographicLib-doc:
    GeographicLib-doc



Source checksums
----------------
http://downloads.sourceforge.net/geographiclib/GeographicLib-1.37.tar.gz :
  CHECKSUM(SHA256) this package     : ebf2dec42d8b738024eb29ad36976ff8ea550eb4c005a07cb1b2abbc2e4d3de5
  CHECKSUM(SHA256) upstream package : ebf2dec42d8b738024eb29ad36976ff8ea550eb4c005a07cb1b2abbc2e4d3de5


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1147269
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 2 Rich Mattes 2014-10-04 14:25:57 UTC
Thanks for taking a look.

I've updated the spec based on the issues you pointed out, and did a little more cleanup for rpmlint purposes.  You can find the new version here:

Spec URL: https://rmattes.fedorapeople.org/RPMS/GeographicLib/GeographicLib.spec
SRPM URL: https://rmattes.fedorapeople.org/RPMS/GeographicLib/GeographicLib-1.38-1.fc21.src.rpm

scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7763309

rpmlint:
$ rpmlint ../RPMS/x86_64/GeographicLib-* ../RPMS/noarch/*GeographicLib* ./GeographicLib.spec 
GeographicLib.x86_64: W: spelling-error %description -l en_US geoid -> gelid, geode
GeographicLib.x86_64: W: spelling-error %description -l en_US nanometers -> manometers, anemometers, galvanometers
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 11: warning: macro `Vb' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 13: warning: macro `Ve' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 16: warning: macro `C`' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 16: warning: macro `C'' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 11: warning: macro `Vb' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 13: warning: macro `Ve' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 16: warning: macro `C`' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 16: warning: macro `C'' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 11: warning: macro `Vb' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 13: warning: macro `Ve' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 16: warning: macro `C`' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 16: warning: macro `C'' not defined
GeographicLib-devel.x86_64: W: only-non-binary-in-usr-lib
GeographicLib-devel.x86_64: W: no-documentation
GeographicLib-doc.noarch: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen
5 packages and 1 specfiles checked; 0 errors, 17 warnings.

This version of the package adds 3 generated manpages (the three missing manpages from the rpmlint output in the original release.)  It looks like the generator script includes a few macros that aren't defined, I'm not sure I know enough about what the author was trying to do to fix them.  The rest of the warnings are false positives as far as I can see.

Comment 3 Florian "der-flo" Lehner 2014-10-04 14:59:22 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later)", "Unknown or generated".
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/cmake(cmake),
     /usr/share/cmake/Modules(cmake)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     GeographicLib-doc , python-GeographicLib
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
   ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7763634
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: GeographicLib-1.38-1.fc22.x86_64.rpm
          GeographicLib-devel-1.38-1.fc22.x86_64.rpm
          GeographicLib-doc-1.38-1.fc22.noarch.rpm
          python-GeographicLib-1.38-1.fc22.noarch.rpm
          GeographicLib-1.38-1.fc22.src.rpm
GeographicLib.x86_64: W: spelling-error %description -l en_US geoid -> gelid, geode
GeographicLib.x86_64: W: spelling-error %description -l en_US nanometers -> manometers, anemometers, galvanometers
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 11: warning: macro `Vb' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 13: warning: macro `Ve' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 16: warning: macro `C`' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 16: warning: macro `C'' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 11: warning: macro `Vb' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 13: warning: macro `Ve' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 16: warning: macro `C`' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 16: warning: macro `C'' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 11: warning: macro `Vb' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 13: warning: macro `Ve' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 16: warning: macro `C`' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 16: warning: macro `C'' not defined
GeographicLib-devel.x86_64: W: only-non-binary-in-usr-lib
GeographicLib-devel.x86_64: W: no-documentation
GeographicLib-doc.noarch: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen
GeographicLib.src: W: spelling-error %description -l en_US geoid -> gelid, geode
GeographicLib.src: W: spelling-error %description -l en_US nanometers -> manometers, anemometers, galvanometers
5 packages and 0 specfiles checked; 0 errors, 19 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint GeographicLib GeographicLib-devel python-GeographicLib Geog 
raphicLib-doc
GeographicLib.x86_64: W: spelling-error %description -l en_US geoid -> gelid, geode
GeographicLib.x86_64: W: spelling-error %description -l en_US nanometers -> manometers, anemometers, galvanometers
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 11: warning: macro `Vb' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 13: warning: macro `Ve' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 16: warning: macro `C`' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-gravity.8.gz 16: warning: macro `C'' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 11: warning: macro `Vb' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 13: warning: macro `Ve' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 16: warning: macro `C`' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-geoids.8.gz 16: warning: macro `C'' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 11: warning: macro `Vb' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 13: warning: macro `Ve' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 16: warning: macro `C`' not defined
GeographicLib.x86_64: W: manual-page-warning /usr/share/man/man8/geographiclib-get-magnetic.8.gz 16: warning: macro `C'' not defined
GeographicLib-devel.x86_64: W: only-non-binary-in-usr-lib
GeographicLib-devel.x86_64: W: no-documentation
GeographicLib-doc.noarch: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen
4 packages and 0 specfiles checked; 0 errors, 17 warnings.
# echo 'rpmlint-done:'



Requires
--------
GeographicLib (rpmlib, GLIBC filtered):
    /bin/sh
    /sbin/ldconfig
    libGeographic.so.13()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

GeographicLib-devel (rpmlib, GLIBC filtered):
    GeographicLib(x86-64)
    libGeographic.so.13()(64bit)

python-GeographicLib (rpmlib, GLIBC filtered):
    python(abi)

GeographicLib-doc (rpmlib, GLIBC filtered):



Provides
--------
GeographicLib:
    GeographicLib
    GeographicLib(x86-64)
    libGeographic.so.13()(64bit)

GeographicLib-devel:
    GeographicLib-devel
    GeographicLib-devel(x86-64)

python-GeographicLib:
    python-GeographicLib

GeographicLib-doc:
    GeographicLib-doc



Source checksums
----------------
http://downloads.sourceforge.net/geographiclib/GeographicLib-1.38.tar.gz :
  CHECKSUM(SHA256) this package     : 13904610395efb0b2a94729a912688aca87b02cf7518633178c6a4a829aeff8c
  CHECKSUM(SHA256) upstream package : 13904610395efb0b2a94729a912688aca87b02cf7518633178c6a4a829aeff8c


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1147269
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

===== Solution =====
      APPROVED

Comment 4 Rich Mattes 2014-10-04 16:17:51 UTC
Thanks for the review!

New Package SCM Request
=======================
Package Name: GeographicLib
Short Description: Library for geographic coordinate transformations
Upstream URL: http://geographiclib.sourceforge.net/
Owners: rmattes
Branches: f19 f20 f21 el6 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2014-10-06 12:27:18 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-10-06 22:49:41 UTC
GeographicLib-1.38-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/GeographicLib-1.38-2.fc21

Comment 7 Fedora Update System 2014-10-08 18:53:09 UTC
GeographicLib-1.38-2.fc21 has been pushed to the Fedora 21 testing repository.

Comment 8 Fedora Update System 2014-10-16 01:56:54 UTC
GeographicLib-1.38-2.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.