Bug 1147330 - Review Request: libason - A library for manipulating ASON values
Summary: Review Request: libason - A library for manipulating ASON values
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mairi Dulaney
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-29 03:31 UTC by Casey Dahlin
Modified: 2015-02-04 08:01 UTC (History)
4 users (show)

Fixed In Version: libason-0.1.2-2.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-04 08:00:02 UTC
Type: ---
Embargoed:
jdulaney: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Casey Dahlin 2014-09-29 03:31:46 UTC
Spec URL: https://sadmac.fedorapeople.org/libason.spec
SRPM URL: https://sadmac.fedorapeople.org/libason-0.1.1-1.fc20.src.rpm
Description: ASON is an extension of JSON that provides it with a semantic, as well as expressions for representing patterns that define entire categories of values rather than just singular values.
Fedora Account System Username: sadmac

Comment 1 Mairi Dulaney 2014-09-29 05:21:47 UTC
Review #1:

jdulaney@gefjon:~/rpmbuild/SPECS$ rpmlint ./libason.spec 
./libason.spec: W: invalid-url Source0: https://github.com/sadmac7000/libason/releases/download/v0.1/libason-0.1.1.tar.gz HTTP Error 404: Not Found
0 packages and 1 specfiles checked; 0 errors, 1 warnings.


jdulaney@gefjon:~/rpmbuild/SRPMS$ rpmlint ./libason-0.1.1-1.fc21.src.rpm 
libason.src: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally
libason.src: W: invalid-url Source0: https://github.com/sadmac7000/libason/releases/download/v0.1/libason-0.1.1.tar.gz HTTP Error 404: Not Found
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Missing build dependencies:
lcov
readline-devel
texlive-latex-bin-bin

Comment 2 Mairi Dulaney 2014-09-29 05:35:21 UTC
Also, when building inside mock environment:


config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating include/Makefile
config.status: creating tests/Makefile
config.status: creating doc/Makefile
config.status: creating include/config.h
config.status: executing depfiles commands
configure: WARNING: unrecognized options: --without-spec
+ make -j2
Making all in src
make[1]: Entering directory `/builddir/build/BUILD/libason-0.1.1/src'
  CC       value.lo
  CC       output.lo
  CC       iter.lo
  CC       stringfunc.lo
  CC       namespace.lo
  CC       namespace_ram.lo
  CC       crc.lo
  CC       parse.lo
  CC       asonq.o
  CCLD     libason.la
  CCLD     asonq
make[1]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/src'
Making all in include
make[1]: Entering directory `/builddir/build/BUILD/libason-0.1.1/include'
make  all-am
make[2]: Entering directory `/builddir/build/BUILD/libason-0.1.1/include'
make[2]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/include'
make[1]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/include'
Making all in tests
make[1]: Entering directory `/builddir/build/BUILD/libason-0.1.1/tests'
  CC       parser_test.o
  CC       harness.o
  CC       print_object.o
  CC       iterator_test.o
  CC       crc_test.o
  CC       value_test-value_test.o
  CC       value_test-harness.o
  CC       ns_test.o
  CCLD     parser_test
  CCLD     print_object
  CCLD     iterator_test
  CC       ../src/crc.o
  CCLD     value_test
  CCLD     crc_test
  CCLD     ns_test
make[1]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/tests'
Making all in doc
make[1]: Entering directory `/builddir/build/BUILD/libason-0.1.1/doc'
 cd .. && automake-1.13 --foreign doc/Makefile
/bin/sh: line 10: automake-1.13: command not found
make[1]: *** [Makefile.in] Error 127
make[1]: Leaving directory `/builddir/build/BUILD/libason-0.1.1/doc'
make: *** [all-recursive] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.O2QCCH (%build)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.O2QCCH (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps  builddir/build/SPECS/libason.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 70, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 378, in do
    raise mockbuild.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps  builddir/build/SPECS/libason.spec']
LEAVE do --> EXCEPTION RAISED

Comment 3 Casey Dahlin 2014-09-29 07:09:36 UTC
Ok, I've updated both files. Everything is fixed but the spelling error (which I contest).

Comment 4 Mairi Dulaney 2014-09-29 17:28:49 UTC
jdulaney@gefjon:~/rpmbuild/SPECS$ rpmlint ./libason.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.




jdulaney@gefjon:~/rpmbuild/SPECS$ rpmbuild -ba libason.spec 
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.dR3k0a
+ umask 022
+ cd /home/jdulaney/rpmbuild/BUILD
+ cd /home/jdulaney/rpmbuild/BUILD
+ rm -rf libason-0.1.1
+ /usr/bin/gzip -dc /home/jdulaney/rpmbuild/SOURCES/libason-0.1.1.tar.gz
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd libason-0.1.1
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ echo 'Patch #0 (no_man_symlinks.patch):'
Patch #0 (no_man_symlinks.patch):
+ /usr/bin/cat /home/jdulaney/rpmbuild/SOURCES/no_man_symlinks.patch
+ /usr/bin/patch -p1 --fuzz=0
patching file doc/Makefile.am
+ echo 'Patch #1 (config-fix.patch):'
Patch #1 (config-fix.patch):
+ /usr/bin/patch -p1 --fuzz=0
+ /usr/bin/cat /home/jdulaney/rpmbuild/SOURCES/config-fix.patch
patching file configure.ac
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.Xjm10x
+ umask 022
+ cd /home/jdulaney/rpmbuild/BUILD
+ cd libason-0.1.1
+ autoreconf
configure.ac:6: error: required file './compile' not found
configure.ac:6:   'automake --add-missing' can install 'compile'
autoreconf: automake failed with exit status: 1
error: Bad exit status from /var/tmp/rpm-tmp.Xjm10x (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.Xjm10x (%build)

Comment 5 Casey Dahlin 2014-09-30 01:52:52 UTC
Ok, I think I've got the last of the gremlins. Files updated.

Comment 6 Mairi Dulaney 2014-09-30 22:40:13 UTC
Good to go.

Comment 7 Casey Dahlin 2014-09-30 22:49:44 UTC
New Package SCM Request
=======================
Package Name: libason
Short Description: A library for manipulating ASON values
Upstream URL: https://github.com/sadmac7000/libason
Owners: sadmac
Branches: f20 f21 rawhide
InitialCC:

Comment 8 Mairi Dulaney 2014-09-30 23:00:10 UTC
rpmlint:

jdulaney@gefjon:~/rpmbuild/SPECS$ rpmlint ./libason.spec ../RPMS/x86_64/libason-0.1.1-1.fc21.x86_64.rpm ../SRPMS/libason-0.1.1-1.fc21.src.rpm libason.x86_64: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally
libason.src: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 9 Gwyn Ciesla 2014-10-01 09:51:24 UTC
Git done (by process-git-requests).

No need to request rawhide, it's automatic.

Comment 10 Fedora Update System 2014-10-03 00:35:41 UTC
libason-0.1.2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libason-0.1.2-1.fc20

Comment 11 Fedora Update System 2014-10-03 00:36:32 UTC
libason-0.1.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/libason-0.1.2-1.fc21

Comment 12 Fedora Update System 2014-10-04 03:20:31 UTC
libason-0.1.2-1.fc21 has been pushed to the Fedora 21 testing repository.

Comment 13 Christopher Meng 2014-10-04 04:57:45 UTC
Please pass this option to %configure:

--disable-silent-rules

Comment 14 Casey Dahlin 2014-10-06 16:29:50 UTC
I have done so. Builds in progress for all 3 branches.

Comment 15 Fedora Update System 2014-10-06 17:02:26 UTC
libason-0.1.2-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libason-0.1.2-2.fc20

Comment 16 Fedora Update System 2014-10-06 17:03:15 UTC
libason-0.1.2-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/libason-0.1.2-2.fc21

Comment 17 Christopher Meng 2015-02-03 06:07:16 UTC
When will it pushed to stable?

Comment 18 Casey Dahlin 2015-02-03 18:12:27 UTC
Pushed now. I believe the bot will close this when it lands

Comment 19 Fedora Update System 2015-02-04 08:00:02 UTC
libason-0.1.2-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2015-02-04 08:01:00 UTC
libason-0.1.2-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.