Spec URL: https://hguemar.fedorapeople.org/reviews/python-setproctitle.spec SRPM URL: https://hguemar.fedorapeople.org/reviews/python-zaqarclient-0.1.0-1.fc22.src.rpm Description: Python client to Zaqar messaging service API v1 Fedora Account System Username: hguemar
Spec URL: https://hguemar.fedorapeople.org/reviews/python-zaqarclient.spec SRPM URL: https://hguemar.fedorapeople.org/reviews/python-zaqarclient-0.1.0-1.fc22.src.rpm Description: Python client to Zaqar messaging service API v1 Fedora Account System Username: hguemar Tough morning ...
Looks all good to me, it even uses fancy new %license macro [1] [1] https://fedorahosted.org/fpc/ticket/411 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/jruzicka/work/reviews/1147449 -python-zaqarclient/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses This is due to new %license macro [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses This is due to new %license macro [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-zaqarclient-0.1.0-1.fc20.noarch.rpm python-zaqarclient-0.1.0-1.fc20.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-zaqarclient 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- python-zaqarclient (rpmlib, GLIBC filtered): python(abi) python-jsonschema python-keystoneclient python-six python-stevedore Provides -------- python-zaqarclient: python-zaqarclient Source checksums ---------------- https://pypi.python.org/packages/source/p/python-zaqarclient/python-zaqarclient-0.1.0.tar.gz : CHECKSUM(SHA256) this package : c705da44cccb1e7cfac781cd424be07fdbb814b65d1a153a660a3be89612f705 CHECKSUM(SHA256) upstream package : c705da44cccb1e7cfac781cd424be07fdbb814b65d1a153a660a3be89612f705 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/bin/fedora-review -b 1147449 Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
I removed the runtime dependency on PBR, spec and srpm updated Spec URL: https://hguemar.fedorapeople.org/reviews/python-zaqarclient.spec SRPM URL: https://hguemar.fedorapeople.org/reviews/python-zaqarclient-0.1.0-2.fc22.src.rpm
Thanks for the review Jakub and also Steven for his remarks :)
New Package SCM Request ======================= Package Name: python-zaqarclient Short Description: Client Library for OpenStack Zaqar Queueing API Upstream URL: http://wiki.openstack.org/zaqar Owners: hguemar fpercoco jruzicka Branches: f21 InitialCC:
WARNING: "fpercoco" is not a valid FAS account.
My apologies for that.
New Package SCM Request ======================= Package Name: python-zaqarclient Short Description: Client Library for OpenStack Zaqar Queueing API Upstream URL: http://wiki.openstack.org/zaqar Owners: hguemar flaper87 jruzicka Branches: f21 InitialCC:
Git done (by process-git-requests).
python-zaqarclient-0.1.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-zaqarclient-0.1.0-2.fc21
python-zaqarclient-0.1.0-2.fc21 has been pushed to the Fedora 21 testing repository.
python-zaqarclient-0.1.0-2.fc21 has been pushed to the Fedora 21 stable repository.