Bug 1147660 - Inconsistent network device naming
Summary: Inconsistent network device naming
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: virt-manager
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-29 19:01 UTC by Dr. David Alan Gilbert
Modified: 2015-03-25 12:49 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-03-25 12:49:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot of inconsistent menu (7.17 KB, image/png)
2014-09-29 19:04 UTC, Dr. David Alan Gilbert
no flags Details

Description Dr. David Alan Gilbert 2014-09-29 19:01:57 UTC
Description of problem:
Whereever you select a network device, the naming is inconsistent between macvtap and bridge  (see attached image)

Version-Release number of selected component (if applicable):
virt-manager-1.1.0-3.git310f6527.fc20.noarch
(on fc20 with virt-preview to a remote rhel7.0 host)

How reproducible:
100%

Steps to Reproduce:
1. RHEL7.0 VM host configured with a bridged network interface (em4) and a macvtap interface (on em1)
2. Create a new VM in virt-manager, select advanced options, click on menu
3.

Actual results:
'Bridge brpair (Host device em4)' vs
'Host device em1: macvtap'

Expected results:
'Host device em4: Bridge brpair'
'Host device em1: macvtap'

Additional info:

Comment 1 Dr. David Alan Gilbert 2014-09-29 19:04:21 UTC
Created attachment 942468 [details]
screenshot of inconsistent menu

Comment 2 Cole Robinson 2015-03-25 12:49:13 UTC
Thanks for the report, but I don't really agree here. Using that syntax has a few issues:

- bridges can have multiple host devices
- bridges can have no host devices
- historically for virt people tend to think of the bridge name rather than the host device that is bridged. so the important data is 'xenbr0' and not 'eth0'

That said the use of parentheses here needlessly differs from the macvtap format, so I pushed an upstream patch switching it to

Bridge brpair: Host device em4

commit 42247728523b1882732230a9c4a198c90a0f6719
Author: Cole Robinson <crobinso>
Date:   Wed Mar 25 08:47:21 2015 -0400

    netlist: Streamline bridge and macvtap labels (bz 1147660)

Closing as UPSTREAM since this is fairly minor


Note You need to log in before you can comment on or make changes to this bug.