Bug 1147795 - Review Request: perl-Digest-PBKDF2 - Digest module using the PBKDF2 algorithm
Summary: Review Request: perl-Digest-PBKDF2 - Digest module using the PBKDF2 algorithm
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-30 04:55 UTC by David Dick
Modified: 2014-10-17 17:37 UTC (History)
2 users (show)

Fixed In Version: perl-Digest-PBKDF2-0.010-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-08 19:13:18 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Dick 2014-09-30 04:55:28 UTC
Spec URL: https://ddick.fedorapeople.org/packages/perl-Digest-PBKDF2.spec
SRPM URL: https://ddick.fedorapeople.org/packages/perl-Digest-PBKDF2-0.010-1.fc20.src.rpm
Description: Digest module using the PBKDF2 algorithm
Fedora Account System Username: ddick

Comment 2 Petr Šabata 2014-09-30 09:11:35 UTC
The minimum version of Crypt::PBKDF2 required is 0.112020, not 0.14.
Why did you pick 0.14?  I don't see it referenced anywhere in the package.

Plus, if you wanted >= 0.14*, you should have used 0.140000, given how RPM version comparison works.

rpmdev-vercmp 0.112020 0.14                                             
0.112020 > 0.14

rpmbuild should also autodetect Crypt::PBKDF2 >= 0.112020 runtime dependency correctly, so there won't be a need for that filter and explicit Requires if you change this.

Comment 3 David Dick 2014-09-30 09:17:21 UTC
I over-complicated it i think.  Crypt-PBKDF2 has only ever existed in Fedora with versions greater than 0.112020, so the version can probably be gotten rid of?

Spec and SRPM have been updated to reflect this.

Comment 4 David Dick 2014-09-30 09:22:34 UTC
Sorry.  I've re-added them with the 0.112020 version put back in.

Comment 5 Petr Šabata 2014-09-30 11:04:34 UTC
(In reply to David Dick from comment #3)
> I over-complicated it i think.

Yes, you did :)

Looks fine now.  Approving.

Comment 6 David Dick 2014-09-30 11:23:44 UTC
Thanks Petr!

New Package SCM Request
=======================
Package Name: perl-Digest-PBKDF2
Short Description: Digest module using the PBKDF2 algorithm
Upstream URL: http://search.cpan.org/dist/Digest-PBKDF2/
Owners: ddick
Branches: f20, f21, epel7, el6
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2014-09-30 12:23:47 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2014-09-30 20:45:23 UTC
perl-Digest-PBKDF2-0.010-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-Digest-PBKDF2-0.010-1.el7

Comment 9 Fedora Update System 2014-09-30 20:45:54 UTC
perl-Digest-PBKDF2-0.010-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Digest-PBKDF2-0.010-1.el6

Comment 10 Fedora Update System 2014-09-30 20:46:32 UTC
perl-Digest-PBKDF2-0.010-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Digest-PBKDF2-0.010-1.fc21

Comment 11 Fedora Update System 2014-09-30 20:46:56 UTC
perl-Digest-PBKDF2-0.010-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Digest-PBKDF2-0.010-1.fc20

Comment 12 Fedora Update System 2014-10-01 17:18:28 UTC
perl-Digest-PBKDF2-0.010-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 13 Fedora Update System 2014-10-08 19:13:18 UTC
perl-Digest-PBKDF2-0.010-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 14 Fedora Update System 2014-10-11 06:53:01 UTC
perl-Digest-PBKDF2-0.010-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 15 Fedora Update System 2014-10-17 17:34:31 UTC
perl-Digest-PBKDF2-0.010-1.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 16 Fedora Update System 2014-10-17 17:37:51 UTC
perl-Digest-PBKDF2-0.010-1.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.