Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1148066

Summary: [BLOCKED] No tabbing in Custom Preview Dialogue
Product: [oVirt] ovirt-engine Reporter: Kevin Alon Goldblatt <kgoldbla>
Component: Frontend.WebAdminAssignee: Daniel Erez <derez>
Status: CLOSED DEFERRED QA Contact: Raz Tamir <ratamir>
Severity: low Docs Contact:
Priority: low    
Version: ---CC: amureini, bugs, ehildesh, kgoldbla, lsurette, rbalakri, Rhev-m-bugs, srevivo, tnisan, ykaul, ylavi
Target Milestone: ---Keywords: UserExperience
Target Release: ---Flags: rule-engine: ovirt-4.2+
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-19 12:29:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1064240, 1149778    
Bug Blocks:    
Attachments:
Description Flags
screenshots, server and vdsm logs none

Description Kevin Alon Goldblatt 2014-09-30 15:49:30 UTC
Description of problem:
No tabbing enabled in the Custom Preview Dialogue

Version-Release number of selected component (if applicable):
rhevm-3.5.0-0.13.beta.el6ev.noarch
vdsm-4.16.5-2.el6ev.x86_64

How reproducible:
Always

Steps to Reproduce:
1.Create a VM with a few disks
2.Create 3 snapshots
3.Select to Custom Preview one the first snapshot created >>> No tabbing is enabled in the Custom Preview Dialogue

Actual results:
No Tabbing is enabled in the Custom Preview Dialogue

Expected results:
Tabbing should be enabled in the Custom Preview Dialogue

Additional info:
See attached screenshot

Comment 1 Kevin Alon Goldblatt 2014-09-30 16:01:09 UTC
Created attachment 942787 [details]
screenshots, server and vdsm logs

Added logs again as they were not saved before

Comment 2 Daniel Erez 2014-10-01 20:08:56 UTC
Hi Kevin,

We usually use tabbing for easy navigation between editable widget (e.g. text-boxes/select-boxes/etc). The custom preview dialog is composed from multiple (potentially numerous) check-boxes, so I'm not sure tabbing would be convenient in this case. Or have you meant tabbing between other widgets?

Comment 3 Kevin Alon Goldblatt 2014-10-06 12:37:58 UTC
Tabbing should be enabled here too. The first snapshot and its disks should be selected by default. Tabbing to allow changes to the selected disks and to navigate to the next snapshot. Then to tab on to the Cancel and OK buttons

Comment 4 Daniel Erez 2014-10-06 12:56:51 UTC
(In reply to Kevin Alon Goldblatt from comment #3)
> Tabbing should be enabled here too. The first snapshot and its disks should
> be selected by default. Tabbing to allow changes to the selected disks and
> to navigate to the next snapshot. Then to tab on to the Cancel and OK buttons

afaik, there's no other occurrence/support of such behavior in the UI regarding tables. As mentioned in comment #2, I'm not sure it would be convenient for check-boxes/radio-boxes in this specific dialog.

@Einav/Eldan - what do you think? how should we handle tabbing here?

Comment 5 Einav Cohen 2014-10-06 14:48:05 UTC
I will let Eldan chime in here as well, but I tend to agree with Kevin - I think that allowing tabbing between the cells in the row, row by row, may be very convenient (very much like e.g. navigating between table cells within a Word document or similar). 

before moving forward with this particular request, I believe that we need the dialog tab index infrastructure in place (see bug 1064240). 
there is a chance that we will need further infrastructure in order to support tables, especially ones with dynamic number of rows (e.g. in this case, number of rows depends on number of disks within the VM). in this case, another BZ may be reported. 

thanks.

Comment 6 Eldan Hildesheim 2015-02-25 09:55:33 UTC
Generally speaking - 'Tab' should move the focus from left to right, top to bottom.
Do we have this infrastructure? - if so, all the ui should work accordingly.
In this particular ui, I think you wouldn't work with keyboard/Tabs, nevertheless, Tab navigation is a good practice.

Comment 7 Allon Mureinik 2015-06-18 13:05:23 UTC
This depends on an RFE that was pushed out to 4.0 - pushing this one too.

Comment 8 Red Hat Bugzilla Rules Engine 2015-11-30 20:51:51 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 11 Allon Mureinik 2017-07-19 12:29:46 UTC
According to the correspondence on bug 1149778, we won't have the required infra in the foreseeable future.

Closing this bug.
We should revisit if the decision there changes.