Bug 1148580 - Review Request: perl-Test-XML - Compare XML in perl tests
Summary: Review Request: perl-Test-XML - Compare XML in perl tests
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1148577
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-01 19:03 UTC by Paul Howarth
Modified: 2014-10-28 11:05 UTC (History)
2 users (show)

Fixed In Version: perl-Test-XML-0.08-2.fc21
Clone Of:
Environment:
Last Closed: 2014-10-14 04:38:58 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2014-10-01 19:03:58 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-XML/branches/fedora/perl-Test-XML.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-XML/perl-Test-XML-0.08-1.fc22.src.rpm

Description:
This module contains generic XML testing tools. Functions include:

is_xml(GOT, EXPECTED [, TESTNAME ])

  This function compares GOT and EXPECTED, both of which are strings of XML.
  The comparison works semantically and will ignore differences in syntax
  that are meaningless in xml, such as different quote characters for
  attributes, order of attributes or empty tag styles. It returns true or
  false, depending upon test success.

isnt_xml(GOT, MUST_NOT_BE [, TESTNAME ])

  This function is similiar to is_xml(), except that it will fail if GOT and
  MUST_NOT_BE are identical.

is_well_formed_xml(XML [, TESTNAME ])

  This function determines whether or not a given XML string is parseable as
  XML.

is_good_xml(XML [, TESTNAME ])

    This is an alias for is_well_formed_xml().

Fedora Account System Username: pghmcfc

This package contains old spec file elements for compatibility with EPEL-5.

Comment 1 Petr Šabata 2014-10-07 13:40:16 UTC
The %description is maybe a bit too detailed for my taste but that's subjective...

Missed one buildtime dependency, Test::Builder::Tester (t/maint.t:10).

Comment 2 Paul Howarth 2014-10-07 13:56:30 UTC
(In reply to Petr Šabata from comment #1)
> The %description is maybe a bit too detailed for my taste but that's
> subjective...

It's a bit too detailed for me too really, but I preferred that to the one-liner it would have been otherwise.

> Missed one buildtime dependency, Test::Builder::Tester (t/maint.t:10).

Ah, tangerine let me down there ;-)

Fixed in -2.

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-XML/branches/fedora/perl-Test-XML.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-XML/perl-Test-XML-0.08-2.fc22.src.rpm

Comment 3 Petr Šabata 2014-10-07 14:06:08 UTC
(In reply to Paul Howarth from comment #2)
> > Missed one buildtime dependency, Test::Builder::Tester (t/maint.t:10).
> 
> Ah, tangerine let me down there ;-)

Yeah, I know... this is (nearly?) impossible to detect :/

> Fixed in -2.

Ack.  Approving.

Comment 4 Paul Howarth 2014-10-07 14:31:46 UTC
New Package SCM Request
=======================
Package Name: perl-Test-XML
Short Description: Compare XML in perl tests
Upstream URL: http://search.cpan.org/dist/Test-XML/
Owners: pghmcfc
Branches: f19 f20 f21 el5 el6 epel7
InitialCC: perl-sig

Thanks for the review Petr.

Comment 5 Gwyn Ciesla 2014-10-07 16:59:01 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-10-07 22:45:51 UTC
perl-Test-XML-0.08-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Test-XML-0.08-2.el6

Comment 7 Fedora Update System 2014-10-07 22:45:57 UTC
perl-Test-XML-0.08-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-Test-XML-0.08-2.el7

Comment 8 Fedora Update System 2014-10-07 22:46:05 UTC
perl-Test-XML-0.08-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Test-XML-0.08-2.fc20

Comment 9 Fedora Update System 2014-10-07 22:46:11 UTC
perl-Test-XML-0.08-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Test-XML-0.08-2.el5

Comment 10 Fedora Update System 2014-10-07 22:46:18 UTC
perl-Test-XML-0.08-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Test-XML-0.08-2.fc21

Comment 11 Fedora Update System 2014-10-07 22:46:24 UTC
perl-Test-XML-0.08-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Test-XML-0.08-2.fc19

Comment 12 Fedora Update System 2014-10-08 18:52:09 UTC
perl-Test-XML-0.08-2.fc21 has been pushed to the Fedora 21 testing repository.

Comment 13 Fedora Update System 2014-10-14 04:38:58 UTC
perl-Test-XML-0.08-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 14 Fedora Update System 2014-10-17 08:38:24 UTC
perl-Test-XML-0.08-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 15 Fedora Update System 2014-10-17 08:39:02 UTC
perl-Test-XML-0.08-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 16 Fedora Update System 2014-10-28 10:57:55 UTC
perl-Test-XML-0.08-2.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 17 Fedora Update System 2014-10-28 10:59:41 UTC
perl-Test-XML-0.08-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 18 Fedora Update System 2014-10-28 11:05:46 UTC
perl-Test-XML-0.08-2.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.