Bug 1148704 - Review Request: golang-googlecode-go-crypto - Supplementary Go cryptography libraries
Summary: Review Request: golang-googlecode-go-crypto - Supplementary Go cryptography l...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lokesh Mandvekar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-02 07:40 UTC by Jan Chaloupka
Modified: 2014-12-20 00:17 UTC (History)
3 users (show)

Fixed In Version: golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-13 09:56:02 UTC
Type: ---
Embargoed:
lsm5: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jan Chaloupka 2014-10-02 07:40:37 UTC
Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-go-crypto/golang-googlecode-go-crypto.spec

SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-go-crypto/golang-googlecode-go-crypto-0-0.1.hg31393df5baea.fc21.src.rpm

Description: Supplementary Go cryptography libraries

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7745299

$ rpmlint golang-googlecode-go-crypto.spec /root/rpmbuild/SRPMS/golang-googlecode-go-crypto-0-0.1.hg31393df5baea.fc21.src.rpm /root/rpmbuild/RPMS/noarch/golang-googlecode-go-crypto-devel-0-0.1.hg31393df5baea.fc21.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jan Chaloupka 2014-10-02 07:42:15 UTC
Here, we should take a look if this package can go to Fedora at all.

For example: bz1038683

Comment 2 Lokesh Mandvekar 2014-10-07 00:08:06 UTC
Matt, spot:

do you know if this package can get into Fedora?

Upstream URL: https://code.google.com/p/go/source/browse/?repo=crypto

Comment 3 Tom "spot" Callaway 2014-10-07 15:12:45 UTC
I'm going to have to audit all of this. It's on my todo list, but I'm backlogged.

Comment 4 Lokesh Mandvekar 2014-10-07 19:12:31 UTC
Great, thanks spot. Let me know if I can help in any way with this.

Comment 5 Tom "spot" Callaway 2014-11-05 19:27:08 UTC
After review, there are no legal issues preventing this package as it exists today from going into Fedora. Lifting FE-Legal.

Comment 6 Lokesh Mandvekar 2014-11-06 07:02:34 UTC
Awesome! Thanks spot!

Comment 7 Jan Chaloupka 2014-11-06 09:11:00 UTC
Nice. Thank you.

Comment 8 Lokesh Mandvekar 2014-12-03 17:12:08 UTC
- No legal issues as noted above.
- spec file conforms to current golang packaging drafts
- only sources installed as of now
- license is correct


Package approved. Feel free to shorten the %files list like you mentioned earlier for some other package.

Comment 9 Jan Chaloupka 2014-12-04 10:14:13 UTC
New Package SCM Request
=======================
Package Name: golang-googlecode-go-crypto
Short Description: Supplementary Go cryptography libraries
Upstream URL: https://code.google.com/p/go.crypto/
Owners: jchaloup lsm5 vbatts
Branches: f21 f20 f19 el6
InitialCC: golang-sig

Comment 10 Gwyn Ciesla 2014-12-04 12:59:55 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2014-12-04 15:52:08 UTC
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc20

Comment 12 Fedora Update System 2014-12-04 15:52:29 UTC
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc21

Comment 13 Fedora Update System 2014-12-04 15:52:51 UTC
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.el6

Comment 14 Fedora Update System 2014-12-05 00:48:29 UTC
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc21 has been pushed to the Fedora 21 testing repository.

Comment 15 Fedora Update System 2014-12-13 09:56:02 UTC
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc21 has been pushed to the Fedora 21 stable repository.

Comment 16 Fedora Update System 2014-12-15 04:30:04 UTC
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc20 has been pushed to the Fedora 20 stable repository.

Comment 17 Fedora Update System 2014-12-20 00:17:46 UTC
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.