Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-jmhodges-levigo/golang-github-jmhodges-levigo.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-jmhodges-levigo/golang-github-jmhodges-levigo-0-0.1.git253793d.fc21.src.rpm Description: Go wrapper for LevelDB Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7745299 $ rpmlint golang-github-jmhodges-levigo.spec /root/rpmbuild/SRPMS/golang-github-jmhodges-levigo-0-0.1.git253793d.fc21.src.rpm /root/rpmbuild/RPMS/noarch/golang-github-jmhodges-levigo-devel-0-0.1.git253793d.fc21.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Changes: Requires: leveldb >= 1.7 The first review: bz1123575 by Eduardo Mayorga leveldb-devel contain all needed files for leveldb. Not sure, if leveldb itself provides this. But the version >= 1.7 is missing in the spec file.
This build is correct Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7745291
*** Bug 1123575 has been marked as a duplicate of this bug. ***
Provides list from mitchellh-goamz? :) Maybe we should skip examples/ dir if we're not providing it? Also, in -devel description, please add the "This package contains library source intended for building other packages which use %{project}/%{repo}." ..or something similar. This applies to all such packages (I might have missed adding this myself to some packages)
examples does not contain any library code, just an example, so it is not going to Provides. However the example is good for developers so we should package it. > Provides list from mitchellh-goamz? :) Don't get it :)
(In reply to Jan Chaloupka from comment #5) > examples does not contain any library code, just an example, so it is not > going to Provides. However the example is good for developers so we should > package it. Sounds good. > > > Provides list from mitchellh-goamz? :) > > Don't get it :) The "Provides: golang(%{import_path}/$dir)" look the same as the ones in golang-github-mitchellh-goamz. I don't see %{import_path}/$dir anywhere in this repo. Something I missed?
You are right, forget to delete them after copy from goamz :-[. Spec and srpm updated. Plus adding >= 1.7 into BuildRequires and Requires for leveldb-devel. URLs again the same.
looks good now. Package approved. Specfile conforms to current Go packaging draft.
New Package SCM Request ======================= Package Name: golang-github-jmhodges-levigo Short Description: Go wrapper for LevelDB Upstream URL: https://github.com/jmhodges/levigo Owners: jchaloup lsm5 vbatts mayorga Branches: f21 f20 f19 el6 InitialCC: golang-sig
Git done (by process-git-requests).
golang-github-jmhodges-levigo-0-0.1.git253793d.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-jmhodges-levigo-0-0.1.git253793d.el6
golang-github-jmhodges-levigo-0-0.1.git253793d.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-jmhodges-levigo-0-0.1.git253793d.fc21
golang-github-jmhodges-levigo-0-0.1.git253793d.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-jmhodges-levigo-0-0.1.git253793d.fc20
golang-github-jmhodges-levigo-0-0.1.git253793d.el6 has been pushed to the Fedora EPEL 6 testing repository.
golang-github-jmhodges-levigo-0-0.2.git253793d.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-jmhodges-levigo-0-0.2.git253793d.el6
golang-github-jmhodges-levigo-0-0.1.git253793d.fc20 has been pushed to the Fedora 20 stable repository.
golang-github-jmhodges-levigo-0-0.2.git253793d.el6 has been pushed to the Fedora EPEL 6 stable repository.
golang-github-jmhodges-levigo-0-0.1.git253793d.fc21 has been pushed to the Fedora 21 stable repository.