Bug 1149663
| Summary: | Reduce the list of "marked" fields on instance types | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Bill Sanford <bsanford> | ||||
| Component: | ovirt-engine | Assignee: | Tomas Jelinek <tjelinek> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | meital avital <mavital> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 3.5.0 | CC: | aberezin, bazulay, benl, dougsland, ecohen, gklein, iheim, like.ma, lpeer, lsurette, mavital, michal.skrivanek, nsimsolo, ofrenkel, pvine, rbalakri, Rhev-m-bugs, tpelka, vipatel, yeylon | ||||
| Target Milestone: | --- | Keywords: | Triaged | ||||
| Target Release: | 3.5.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | virt | ||||||
| Fixed In Version: | org.ovirt.engine-root-3.5.0-23 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-02-17 08:28:12 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Bill Sanford
2014-10-06 12:25:33 UTC
If I understand you correctly, than this is how it is supposed to behave. 1: If you have an instance type selected, than if you select any field which is "marked" (please see the wiki http://www.ovirt.org/Features/Instance_Types - the "marked" column in the table) than the instance type has to change to "custom" - e.g. the VM is not anymore based on the instance type. 2: If you select anything in the dialog and change the instance type, your original selection will be replaced by the instance type's I am looking at the http://wiki.ovirt.org/Features/Instance_Types#Design and "usb_policy" is "Marked" in the "VM" section as "Y." This spreadsheet tells me that "Marked: if Y, it means this field is crucial to the instance type definition and if the user changes it, the instance type will change to "custom" (e.g. the VM is not based on that instance type anymore)." I can change the USB Policy (See attachment) where I chose "Native" USB, in the Console Tab, when it was defaulted to disabled and with the Instance type changed to "Small." I see how it works given the nature of the "Profiles" of the new Instance type. I see that the Soundcard and VirtIO are marked Y in the VM section. I expect that the USB Policy should change the Instance Type back to Custom based on the spreadsheet. Created attachment 945429 [details]
Snapshot of changed USB policy and same Instance type
Right, there is a mismatch between the wiki and the behavior. Now the question is if the correct is the wiki or the code. Really not sure about that. @Michal: what do you think? Should the SPICE USB Policy (native/legacy/disabled) be "marked" so by changing it it detouches the VM from the instance type? Because if you can change the protocol (SPICE/VNC) and also the num of monitors, I'd say also the USB Support should be possible to change. well, yeah, we have to review it again I think. The minor hw changes should not affect the instance type itself (including soundcard, USB, number of monitors, virtio-console device, I'd say even ballon(device)) That is why I originally filed the bug. My original thought was that anything that was plug and play on bare metal, should not affect the core of the bare metal, itself and the VM should act the same way. Thanks for reviewing this. so the new list of "marked" fields will be much smaller: - memory size - num of sockets/cores per socket - HA - migration model/downtime - priority - balloon/min allocated memory Changed the title according to the discussion in this BZ *** Bug 1164426 has been marked as a duplicate of this bug. *** one last REST API patch missing backport.... Verified, changes of "Soundcard enabled" and "VirtIO Console Device Enabled" does not change instance type back to custom. engine build: rhevm-3.5.0-0.27.el6ev.noarch RHEV-M 3.5.0 has been released |