Spec URL: https://fab.fedorapeople.org/packages/SRPMS/binpac.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/binpac-0.42-1.fc20.src.rpm Project URL: https://www.bro.org/sphinx/components/binpac/README.html Description: BinPAC is a high level language for describing protocol parsers and generates C++ code. It is currently maintained and distributed with the Bro Network Security Monitor distribution, however, the generated parsers may be used with other programs besides Bro. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7778551 rpmlint output: [fab@localhost SRPMS]$ rpmlint binpac-0.42-1.fc20.src.rpm binpac.src: W: spelling-error Summary(en_US) parsers -> parser, parses, parers binpac.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [fab@localhost x86_64]$ rpmlint binpac* binpac.x86_64: W: spelling-error Summary(en_US) parsers -> parser, parses, parers binpac.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers binpac.x86_64: W: no-manual-page-for-binary binpac 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: fab
This package has several issues: - Building is non-verbose. AFAIS, appending VERBOSE=1 to the make calls seems triggers verbose building. - The *-devel package doesn't contain a library. Unless this is a c++-template library (which I doubt it is), this doesn't make sense. Actually I think this package is only building a static library, which you later are removing from inside of the spec. - The *-devel package ships /usr/include/binpac.h.in I doubt this file is supposed to be shipped.
some other improvements can be done 1) I see duplication of documentation files. Those should be present only in base package as -devel will also pull base package. 2) patch file is included with no comments why it is needed and/or no upstream submitted reference to this patch.
Thanks for the comments. * Wed Oct 08 2014 Fabian Affolter <mail> - 0.42-2 - Remove doc file from -devel package and unused file - Don't remove the static lib - Add a comment for the patch (rhbz#1149861) Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/binpac.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/binpac-0.42-2.fc20.src.rpm