Bug 1149998 (myrepos) - Rename Request: myrepos - A multiple SCM repository management tool
Summary: Rename Request: myrepos - A multiple SCM repository management tool
Keywords:
Status: CLOSED ERRATA
Alias: myrepos
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-07 07:55 UTC by Fabian Affolter
Modified: 2014-12-06 10:27 UTC (History)
3 users (show)

Fixed In Version: myrepos-1.20140831.1-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-22 12:38:21 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Fabian Affolter 2014-10-07 07:55:38 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/myrepos.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/myrepos-1.20140831.1-1.fc20.src.rpm

Project URL: https://github.com/joeyh/myrepos

Description:
The mr command can checkout, update, or perform other actions on
a set of repositories as if they were one combined respository. It
supports any combination of subversion, git, cvs, mecurial, bzr and
darcs repositories, and support for other revision control systems
can easily be added.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7785293

rpmlint output:
[fab@localhost SRPMS]$ rpmlint myrepos-1.20140831.1-1.fc20.src.rpm 
myrepos.src: W: spelling-error %description -l en_US mr -> rm, Mr, me
myrepos.src: W: spelling-error %description -l en_US cvs -> cs, vs, cos
myrepos.src: W: spelling-error %description -l en_US mecurial -> mercurial, memorial
myrepos.src: W: spelling-error %description -l en_US bzr -> bar, brr, bur
myrepos.src: W: spelling-error %description -l en_US darcs -> cards, arcs, dares
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

[fab@localhost noarch]$ rpmlint myrepos-1.20140831.1-1.fc20.noarch.rpm 
myrepos.noarch: W: spelling-error %description -l en_US cvs -> cs, vs, cos
myrepos.noarch: W: spelling-error %description -l en_US mecurial -> mercurial, memorial
myrepos.noarch: W: spelling-error %description -l en_US bzr -> bar, brr, bur
myrepos.noarch: W: spelling-error %description -l en_US darcs -> cards, arcs, dares
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Fedora Account System Username: fab

This is a re-review of mr (https://bugzilla.redhat.com/show_bug.cgi?id=478345). Upstream renamed the project and to reflect that I want to rename the package. The executable is still named mr.

Comment 1 Parag AN(पराग) 2014-10-08 08:15:32 UTC
Review:

+ Package builds fine in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
myrepos.noarch: W: spelling-error %description -l en_US cvs -> cs, vs, cos
myrepos.noarch: W: spelling-error %description -l en_US mecurial -> mercurial, memorial
myrepos.noarch: W: spelling-error %description -l en_US bzr -> bar, brr, bur
myrepos.noarch: W: spelling-error %description -l en_US darcs -> cards, arcs, dares
myrepos.src: W: spelling-error %description -l en_US mr -> rm, Mr, me
myrepos.src: W: spelling-error %description -l en_US cvs -> cs, vs, cos
myrepos.src: W: spelling-error %description -l en_US mecurial -> mercurial, memorial
myrepos.src: W: spelling-error %description -l en_US bzr -> bar, brr, bur
myrepos.src: W: spelling-error %description -l en_US darcs -> cards, arcs, dares
2 packages and 0 specfiles checked; 0 errors, 9 warnings.

+ Source verified with upstream as (sha256sum)
upstream tarball: efb864848d3c557d913138a52e3d5a4736edcccd9f9b46bb65931060cf8548f0
srpm tarball : efb864848d3c557d913138a52e3d5a4736edcccd9f9b46bb65931060cf8548f0

+ License "GPLv2+" is valid and included in GPL file.

+ rest looks as per packaging guidelines.

+ Also, package got renamed successfully.

suggestions:
1) I see vis command also working fine but will add some more dependencies with it to this package. Maybe if you want you can package it.

2) This package should add following. I don't think it can be assumed to be already installed on the system.

Requires: git

APPROVED.

Comment 2 Parag AN(पराग) 2014-10-08 09:17:29 UTC
don't forget to follow mr package retirement process once you import this package into git :)

Comment 3 Fabian Affolter 2014-10-08 09:29:25 UTC
(In reply to Parag AN(पराग) from comment #1)
> suggestions:
> 1) I see vis command also working fine but will add some more dependencies
> with it to this package. Maybe if you want you can package it.

Yes, veracity is supported by myrepos but not in Fedora.

> 2) This package should add following. I don't think it can be assumed to be
> already installed on the system.

No, we can't. Instead of pulling in all supported SCM tool, I added a fedora specific README file that describes that only git is installed and the other tools needs to installed manually.

Thanks for your input.

Comment 4 Fabian Affolter 2014-10-08 09:31:00 UTC
New Package SCM Request
=======================
Package Name: myrepos
Short Description: A multiple SCM repository management tool
Upstream URL: https://github.com/joeyh/myrepos
Owners: fab 
Branches: f20 f21 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2014-10-08 10:20:32 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-11-07 09:33:57 UTC
myrepos-1.20140831.1-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/myrepos-1.20140831.1-2.fc21

Comment 7 Fedora Update System 2014-11-07 10:30:45 UTC
myrepos-1.20140831.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/myrepos-1.20140831.1-2.fc20

Comment 8 Fedora Update System 2014-11-09 15:45:44 UTC
Package myrepos-1.20140831.1-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing myrepos-1.20140831.1-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-14489/myrepos-1.20140831.1-2.fc20
then log in and leave karma (feedback).

Comment 9 Petr Pisar 2014-11-12 11:27:26 UTC
Request to block "mr" package in koji <https://fedorahosted.org/rel-eng/ticket/6045>.

Comment 10 Fedora Update System 2014-11-22 12:38:21 UTC
myrepos-1.20140831.1-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2014-12-06 10:27:55 UTC
myrepos-1.20140831.1-2.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.