Description of problem: /usr/bin/startxfce4 is subject to bashisms, notably "test ==". It doesn't work when using a non-bash as /bin/sh. Version-Release number of selected component (if applicable): All versions on fc19 through rawhide I am attaching a patch.
Created attachment 944670 [details] Patch against xfce4-session-4.10.1 to remove bashisms
Would you be willing to file this upstream to see if they will take it? Or would you prefer I do so? It seems pretty minor, so I would be fine patching it in, but it would be nice if upstream merges it so I don't have to patch it forever.
Kevin, this is already reported upstream and fixed. https://bugzilla.xfce.org/show_bug.cgi?id=10828 I think this should be in next xfce4-session release (I do not remember if I already had this in 4.11). We should probably push this to F19 and F20. If you are fine, I will add the patch and push this tomorrow.
(In reply to Mukundan Ragavan from comment #3) > Kevin, this is already reported upstream and fixed. > > https://bugzilla.xfce.org/show_bug.cgi?id=10828 Interesting ;) I checked Debian's and Ubuntu's packages and both still carry this bug.
Excellent catch. ;) Sure, please do push out an update for it tomorrow. :) Thanks!
Awesome. Will do as soon as I get back home!
xfce4-session-4.10.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/xfce4-session-4.10.1-2.fc19
xfce4-session-4.10.1-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/xfce4-session-4.10.1-4.fc20
xfce4-session-4.10.1-7.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/xfce4-session-4.10.1-7.fc21
xfce4-session-4.10.1-4.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
xfce4-session-4.10.1-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
xfce4-session-4.10.1-7.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.