RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1150701 - virt-v2v does not fstrim data disks and non-mounted filesystems
Summary: virt-v2v does not fstrim data disks and non-mounted filesystems
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libguestfs
Version: 7.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Richard W.M. Jones
QA Contact: Virtualization Bugs
URL:
Whiteboard: V2V
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-08 18:20 UTC by Richard W.M. Jones
Modified: 2015-03-05 13:45 UTC (History)
8 users (show)

Fixed In Version: libguestfs-1.27.61-1.1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 13:45:53 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
libguestfs-1.27.60. debug log (202.78 KB, text/plain)
2014-10-22 11:32 UTC, zhoujunqin 		no flags Details
libguestfs-1.28.1-1.2 debug log (211.53 KB, text/plain)
2014-10-22 11:33 UTC, zhoujunqin 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:0303 0 normal SHIPPED_LIVE libguestfs bug fix and enhancement update 2015-03-05 17:34:44 UTC

Description Richard W.M. Jones 2014-10-08 18:20:28 UTC 
Description of problem:

If you have, say, a Windows guest which has a data disk (D:)
then virt-v2v won't consider it as a candidate for fstrim, and
thus copying the data disk will be much slower than it ought to be.

Virt-v2v should consider all mountable filesystems as candidates
for fstrim.

Version-Release number of selected component (if applicable):

libguestfs 1.27.60

How reproducible:

100%

Steps to Reproduce:
1. Create a Windows guest with a data disk.
2. Use virt-v2v to convert it.
3. Notice (in debug output) that data disk is not 'fstrim'-ed.

Additional info:

Reported by James Mighion
Comment 2 Richard W.M. Jones 2014-10-08 20:29:38 UTC 
Fixed in:
https://github.com/libguestfs/libguestfs/commit/69fe3945b7641811c99c3c03e05e73d2347e8a42
https://github.com/libguestfs/libguestfs/commit/e66138fbe71c24df3a282e1b23d8ed5c80f7b8c7

virt-v2v >= 1.27.61.
Comment 4 zhoujunqin 2014-10-22 11:31:23 UTC 
Try to verify with new build:
virt-v2v-1.28.1-1.2.el7.x86_64
libguestfs-1.28.1-1.2.el7.x86_64
libguestfs-winsupport-7.1-4.el7.x86_64
steps:
1. Prepare a win7 guest on xen server with two disk(C & D)
2. User virt-v2v convert guest to local
# virt-v2v -ic xen+ssh://10.66.106.64 -os default xen-hvm-win7-x86_64 -of raw
[   0.0] Opening the source -i libvirt -ic xen+ssh://10.66.106.64 xen-hvm-win7-x86_64
[   1.0] Creating an overlay to protect the source from being modified
[   1.0] Opening the overlay
[ 106.0] Initializing the target -o libvirt -os default
[ 106.0] Inspecting the overlay
[ 112.0] Checking for sufficient free disk space in the guest
[ 112.0] Estimating space required on target for each disk
[ 112.0] Converting Windows 7 Ultimate to run on KVM
virt-v2v: warning: there are no virtio drivers available for this version 
of Windows (6.1 x86_64 Client).  virt-v2v looks for drivers in 
/usr/share/virtio-win

The guest will be configured to use slower emulated devices.
virt-v2v: This guest does not have virtio drivers installed.
[ 114.0] Mapping filesystem data to avoid copying unused and blank areas
[ 124.0] Closing the overlay
[ 124.0] Copying disk 1/2 to /var/lib/libvirt/images/xen-hvm-win7-x86_64-sda (raw)
    (100.00/100%)
[ 427.0] Copying disk 2/2 to /var/lib/libvirt/images/xen-hvm-win7-x86_64-sdb (raw)
    (100.00/100%)
[ 429.0] Creating output metadata
Pool default refreshed

Domain xen-hvm-win7-x86_64 defined from /tmp/v2vlibvirtbf4507.xml

[ 433.0] Finishing off

3. Check the debug log and found:
...
libguestfs: trace: umount_all = 0
libguestfs: trace: mount "/dev/sda2" "/"
guestfsd: main_loop: proc 47 (umount_all) took 0.00 seconds^M
guestfsd: main_loop: new request, len 0x40^M
mount -o  /dev/sda2 /sysroot/^M
libguestfs: trace: mount = 0
libguestfs: trace: fstrim "/"
guestfsd: main_loop: proc 1 (mount) took 0.03 seconds^M
guestfsd: main_loop: new request, len 0x48^M
fsync /dev/sda^M
fsync /dev/sdb^M
fstrim -v /sysroot/^M
/sysroot/: 16 EiB (18446744073709551615 bytes) trimmed^M
^M
guestfsd: main_loop: proc 334 (fstrim) took 1.74 seconds^M

but in version: libguestfs 1.27.60
libguestfs: trace: mountpoints
guestfsd: main_loop: new request, len 0x28^M
guestfsd: main_loop: proc 147 (mlibguestfs: trace: mountpoints = ["/dev/sda2", "/"]
libguestfs: trace: fstrim "/"
ountpoints) took 0.00 seconds^M
guestfsd: main_loop: new request, len 0x48^M
fsync /dev/sda^M
fsync /dev/sdb^M
fstrim -v /sysroot/^M
/sysroot/: 16 EiB (18446744073709551615 bytes) trimmed^M
^M
guestfsd: main_loop: proc 334 (fstrim) took 2.09 seconds^M
libguestfs: trace: fstrim = 0

I'm not sure whether it's enough to verify this bug, so rjones please help me confirmed it, thanks.
Comment 5 zhoujunqin 2014-10-22 11:32:38 UTC 
Created attachment 949350 [details]
libguestfs-1.27.60. debug log
Comment 6 zhoujunqin 2014-10-22 11:33:15 UTC 
Created attachment 949352 [details]
libguestfs-1.28.1-1.2 debug log
Comment 7 Richard W.M. Jones 2014-10-24 14:03:45 UTC 
It is a bit complicated.  In the 1.27.60 log (comment 5)
you can see:

[  11.0] Mapping filesystem data to avoid copying unused and blank areas
libguestfs: trace: mountpoints
[...]
libguestfs: trace: mountpoints = ["/dev/sda2", "/"]
libguestfs: trace: fstrim "/"
[...]
libguestfs: trace: fstrim = 0

==> Only /dev/sda2 (C: drive) was trimmed.

In the 1.28.1 log (comment 6):

libguestfs: trace: mount "/dev/sdb1" "/"
[...]
libguestfs: trace: mount = 0
libguestfs: trace: fstrim "/"
[...]
libguestfs: trace: fstrim = 0
[...]
libguestfs: trace: mount "/dev/sda2" "/"
[...]
libguestfs: trace: mount = 0
libguestfs: trace: fstrim "/"
[...]
libguestfs: trace: fstrim = 0

==> /dev/sdb1 (D:) and /dev/sda2 (C:) were both trimmed (in reverse
order, but that doesn't matter).

This bug can be set to VERIFIED based on the information provided.
Comment 8 zhoujunqin 2014-10-27 01:28:50 UTC 
(In reply to Richard W.M. Jones from comment #7)
> It is a bit complicated.  In the 1.27.60 log (comment 5)
> you can see:
> 
> [  11.0] Mapping filesystem data to avoid copying unused and blank areas
> libguestfs: trace: mountpoints
> [...]
> libguestfs: trace: mountpoints = ["/dev/sda2", "/"]
> libguestfs: trace: fstrim "/"
> [...]
> libguestfs: trace: fstrim = 0
> 
> ==> Only /dev/sda2 (C: drive) was trimmed.
> 
> In the 1.28.1 log (comment 6):
> 
> libguestfs: trace: mount "/dev/sdb1" "/"
> [...]
> libguestfs: trace: mount = 0
> libguestfs: trace: fstrim "/"
> [...]
> libguestfs: trace: fstrim = 0
> [...]
> libguestfs: trace: mount "/dev/sda2" "/"
> [...]
> libguestfs: trace: mount = 0
> libguestfs: trace: fstrim "/"
> [...]
> libguestfs: trace: fstrim = 0
> 
> ==> /dev/sdb1 (D:) and /dev/sda2 (C:) were both trimmed (in reverse
> order, but that doesn't matter).
> 
> This bug can be set to VERIFIED based on the information provided.

rjones, thanks for your kind help, and according to above comments, move this bug from ON_QA to VERIFIED.
Comment 10 errata-xmlrpc 2015-03-05 13:45:53 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0303.html
Note You need to log in before you can comment on or make changes to this bug.