Bug 1151652 - Merge emacs-el into emacs-common
Summary: Merge emacs-el into emacs-common
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: emacs
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Petr Hracek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-10 23:43 UTC by Glenn Morris
Modified: 2014-12-06 10:01 UTC (History)
4 users (show)

Fixed In Version: emacs-24.4-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-24 09:53:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to merge the packages (2.19 KB, patch)
2014-10-21 05:10 UTC, Sergio Durigan Junior
no flags Details | Diff

Description Glenn Morris 2014-10-10 23:43:23 UTC
Hi,

Please consider merging the emacs-el rpm into emacs-common.
As far as I know, the only reason emacs-el exists as a separate rpm
is for historical reasons, to save space. This is not relevant in this day-and-age: emacs-el is only 14MB (emacs-common is 70MB).

While you can, strictly speaking, run Emacs without the .el files, this is not a mode of installation that upstream Emacs offers or expects.
The .el files are an important form of documentation, if nothing else.

Thanks for your consideration! :)

Comment 1 Sergio Durigan Junior 2014-10-21 05:10:15 UTC
Created attachment 948795 [details]
Patch to merge the packages

I agree with Glenn's rationale.  Here is a patch to merge both packages.

Comment 2 Jan Chaloupka 2014-10-21 08:47:24 UTC
Hi Glen, Sergio,

have you discussed this with upstream?

Comment 3 Jan Chaloupka 2014-10-21 08:48:14 UTC
Sorry, this is Fedora issue :)

Comment 4 Petr Hracek 2014-10-23 07:28:05 UTC
(In reply to Sergio Durigan Junior from comment #1)
> Created attachment 948795 [details]
> Patch to merge the packages
> 
> I agree with Glenn's rationale.  Here is a patch to merge both packages.

Thanks for the patch. What I missed in your patch is directive like Obsoletes emacs-el which doesn't exist anymore after this update.

I am gonna to correct it.

Comment 5 Sergio Durigan Junior 2014-10-23 13:52:54 UTC
You are right, Peter.  I thought about it yesterday night, but forgot to resubmit a new version.  Anyway, thanks for that.

Comment 6 Petr Hracek 2014-10-23 14:38:33 UTC
What about to have emacs-el package which will be required by emacs-common?
In the rawhide, can be specified SPEC tag like Recommends which means
that you can uninstall package without troubles if you wants.

From my point of view I would like to have those files separate in packages.

Patch:
 Requires(posttrans): %{_sbindir}/alternatives
 Requires(post): /sbin/install-info
 Requires: %{name}-filesystem
+Requires: %{name}-el

 %description common
 Emacs is a powerful, customizable, self-documenting, modeless text

Comment 7 Glenn Morris 2014-10-23 21:46:39 UTC
Why do you want to have them in separate packages?

And with regards to it being uninstallable, I would again like to say that removing the .el files is not a mode of installation that upstream Emacs expects or supports. (I am speaking as an Emacs developer.) What would the point of uninstalling it be? To save 14MB?

If you were packaging Emacs today from scratch, I don't think you would come up with this split; so why not simplify future maintenance?

Comment 8 Glenn Morris 2014-10-23 21:48:38 UTC
Or maybe I misunderstood what you meant by

> In the rawhide, can be specified SPEC tag like Recommends which means
> that you can uninstall package without troubles if you wants.

Comment 9 Petr Hracek 2014-10-24 07:54:35 UTC
Hi,

well, I would like to explain the situation a bit else.

In rawhide we will have a emacs-common and emacs-el packages. And emacs-common files will require emacs-el packages.

But as you mentioned el files are part of installation and I will do that as proposed Sergio.

Comment 10 Petr Hracek 2014-10-24 09:53:58 UTC
The bug is fixed by commit (https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20141020/1416577.html)

Comment 11 Fedora Update System 2014-10-24 12:51:28 UTC
emacs-24.3-28.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/emacs-24.3-28.fc21

Comment 12 Fedora Update System 2014-10-27 14:55:16 UTC
emacs-24.4-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/emacs-24.4-1.fc21

Comment 13 Fedora Update System 2014-10-29 10:37:03 UTC
emacs-24.4-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/emacs-24.4-2.fc21

Comment 14 Fedora Update System 2014-12-06 10:01:07 UTC
emacs-24.4-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.