Bug 1152991 - [REST][CLI] Balloon on VM re-enabled on every API CALL for VM
Summary: [REST][CLI] Balloon on VM re-enabled on every API CALL for VM
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.0
Hardware: All
OS: Unspecified
medium
high
Target Milestone: ---
: 3.5.0
Assignee: Vitor de Lima
QA Contact: Lukas Svaty
URL:
Whiteboard: sla
: 1153006 (view as bug list)
Depends On:
Blocks: 1155649
TreeView+ depends on / blocked
 
Reported: 2014-10-15 10:45 UTC by Lukas Svaty
Modified: 2016-02-10 20:17 UTC (History)
15 users (show)

Fixed In Version: org.ovirt.engine-root-3.5.0-19
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1155649 (view as bug list)
Environment:
Last Closed: 2015-02-17 17:15:16 UTC
oVirt Team: SLA
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 34208 0 master MERGED core, restapi,engine: Avoid enabling balloon device on VM edit Never
oVirt gerrit 34209 0 ovirt-engine-3.5 MERGED core, restapi,engine: Avoid enabling balloon device on VM edit Never

Description Lukas Svaty 2014-10-15 10:45:31 UTC
Description of problem:
Balloon on VM is re-enabled with every API call.

Version-Release number of selected component (if applicable):
vt5

How reproducible:
100%

Steps to Reproduce:
1. Add VM
2. Edit VM -> Resource Allocation -> Uncheck 'Memory Balloon Device Enabled'
3. Edit VM name via REST or other API

curl -X PUT -H "Accept: application/xml" -H "Content-Type: application/xml" -u admin@internal:$pwd --cacert ca.crt -d "<vm><name>foo</name></vm>" https://$engine/api/vms/$vmID


Actual results:
VM is re-enabled on VM.

Expected results:
All the settings of VM should stay as before REST API call edit except for name.

Additional info:
The same behaviour via rhevm-shell.
This fix should be backported to rhevm 3.4 as it is causing huge problems with ppc where ballooning is not supported.

Comment 1 Juan Hernández 2014-10-16 08:59:07 UTC
Whatever the solution to this issue is, please try to make sure that there is no business logic inside the RESTAPI.

Comment 3 Michal Skrivanek 2014-10-22 14:33:37 UTC
so is this reproducible on 3.4.z engine?

Comment 4 Lukas Svaty 2014-10-22 14:40:22 UTC
yes, 

WA for this is to add to every API CALL

<ballooning>false<ballooning>

In case this is missing in the API call balloon will be reenabled

Comment 5 Doron Fediuck 2014-10-26 18:21:47 UTC
*** Bug 1153006 has been marked as a duplicate of this bug. ***

Comment 6 Lukas Svaty 2014-11-10 16:27:23 UTC
verified in vt9

Comment 7 Eyal Edri 2015-02-17 17:15:16 UTC
rhev 3.5.0 was released. closing.


Note You need to log in before you can comment on or make changes to this bug.