Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1153317

Summary: Jenkins cartridge update for BZ#1127667 doesn't affect active gears
Product: OpenShift Container Platform Reporter: John W. Lamb <jolamb>
Component: ImageStreamsAssignee: Jason DeTiberus <jdetiber>
Status: CLOSED ERRATA QA Contact: libra bugs <libra-bugs>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 2.1.0CC: jialiu, jokerman, libra-onpremise-devel, mmccomas, pruan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openshift-origin-cartridge-jenkins-1.20.3.6-1.el6op Doc Type: Bug Fix
Doc Text:
Cause: openshift-origin-cartridge-jenkins manifest wasn't updated with a new Cartridge-Version. Consequence: oo-admin-upgrade isn't able to automatically update deployed jenkins gears. Fix: Increment the Cartridge-Version field in openshift-origin-cartridge-jenkins manifest and update the Compatible-Versions field appropriately Result: The standard oo-admin-upgrade steps update deployed jenkins gears.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-16 19:21:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description John W. Lamb 2014-10-15 18:42:11 UTC
Description of problem:
The version of the openshift-origin-cartridge-jenkins package shipped by advisory RHBA-2014:1630-03 doesn't have an updated Cartridge-Version field in the manifest.yml file. As a result, "oo-admin-upgrade upgrade-node --version=2.1.7" doesn't affect deployed jenkins gears, only new ones.

Version-Release number of selected component (if applicable):
openshift-origin-cartridge-jenkins-1.20.3.5-1.el6op

How reproducible:
Update to openshift-origin-cartridge-jenkins-1.20.3.5-1.el6op and run "oo-admin-upgrade upgrade-node --version=2.1.7"

Steps to Reproduce:
1. rhc app-create appname php-5.4 --enable jenkins
2. yum update
3. service ruby193-mcollective restart
4. oo-admin-ctl-cartridge -c import-profile --activate --obsolete
5. oo-admin-ctl-cartridge -c migrate
6. oo-admin-upgrade archive
7. oo-admin-upgrade upgrade-node --version=2.1.7

Actual results:
# rhc ssh jenkins 'grep bad_cipher $OPENSHIFT_JENKINS_DIR/bin/control'
... no output

Expected results:
# rhc ssh jenkins 'grep bad_cipher $OPENSHIFT_JENKINS_DIR/bin/control'
  if marker_present "disable_bad_ciphers_auto"; then
  if marker_present "disable_bad_ciphers_yes"; then

Additional info:

Comment 4 Johnny Liu 2014-10-16 11:11:03 UTC
Verified this bug with openshift-origin-cartridge-jenkins-1.20.3.6-1.el6op, and PASS.

Setup old env and create an app, and embed jenkins client to it, jenkins build is working well. And no output when running "rhc ssh jenkins 'grep bad_cipher $OPENSHIFT_JENKINS_DIR/bin/control'".

# rpm -qa|grep jenkins
jenkins-plugin-openshift-0.6.37.1-0.el6op.x86_64
jenkins-1.554.2-1.el6op.noarch
openshift-origin-cartridge-jenkins-1.20.3.4-1.el6op.noarch
openshift-origin-cartridge-jenkins-client-1.19.3.5-1.el6op.noarch

Update env to RHEL-6.6 and update ose to the latest puddle, due to openshift-origin-cartridge-jenkins is not included into puddle, I have to update openshift-origin-cartridge-jenkins-1.20.3.6-1.el6op manually.

Reboot node.
No output when running "rhc ssh jenkins 'grep bad_cipher $OPENSHIFT_JENKINS_DIR/bin/control'"

On broker, run the following command:
oo-admin-ctl-cartridge -c import-profile --activate --obsolete 
oo-admin-ctl-cartridge -c migrate
oo-admin-upgrade archive
oo-admin-upgrade upgrade-node --version=2.1

$ rhc ssh jenkins 'grep bad_cipher $OPENSHIFT_JENKINS_DIR/bin/control'
  if marker_present "disable_bad_ciphers_auto"; then
  if marker_present "disable_bad_ciphers_yes"; then

# ps -ef|grep hudson
4776      4547     1 18 06:55 ?        00:00:13 /etc/alternatives/jre/bin/java -Xmx168m -XX:MaxPermSize=100m -Djava.awt.headless=true -Dhudson.udp=-1 -DJENKINS_HOME=/var/lib/openshift/543f840587692b2b6d000024/app-root/data/ -Dhudson.slaves.NodeProvisioner.recurrencePeriod=500 -Dhudson.slaves.NodeProvisioner.initialDelay=100 -Dhudson.slaves.NodeProvisioner.MARGIN=100 -Dhudson.model.UpdateCenter.never=true -Dhudson.DNSMultiCast.disabled=true -jar /usr/lib/jenkins/jenkins.war --ajp13Port=-1 --controlPort=-1 --logfile=/dev/stdout --httpPort=8080 --handlerCountMax=45 --handlerCountMaxIdle=20 --httpListenAddress=127.9.84.1


Touch .openshift/markers/disable_bad_ciphers_auto in jenkins app git repo, then git push.

# ps -ef|grep hudson
4776      6263     1 13 06:58 ?        00:00:22 /etc/alternatives/jre/bin/java -Xmx168m -XX:MaxPermSize=100m -Djava.awt.headless=true -Dhudson.udp=-1 -Ddisable_bad_sslciphers=auto -DJENKINS_HOME=/var/lib/openshift/543f840587692b2b6d000024/app-root/data/ -Dhudson.slaves.NodeProvisioner.recurrencePeriod=500 -Dhudson.slaves.NodeProvisioner.initialDelay=100 -Dhudson.slaves.NodeProvisioner.MARGIN=100 -Dhudson.model.UpdateCenter.never=true -Dhudson.DNSMultiCast.disabled=true -jar /usr/lib/jenkins/jenkins.war --ajp13Port=-1 --controlPort=-1 --logfile=/dev/stdout --httpPort=8080 --handlerCountMax=45 --handlerCountMaxIdle=20 --httpListenAddress=127.9.84.1

Do some change in app repo, and trigger jenkins build, jenkins build succeed.

Remove .openshift/markers/disable_bad_ciphers_auto, then trigger jenkins build, also succeed.

Due to there is no puddle, so I have to move this bug to "MODIFIED".

Comment 6 errata-xmlrpc 2014-10-16 19:21:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1656.html