Description of problem:
There's no protection against users deleting Root categories.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Log in as a CMS admin user
2. Delete the root category
The entire category tree is deleted with no warning.
There should be a warning informing the user what they are about to do.
This issue is logged by Stoke On Trent.
Actually, the problem here is that the permission management pane is
not visible for the root category. If this was there, then the users
can mange the permissions better.
Created attachment 98241 [details]
a one-line patch that removes special treatment of root categories
The permission section for the categories tab is implemented by
CategoryItemPane$PermissonsSection which was added in change 34213 by
Archit. There is an explicit check for whether the category is root
or not. If it is, the permission section is not displayed. We can
ask Archit if he remembers why this special treatment of the root
category was necessary.
I tried removing this special-case treatment (see the patch). The
result looks pretty funky. (Screenshots to follow.) Since there
doesn't seem to be a one-line fix for this, I'm not going to spend any
more time on this today. (I just thought I'd try.)
Created attachment 98242 [details]
screenshot of the permission section for a non-root category
Created attachment 98243 [details]
screenshot of the permission section for a root category
Compare this to attachment 98242 [details] and note the extra panel and a search
widget at the bottom.
I'm not sure I understand. with attachment 98243 [details] there's two
permissions sections and two search boxes?
I overstated my case a little bit. Correction:
attachment 98242 [details] has one search widget and one permissions section.
attachment 98243 [details] has one search widget and two permissions sections.
Closing old tickets