Bug 1153642 - top crashed
Summary: top crashed
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: procps-ng
Version: 21
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: Jaromír Cápík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-16 12:22 UTC by Michele Baldessari
Modified: 2016-02-01 02:00 UTC (History)
2 users (show)

Fixed In Version: 3.3.10-8.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-20 05:22:08 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Michele Baldessari 2014-10-16 12:22:18 UTC 
Description of problem:
I really like the new top. Thanks for that ;)

Due to some vim plugin bug I had a constant forking going on and wanted to use
top to inspect what was going on and it segfaulted.

Here is the backtrace:
Program received signal SIGSEGV, Segmentation fault.
forest_adds (self=self@entry=1730, level=level@entry=144) at top.c:4908
4908       Tree_ppt[Tree_idx] = Seed_ppt[self];     // add this as root or child
Missing separate debuginfos, use: debuginfo-install libgcc-4.9.1-11.fc21.x86_64 numactl-devel-2.0.9-4.fc21.x86_64
(gdb) bt
#0  forest_adds (self=self@entry=1730, level=level@entry=144) at top.c:4908
#1  0x0000000000403d65 in forest_adds (self=self@entry=1729, level=level@entry=143) at top.c:4913
#2  0x0000000000403d65 in forest_adds (self=self@entry=1728, level=level@entry=142) at top.c:4913
#3  0x0000000000403d65 in forest_adds (self=self@entry=1727, level=level@entry=141) at top.c:4913
#4  0x0000000000403d65 in forest_adds (self=self@entry=1726, level=level@entry=140) at top.c:4913
#5  0x0000000000403d65 in forest_adds (self=self@entry=1725, level=level@entry=139) at top.c:4913
#6  0x0000000000403d65 in forest_adds (self=self@entry=1724, level=level@entry=138) at top.c:4913
#7  0x0000000000403d65 in forest_adds (self=self@entry=1723, level=level@entry=137) at top.c:4913
#8  0x0000000000403d65 in forest_adds (self=self@entry=1722, level=level@entry=136) at top.c:4913
#9  0x0000000000403d65 in forest_adds (self=self@entry=1721, level=level@entry=135) at top.c:4913
#10 0x0000000000403d65 in forest_adds (self=self@entry=1720, level=level@entry=134) at top.c:4913
#11 0x0000000000403d65 in forest_adds (self=self@entry=1719, level=level@entry=133) at top.c:4913
#12 0x0000000000403d65 in forest_adds (self=self@entry=1718, level=level@entry=132) at top.c:4913
#13 0x0000000000403d65 in forest_adds (self=self@entry=1717, level=level@entry=131) at top.c:4913
#14 0x0000000000403d65 in forest_adds (self=self@entry=1716, level=level@entry=130) at top.c:4913
#15 0x0000000000403d65 in forest_adds (self=self@entry=1715, level=level@entry=129) at top.c:4913
#16 0x0000000000403d65 in forest_adds (self=self@entry=1714, level=level@entry=128) at top.c:4913
#17 0x0000000000403d65 in forest_adds (self=self@entry=1713, level=level@entry=127) at top.c:4913
#18 0x0000000000403d65 in forest_adds (self=self@entry=1712, level=level@entry=126) at top.c:4913
#19 0x0000000000403d65 in forest_adds (self=self@entry=1711, level=level@entry=125) at top.c:4913
#20 0x0000000000403d65 in forest_adds (self=self@entry=1710, level=level@entry=124) at top.c:4913
#21 0x0000000000403d65 in forest_adds (self=self@entry=1709, level=level@entry=123) at top.c:4913
#22 0x0000000000403d65 in forest_adds (self=self@entry=1708, level=level@entry=122) at top.c:4913
#23 0x0000000000403d65 in forest_adds (self=self@entry=1707, level=level@entry=121) at top.c:4913
#24 0x0000000000403d65 in forest_adds (self=self@entry=1706, level=level@entry=120) at top.c:4913
#25 0x0000000000403d65 in forest_adds (self=self@entry=1705, level=level@entry=119) at top.c:4913
#26 0x0000000000403d65 in forest_adds (self=self@entry=1704, level=level@entry=118) at top.c:4913
#27 0x0000000000403d65 in forest_adds (self=self@entry=1703, level=level@entry=117) at top.c:4913
#28 0x0000000000403d65 in forest_adds (self=self@entry=1702, level=level@entry=116) at top.c:4913
#29 0x0000000000403d65 in forest_adds (self=self@entry=1701, level=level@entry=115) at top.c:4913
#30 0x0000000000403d65 in forest_adds (self=self@entry=1700, level=level@entry=114) at top.c:4913
#31 0x0000000000403d65 in forest_adds (self=self@entry=1699, level=level@entry=113) at top.c:4913
#32 0x0000000000403d65 in forest_adds (self=self@entry=1698, level=level@entry=112) at top.c:4913
#33 0x0000000000403d65 in forest_adds (self=self@entry=1697, level=level@entry=111) at top.c:4913
#34 0x0000000000403d65 in forest_adds (self=self@entry=1696, level=level@entry=110) at top.c:4913
#35 0x0000000000403d65 in forest_adds (self=self@entry=1695, level=level@entry=109) at top.c:4913
#36 0x0000000000403d65 in forest_adds (self=self@entry=1694, level=level@entry=108) at top.c:4913
#37 0x0000000000403d65 in forest_adds (self=self@entry=1693, level=level@entry=107) at top.c:4913
#38 0x0000000000403d65 in forest_adds (self=self@entry=1692, level=level@entry=106) at top.c:4913
#39 0x0000000000403d65 in forest_adds (self=self@entry=1691, level=level@entry=105) at top.c:4913
#40 0x0000000000403d65 in forest_adds (self=self@entry=1690, level=level@entry=104) at top.c:4913
#41 0x0000000000403d65 in forest_adds (self=self@entry=1689, level=level@entry=103) at top.c:4913
#42 0x0000000000403d65 in forest_adds (self=self@entry=1688, level=level@entry=102) at top.c:4913
#43 0x0000000000403d65 in forest_adds (self=self@entry=1687, level=level@entry=101) at top.c:4913
#44 0x0000000000403d65 in forest_adds (self=self@entry=1686, level=level@entry=100) at top.c:4913
#45 0x0000000000403d65 in forest_adds (self=self@entry=1685, level=level@entry=99) at top.c:4913
#46 0x0000000000403d65 in forest_adds (self=self@entry=1684, level=level@entry=98) at top.c:4913
#47 0x0000000000403d65 in forest_adds (self=self@entry=1683, level=level@entry=97) at top.c:4913
#48 0x0000000000403d65 in forest_adds (self=self@entry=1682, level=level@entry=96) at top.c:4913
#49 0x0000000000403d65 in forest_adds (self=self@entry=1681, level=level@entry=95) at top.c:4913
#50 0x0000000000403d65 in forest_adds (self=self@entry=1680, level=level@entry=94) at top.c:4913
#51 0x0000000000403d65 in forest_adds (self=self@entry=1679, level=level@entry=93) at top.c:4913
#52 0x0000000000403d65 in forest_adds (self=self@entry=1678, level=level@entry=92) at top.c:4913
#53 0x0000000000403d65 in forest_adds (self=self@entry=1677, level=level@entry=91) at top.c:4913
#54 0x0000000000403d65 in forest_adds (self=self@entry=1676, level=level@entry=90) at top.c:4913
#55 0x0000000000403d65 in forest_adds (self=self@entry=1675, level=level@entry=89) at top.c:4913
#56 0x0000000000403d65 in forest_adds (self=self@entry=1674, level=level@entry=88) at top.c:4913
#57 0x0000000000403d65 in forest_adds (self=self@entry=1673, level=level@entry=87) at top.c:4913
#58 0x0000000000403d65 in forest_adds (self=self@entry=1672, level=level@entry=86) at top.c:4913
#59 0x0000000000403d65 in forest_adds (self=self@entry=1671, level=level@entry=85) at top.c:4913
#60 0x0000000000403d65 in forest_adds (self=self@entry=1670, level=level@entry=84) at top.c:4913
#61 0x0000000000403d65 in forest_adds (self=self@entry=1669, level=level@entry=83) at top.c:4913
#62 0x0000000000403d65 in forest_adds (self=self@entry=1668, level=level@entry=82) at top.c:4913
#63 0x0000000000403d65 in forest_adds (self=self@entry=1667, level=level@entry=81) at top.c:4913
#64 0x0000000000403d65 in forest_adds (self=self@entry=1666, level=level@entry=80) at top.c:4913
#65 0x0000000000403d65 in forest_adds (self=self@entry=1665, level=level@entry=79) at top.c:4913
#66 0x0000000000403d65 in forest_adds (self=self@entry=1664, level=level@entry=78) at top.c:4913
#67 0x0000000000403d65 in forest_adds (self=self@entry=1663, level=level@entry=77) at top.c:4913
#68 0x0000000000403d65 in forest_adds (self=self@entry=1662, level=level@entry=76) at top.c:4913
#69 0x0000000000403d65 in forest_adds (self=self@entry=1661, level=level@entry=75) at top.c:4913
#70 0x0000000000403d65 in forest_adds (self=self@entry=1660, level=level@entry=74) at top.c:4913
#71 0x0000000000403d65 in forest_adds (self=self@entry=1659, level=level@entry=73) at top.c:4913
#72 0x0000000000403d65 in forest_adds (self=self@entry=1658, level=level@entry=72) at top.c:4913
#73 0x0000000000403d65 in forest_adds (self=self@entry=1657, level=level@entry=71) at top.c:4913
#74 0x0000000000403d65 in forest_adds (self=self@entry=1656, level=level@entry=70) at top.c:4913
#75 0x0000000000403d65 in forest_adds (self=self@entry=1655, level=level@entry=69) at top.c:4913
#76 0x0000000000403d65 in forest_adds (self=self@entry=1654, level=level@entry=68) at top.c:4913
#77 0x0000000000403d65 in forest_adds (self=self@entry=1653, level=level@entry=67) at top.c:4913
#78 0x0000000000403d65 in forest_adds (self=self@entry=1652, level=level@entry=66) at top.c:4913
#79 0x0000000000403d65 in forest_adds (self=self@entry=1651, level=level@entry=65) at top.c:4913
#80 0x0000000000403d65 in forest_adds (self=self@entry=1650, level=level@entry=64) at top.c:4913
#81 0x0000000000403d65 in forest_adds (self=self@entry=1649, level=level@entry=63) at top.c:4913
#82 0x0000000000403d65 in forest_adds (self=self@entry=1648, level=level@entry=62) at top.c:4913
#83 0x0000000000403d65 in forest_adds (self=self@entry=1647, level=level@entry=61) at top.c:4913
#84 0x0000000000403d65 in forest_adds (self=self@entry=1646, level=level@entry=60) at top.c:4913
#85 0x0000000000403d65 in forest_adds (self=self@entry=1645, level=level@entry=59) at top.c:4913
#86 0x0000000000403d65 in forest_adds (self=self@entry=1644, level=level@entry=58) at top.c:4913
#87 0x0000000000403d65 in forest_adds (self=self@entry=1643, level=level@entry=57) at top.c:4913
#88 0x0000000000403d65 in forest_adds (self=self@entry=1642, level=level@entry=56) at top.c:4913
#89 0x0000000000403d65 in forest_adds (self=self@entry=1641, level=level@entry=55) at top.c:4913
#90 0x0000000000403d65 in forest_adds (self=self@entry=1640, level=level@entry=54) at top.c:4913
#91 0x0000000000403d65 in forest_adds (self=self@entry=1639, level=level@entry=53) at top.c:4913
#92 0x0000000000403d65 in forest_adds (self=self@entry=1638, level=level@entry=52) at top.c:4913
#93 0x0000000000403d65 in forest_adds (self=self@entry=1637, level=level@entry=51) at top.c:4913
#94 0x0000000000403d65 in forest_adds (self=self@entry=1636, level=level@entry=50) at top.c:4913
#95 0x0000000000403d65 in forest_adds (self=self@entry=1635, level=level@entry=49) at top.c:4913
#96 0x0000000000403d65 in forest_adds (self=self@entry=1634, level=level@entry=48) at top.c:4913
#97 0x0000000000403d65 in forest_adds (self=self@entry=1633, level=level@entry=47) at top.c:4913
#98 0x0000000000403d65 in forest_adds (self=self@entry=1632, level=level@entry=46) at top.c:4913
#99 0x0000000000403d65 in forest_adds (self=self@entry=1631, level=level@entry=45) at top.c:4913
#100 0x0000000000403d65 in forest_adds (self=self@entry=1630, level=level@entry=44) at top.c:4913
#101 0x0000000000403d65 in forest_adds (self=self@entry=1629, level=level@entry=43) at top.c:4913
#102 0x0000000000403d65 in forest_adds (self=self@entry=1628, level=level@entry=42) at top.c:4913
#103 0x0000000000403d65 in forest_adds (self=self@entry=1627, level=level@entry=41) at top.c:4913
#104 0x0000000000403d65 in forest_adds (self=self@entry=1626, level=level@entry=40) at top.c:4913
#105 0x0000000000403d65 in forest_adds (self=self@entry=1625, level=level@entry=39) at top.c:4913
#106 0x0000000000403d65 in forest_adds (self=self@entry=1624, level=level@entry=38) at top.c:4913
#107 0x0000000000403d65 in forest_adds (self=self@entry=1623, level=level@entry=37) at top.c:4913
#108 0x0000000000403d65 in forest_adds (self=self@entry=1622, level=level@entry=36) at top.c:4913
#109 0x0000000000403d65 in forest_adds (self=self@entry=1621, level=level@entry=35) at top.c:4913
#110 0x0000000000403d65 in forest_adds (self=self@entry=1620, level=level@entry=34) at top.c:4913
#111 0x0000000000403d65 in forest_adds (self=self@entry=1619, level=level@entry=33) at top.c:4913
#112 0x0000000000403d65 in forest_adds (self=self@entry=1618, level=level@entry=32) at top.c:4913
#113 0x0000000000403d65 in forest_adds (self=self@entry=1617, level=level@entry=31) at top.c:4913
#114 0x0000000000403d65 in forest_adds (self=self@entry=1616, level=level@entry=30) at top.c:4913
#115 0x0000000000403d65 in forest_adds (self=self@entry=1615, level=level@entry=29) at top.c:4913
#116 0x0000000000403d65 in forest_adds (self=self@entry=1614, level=level@entry=28) at top.c:4913
#117 0x0000000000403d65 in forest_adds (self=self@entry=1613, level=level@entry=27) at top.c:4913
#118 0x0000000000403d65 in forest_adds (self=self@entry=1612, level=level@entry=26) at top.c:4913
#119 0x0000000000403d65 in forest_adds (self=self@entry=1611, level=level@entry=25) at top.c:4913
#120 0x0000000000403d65 in forest_adds (self=self@entry=1610, level=level@entry=24) at top.c:4913
#121 0x0000000000403d65 in forest_adds (self=self@entry=1609, level=level@entry=23) at top.c:4913
#122 0x0000000000403d65 in forest_adds (self=self@entry=1608, level=level@entry=22) at top.c:4913
#123 0x0000000000403d65 in forest_adds (self=self@entry=1607, level=level@entry=21) at top.c:4913
#124 0x0000000000403d65 in forest_adds (self=self@entry=1606, level=level@entry=20) at top.c:4913
#125 0x0000000000403d65 in forest_adds (self=self@entry=1605, level=level@entry=19) at top.c:4913
#126 0x0000000000403d65 in forest_adds (self=self@entry=1604, level=level@entry=18) at top.c:4913
#127 0x0000000000403d65 in forest_adds (self=self@entry=1603, level=level@entry=17) at top.c:4913
#128 0x0000000000403d65 in forest_adds (self=self@entry=1602, level=level@entry=16) at top.c:4913
#129 0x0000000000403d65 in forest_adds (self=self@entry=1601, level=level@entry=15) at top.c:4913
#130 0x0000000000403d65 in forest_adds (self=self@entry=1600, level=level@entry=14) at top.c:4913
#131 0x0000000000403d65 in forest_adds (self=self@entry=1599, level=level@entry=13) at top.c:4913
#132 0x0000000000403d65 in forest_adds (self=self@entry=1598, level=level@entry=12) at top.c:4913
#133 0x0000000000403d65 in forest_adds (self=self@entry=1597, level=level@entry=11) at top.c:4913
#134 0x0000000000403d65 in forest_adds (self=self@entry=1596, level=level@entry=10) at top.c:4913
#135 0x0000000000403d65 in forest_adds (self=self@entry=1595, level=level@entry=9) at top.c:4913
#136 0x0000000000403d65 in forest_adds (self=self@entry=1594, level=level@entry=8) at top.c:4913
#137 0x0000000000403d65 in forest_adds (self=self@entry=1593, level=level@entry=7) at top.c:4913
#138 0x0000000000403d65 in forest_adds (self=self@entry=1592, level=level@entry=6) at top.c:4913
#139 0x0000000000403d65 in forest_adds (self=self@entry=1591, level=level@entry=5) at top.c:4913
#140 0x0000000000403d65 in forest_adds (self=self@entry=1590, level=level@entry=4) at top.c:4913
#141 0x0000000000403d65 in forest_adds (self=self@entry=1589, level=level@entry=3) at top.c:4913
#142 0x0000000000403d65 in forest_adds (self=self@entry=1588, level=level@entry=2) at top.c:4913
#143 0x0000000000403d65 in forest_adds (self=<optimized out>, level=level@entry=1) at top.c:4913
#144 0x000000000040df64 in forest_create (q=0x63ddc0) at top.c:4947
#145 window_show (q=q@entry=0x63ddc0, wmax=28) at top.c:5561
#146 0x000000000040e19b in frame_make () at top.c:5670
#147 0x00000000004034f0 in main (dont_care_argc=1730, argv=0x7fffffffd8d0) at top.c:5716

Likely only due to the massive parent()->child()->child()->child()... issue I had

Version-Release number of selected component (if applicable):
procps-ng-3.3.10-3.fc21.x86_64

How reproducible:
Likely you need an insane deep parent->child list of processes
Comment 1 Jaromír Cápík 2014-10-20 18:06:59 UTC 
Hello Michele.

Thanks for the report.
It looks like a bug in the forest view.
I'm going to pass that to Jim.

Regards,
Jaromir.
Comment 2 Jaromír Cápík 2014-10-20 19:00:31 UTC 
Jim responded it looks more like a stack overflow that could be avoided with increasing the stack size from the default value 8192 with 'ulimit -s <new value>'. Anyway, I'm checking how difficult would be to detect the stack overflow prior the crash so that we could return a more useful error message.
Comment 3 Michele Baldessari 2014-10-20 19:43:01 UTC 
Hi Jaromír,

ah yes, likely we just hit a stack limit. I guess it's such a corner case, if you
don't feel like playing too much with setrlimit(RLIMIT_STACK) or it's hard to
decide on a reasonable value, I guess we can also just close this ;)
If many people hit it, we can reevaluate after all. Up to you

Thanks a lot for your help,
Michele
Comment 4 Jaromír Cápík 2014-11-07 16:18:32 UTC 
Hello Michele.

Surprisingly this wasn't a stack limit. It really was a bug and has been fixed upstream already.

I'll apply the patch soon.

Thanks,
Jaromir.
Comment 5 Fedora Update System 2015-08-10 16:05:41 UTC 
procps-ng-3.3.10-8.fc23 has been submitted as an update for Fedora 23.
https://admin.fedoraproject.org/updates/procps-ng-3.3.10-8.fc23
Comment 6 Fedora Update System 2015-08-10 16:05:49 UTC 
procps-ng-3.3.10-8.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/procps-ng-3.3.10-8.fc22
Comment 7 Fedora Update System 2015-08-10 16:05:55 UTC 
procps-ng-3.3.10-8.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/procps-ng-3.3.10-8.fc21
Comment 8 Fedora Update System 2015-08-12 07:05:08 UTC 
Package procps-ng-3.3.10-8.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing procps-ng-3.3.10-8.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-13248/procps-ng-3.3.10-8.fc22
then log in and leave karma (feedback).
Comment 9 Fedora Update System 2015-08-20 05:22:06 UTC 
procps-ng-3.3.10-8.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2015-08-20 05:42:43 UTC 
procps-ng-3.3.10-8.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2015-08-20 05:55:29 UTC 
procps-ng-3.3.10-8.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2015-08-20 14:47:42 UTC 
procps-ng-3.3.10-8.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
Comment 13 Fedora Update System 2015-08-20 19:17:25 UTC 
procps-ng-3.3.10-8.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.