Description of problem: After updating to 'NetworkManager-config-connectivity-fedora-0.9.10.0-7.git20140704.fc21.x86_64' I saw that package replaced my custom config file and saved it as .rpmsave. I think new file should be .rpmnew instead of replacing user edited config? 1 warning: /etc/NetworkManager/conf.d/20-connectivity-fedora.conf saved as /etc/NetworkManager/conf.d/20-connectivity-fedora.conf.rpmsave Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Created attachment 948461 [details] [PATCH] do not override modified configuration files on updates Proposed change for rpm spec file.
I'm no rpm guru, but I believe that is correct
Change for upstream RPM spec in jk/rpm-config.
Two small points there: * User shouldn't touch those files. If they mind the configuration, they shouldn't install the package in the first place. * We shouldn't put files user is not supposed to touch into /etc. They really belong into /lib (what udev, modprobe, systemd, etc. do these days) However, now that they're in /etc, noreplace makes sense to me. No problem if we decide to move them away either.
(In reply to Lubomir Rintel from comment #4) > Two small points there: > > * User shouldn't touch those files. If they mind the configuration, they > shouldn't install the package in the first place. Note, that the files in /etc/NetworkManager/config.d/ take precedence over /etc/NetworkManager/NetworkManager.config . So, the user would have to remove the package if he wants to change the options. > * We shouldn't put files user is not supposed to touch into /etc. They > really belong into /lib (what udev, modprobe, systemd, etc. do these days) Yesterday I opened: https://bugzilla.gnome.org/show_bug.cgi?id=738853
(In reply to Thomas Haller from comment #5) > Note, that the files in /etc/NetworkManager/config.d/ take precedence over > /etc/NetworkManager/NetworkManager.config . So, the user would have to > remove the package if he wants to change the options. well, he could also add /etc/NetworkManager/config.d/99-no-connectivity or something; the files are loaded in order
(In reply to Dan Winship from comment #6) > (In reply to Thomas Haller from comment #5) > > Note, that the files in /etc/NetworkManager/config.d/ take precedence over > > /etc/NetworkManager/NetworkManager.config . So, the user would have to > > remove the package if he wants to change the options. > > well, he could also add /etc/NetworkManager/config.d/99-no-connectivity or > something; the files are loaded in order Yeah, it might be better to use own override config files. Fedora 21: http://pkgs.fedoraproject.org/cgit/NetworkManager.git/commit/?h=f21&id=5717faa588c8154fed4ccba33c1c2f47bd50624a Upstream: 5d66f91 contrib/rpm: do not override configuration files on updates (rh #1153901)
Thanks for fixing this! (In reply to Lubomir Rintel from comment #4) > Two small points there: > > * User shouldn't touch those files. If they mind the configuration, they > shouldn't install the package in the first place. Currently I see no other way to do this, if you look at f21 workstation, removing the package isn't possible without breaking things, two other packages currently depend on this. I was against this feature being enabled by default and without easy way to disable it, but that is discussed on IRC, mailing list, and in https://fedorahosted.org/fesco/ticket/1337