Bug 1153964 - quota: rename of "dir" fails in case of quota space availability is around 1GB
Summary: quota: rename of "dir" fails in case of quota space availability is around 1GB
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: quota
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Raghavendra G
QA Contact:
URL:
Whiteboard:
Depends On: 1139104 1177592
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-17 08:18 UTC by Vijaikumar Mallikarjuna
Modified: 2018-11-21 02:53 UTC (History)
4 users (show)

Fixed In Version:
Clone Of: 1139104
Environment:
Last Closed: 2018-11-21 02:53:58 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Comment 1 Anand Avati 2014-10-17 08:20:54 UTC 
REVIEW: http://review.gluster.org/8940 (quota: rename should continue if src and dst are under the same branch where limit is set) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 2 Anand Avati 2014-12-04 14:48:53 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 3 Anand Avati 2014-12-05 06:31:14 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 4 Anand Avati 2014-12-05 08:31:23 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 5 Anand Avati 2014-12-05 08:43:07 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 6 Anand Avati 2014-12-16 10:19:22 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 7 Anand Avati 2014-12-16 13:18:15 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 8 Anand Avati 2014-12-18 04:10:22 UTC 
REVIEW: http://review.gluster.org/9293 (quota: No need for quota-limit check if rename is under same parent) posted (#1) for review on master by venkatesh somyajulu (vsomyaju)
Comment 9 Anand Avati 2014-12-19 10:58:08 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#8) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 10 Anand Avati 2014-12-19 12:32:23 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#9) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 11 Anand Avati 2014-12-19 12:39:16 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#10) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 12 Anand Avati 2014-12-19 13:27:09 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#11) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 13 Anand Avati 2014-12-22 05:18:56 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#12) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 14 Anand Avati 2014-12-24 10:18:39 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#13) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 15 Anand Avati 2014-12-24 10:55:12 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#14) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 16 Anand Avati 2014-12-24 11:01:12 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#15) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 17 Anand Avati 2014-12-24 11:05:51 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#16) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 18 Anand Avati 2014-12-24 11:36:19 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#17) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 19 Anand Avati 2014-12-26 09:15:08 UTC 
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#18) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 20 Anand Avati 2014-12-27 13:52:12 UTC 
COMMIT: http://review.gluster.org/8940 committed in master by Raghavendra G (rgowdapp) 
------
commit b6ea761969f85fbb0f22810eb3a3bf1476c8792c
Author: vmallika <vmallika>
Date:   Wed Dec 24 15:13:36 2014 +0530

    quota: For a rename operation, do quota_check_limit only till the
    common ancestor of src and dst file
    
    Example:
    set quota limit set to 1GB on /
    create a file /a1/b1/file1 of 600MB
    mv /a1/b1/file1 /a1/b1/file2
    This rename fails as it takes delta into account which sums up to 1.2BG.
    Though we are not creating new file, we still get quota exceeded error.
    So quota enforce should happen only till b1.
    
    Similarly:
    mv /a/b/c/file /a/b/x/y/file
    quota enforce should happen only till dir 'b'
    
    Change-Id: Ia1e5363da876c3d71bd424e67a8bb28b7ac1c7c1
    BUG: 1153964
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/8940
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>
Comment 21 Anand Avati 2015-01-08 13:35:52 UTC 
REVIEW: http://review.gluster.org/9419 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 22 Anand Avati 2015-01-08 13:36:18 UTC 
REVIEW: http://review.gluster.org/9419 (quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 23 Anand Avati 2015-01-08 13:36:48 UTC 
REVIEW: http://review.gluster.org/9419 (quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 24 Anand Avati 2015-01-12 11:32:17 UTC 
REVIEW: http://review.gluster.org/9419 (quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 25 Anand Avati 2015-01-12 12:00:32 UTC 
REVIEW: http://review.gluster.org/9419 (quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)
Comment 26 Anand Avati 2015-01-19 10:39:45 UTC 
COMMIT: http://review.gluster.org/9419 committed in master by Raghavendra G (rgowdapp) 
------
commit 8d73f6288249757662cf36e746835e3ecd84add1
Author: vmallika <vmallika>
Date:   Thu Jan 8 16:03:04 2015 +0530

    quota: For a link operation, do quota_check_limit only till the
    common ancestor of src and dst file
    
    In a dht_rename, if src_cached and dst_hashed are different, then
    rename is split into link and unlink.
    We need to handle quota_link properly.
    
    We have fixed quota_rename in patch# 8940, we need to handle quota_link
    similarly
    
    > http://review.gluster.org/#/c/8940/
    > quota: For a rename operation, do quota_check_limit only till the
    > common ancestor of src and dst file
    
    > Example:
    > set quota limit set to 1GB on /
    > create a file /a1/b1/file1 of 600MB
    > mv /a1/b1/file1 /a1/b1/file2
    > This rename fails as it takes delta into account which sums up to 1.2BG.
    > Though we are not creating new file, we still get quota exceeded error.
    > So quota enforce should happen only till b1.
    
    > Similarly:
    > mv /a/b/c/file /a/b/x/y/file
    > quota enforce should happen only till dir 'b'
    
    > Change-Id: Ia1e5363da876c3d71bd424e67a8bb28b7ac1c7c1
    > BUG: 1153964
    > Signed-off-by: vmallika <vmallika>
    > Reviewed-on: http://review.gluster.org/8940
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Raghavendra G <rgowdapp>
    > Tested-by: Raghavendra G <rgowdapp>
    
    Change-Id: I2c814018d17f7af1807c1d1d162d8bdcbb31e491
    BUG: 1153964
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/9419
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>
Note You need to log in before you can comment on or make changes to this bug.