Created attachment 948284 [details] Fix the %post script to grep for an actual service rather than a comment. Description of problem: The rpm %post script checks whether /etc/services has already been modified with 'grep -q "PBS services" /etc/services'. We modify /etc/services at our site, and in the process, we happen to strip the comments. It seems more robust to grep for the actual services rather than the comment. Please replace "PBS services" with "pbs_sched". Version-Release number of selected component (if applicable): torque-3.0.4-5.fc19.src.rpm How reproducible: Install the update and notice the duplicate entries in /etc/services Steps to Reproduce: 1. grep pbs_sched /etc/services | wc -l 2. rpm -U torque-3.0.4-5.fc19.x86_64.rpm torque-libs-3.0.4-5.fc19.x86_64.rpm 3. grep pbs_sched /etc/services | wc -l Actual results: 2 4 Expected results: 2 2 Additional info:
I just discovered another issue that is related to this script. The 'cat' (coreutils) and 'grep' are not listed as required by the torque RPM. I had the scriptlet fail with /var/tmp/rpm-tmp.fxBXmC: line 4: cat: command not found warning: %post(torque-3.0.4-6.fc20.x86_64) scriptlet failed, exit status 127 when no coreutils is installed, in a chroot environment (a common situation when building a boot image via kickstart). Please add to the spec file: Requires: coreutils,grep
This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
I'm currently working on a fix for this, I'm addressing the two issues I see here. 1.) make sure Requires(post) is properly set for the package that is manipulating services. 2.) do fancier stuff to manipulate services so we don't add it twice.
I missed this one somehow, I've fixed up the post scripts to add the services one at a time and checking for each in the services file. should be fixed in version 4.2.10-3.*.x86_64 Thanks, - David Brown
I believe this has been fixed in the latest version of torque installed.