Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1155612

Summary: upgrade from jon 3.1.2 to jon 3.3.0 er05 does not work
Product: [JBoss] JBoss Operations Network Reporter: Armine Hovsepyan <ahovsepy>
Component: UpgradeAssignee: Jay Shaughnessy <jshaughn>
Status: CLOSED CURRENTRELEASE QA Contact: Armine Hovsepyan <ahovsepy>
Severity: high Docs Contact:
Priority: high    
Version: JON 3.3.0CC: ahovsepy, fbrychta, hrupp, jshaughn, mfoley, miburman
Target Milestone: CR01   
Target Release: JON 3.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-11 14:01:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
rhqctl-upgrade-312-33er5
none
rhqctl_upgrade_312_330er05_patch none

Description Armine Hovsepyan 2014-10-22 13:13:21 UTC
Created attachment 949390 [details]
rhqctl-upgrade-312-33er5

Description of problem:
upgrade from jon 3.1.2  to jon 3.3.0 er05 does not work

Version-Release number of selected component (if applicable):
JON 3.1.2 to JON 3.3 ER05 

How reproducible:
always

Steps to Reproduce:
1. install jon 3.1.2ga
2. upgrade to 3.3.0 er05 using:
./jon-server-3.3.0.ER05/bin/rhqctl upgrade --from-server-dir /$path/jon-server-3.1.2.GA/


Actual results:
upgrade fails

Expected results:
upgrade passes
jon 3.3.0 er05 accessible

Additional info:
log attached

Comment 3 Filip Brychta 2014-10-23 06:52:17 UTC
I believe the issue is caused by the same thing as bz 1150914 which is for clean installation and this one is for upgrade from old versions without storage node.

Comment 4 Michael Burman 2014-10-23 11:33:31 UTC
This should have failed already at the StorageInstaller, line 283, but for some reason it didn't (I don't see no-stamp parameter in the command line). The issue is that StorageNodeVersionColumnUpgrader is called at this point when upgrading, which is before the table is created, so the column is never created later either.

I think I'll leave this to Jay, as he had the vision to update the storage nodes first and then the server, while this upgrade would require the server db-upgrade to happen first..

Comment 5 Armine Hovsepyan 2014-10-23 11:38:41 UTC
Jay fixed this as a one-time patch, checked with ER05+patched jar 
lot attached
moving to ON_QA to double-check in CR01.

Comment 6 Armine Hovsepyan 2014-10-23 11:39:18 UTC
Created attachment 949818 [details]
rhqctl_upgrade_312_330er05_patch

Comment 7 Jay Shaughnessy 2014-10-23 13:06:21 UTC
master commit 0e4c52efca13a54937cdc71d703afa89d681f710
Author: Jay Shaughnessy <jshaughn>
Date:   Thu Oct 23 09:02:51 2014 -0400

    Fix an install issue when upgrading from a BSN (before storage nodes)
    version.  Go back to the legacy db-upgrade step that adds the entire
    rhq_storage_node table and make it match the same table definition you'd
    get from a new db.  Because no SNs existed at upgrade-time the version
    column updater never gets a chance to execute. And therefore the insertion
    of the initial SN fails.


release/jon3.3.x commit b2c528d24fc7d1ca31682520a90b45a4fd4b7b14
Author: Jay Shaughnessy <jshaughn>
Date:   Thu Oct 23 09:02:51 2014 -0400

   (cherry picked from commit 0e4c52efca13a54937cdc71d703afa89d681f710)
   Signed-off-by: Jay Shaughnessy <jshaughn>

Comment 8 Simeon Pinder 2014-11-03 19:03:40 UTC
Moving to ON_QA as available to test with latest brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=396547

Comment 9 Armine Hovsepyan 2014-11-04 10:40:38 UTC
verified in JON 3.3 CR01