Bug 1156492 - Review Request: golang-github-cpuguy83-go-md2man - Process markdown into manpages
Summary: Review Request: golang-github-cpuguy83-go-md2man - Process markdown into manp...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1156176
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-24 14:56 UTC by Lokesh Mandvekar
Modified: 2019-01-15 09:33 UTC (History)
2 users (show)

Fixed In Version: golang-github-cpuguy83-go-md2man-1-5.fc22
Clone Of:
Environment:
Last Closed: 2019-01-15 09:33:32 UTC
Type: ---
Embargoed:
jchaloup: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
changes to spec file (1.35 KB, patch)
2014-10-25 20:24 UTC, Jan Chaloupka
no flags Details | Diff

Description Lokesh Mandvekar 2014-10-24 14:56:33 UTC
Spec URL: https://lsm5.fedorapeople.org/golang-github-cpuguy83-go-md2man/golang-github-cpuguy83-go-md2man.spec
SRPM URL: https://lsm5.fedorapeople.org/golang-github-cpuguy83-go-md2man/SRPMS/golang-github-cpuguy83-go-md2man-1-1.fc22.src.rpm

Description: go-md2man is a golang tool using blackfriday to process markdown into 
manpages.

Fedora Account System Username: lsm5

depends on golang-github-russross-blackfriday

Comment 1 Jan Chaloupka 2014-10-25 20:23:45 UTC
$ rpmlint *.spec
golang-github-cpuguy83-go-md2man.spec:40: W: setup-not-quiet
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

package does not BuildRequires golang(code.google.com/p/go.net/html).

go-md2man-1]$ ggi
"bytes"
"flag"
"fmt"
"github.com/cpuguy83/go-md2man/mangen"
"github.com/russross/blackfriday"
"io/ioutil"
"os"
"strings"

only github.com/russross/blackfriday.

%check section is not needed, there are not test files.

Otherwise it looks good to me.

Comment 2 Jan Chaloupka 2014-10-25 20:24:24 UTC
Created attachment 950698 [details]
changes to spec file

Comment 3 Lokesh Mandvekar 2014-10-27 15:29:26 UTC
+ go build github.com/cpuguy83/go-md2man
/usr/share/gocode/src/github.com/russross/blackfriday/sanitize.go:6:2: cannot find package "code.google.com/p/go.net/html" in any of:
	/usr/lib/golang/src/pkg/code.google.com/p/go.net/html (from $GOROOT)
	/builddir/build/BUILD/go-md2man-1/_build/src/code.google.com/p/go.net/html (from $GOPATH)
	/usr/share/gocode/src/code.google.com/p/go.net/html

https://kojipkgs.fedoraproject.org//work/tasks/8554/7948554/build.log

Hmm, so russross/blackfriday should use go.net as a Requires:


I'll update blackfriday.


%changelog
* Mon Oct 27 2014 Lokesh Mandvekar <lsm5> - 1-2
- courtesy: jchaloup <jchaloup>
- quiet setup
- no test files, disable check

Spec URL same as above.

Comment 4 Jan Chaloupka 2014-10-27 16:08:20 UTC
Looks good to me.

Comment 5 Lokesh Mandvekar 2014-10-27 17:04:49 UTC
New Package SCM Request
=======================
Package Name: golang-github-cpuguy83-go-md2man
Short Description: Process markdown into manpages
Upstream URL: https://github.com/cpuguy83/go-md2man
Owners: lsm5 jchaloup
Branches: f21 f20 f19 el6 epel7
InitialCC: golang-sig

Comment 6 Gwyn Ciesla 2014-10-28 12:23:29 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2014-10-31 17:18:38 UTC
golang-github-cpuguy83-go-md2man-1-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-2.fc21

Comment 8 Fedora Update System 2014-10-31 17:28:45 UTC
golang-github-cpuguy83-go-md2man-1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-2.fc20

Comment 9 Fedora Update System 2014-11-01 16:20:25 UTC
golang-github-cpuguy83-go-md2man-1-2.fc20 has been pushed to the Fedora 20 testing repository.

Comment 10 Fedora Update System 2014-11-03 19:56:44 UTC
golang-github-cpuguy83-go-md2man-1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-2.el6

Comment 11 Fedora Update System 2014-11-19 16:00:37 UTC
golang-github-cpuguy83-go-md2man-1-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 12 Fedora Update System 2014-12-06 10:43:41 UTC
golang-github-cpuguy83-go-md2man-1-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 13 Fedora Update System 2014-12-12 23:08:08 UTC
golang-github-cpuguy83-go-md2man-1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-02-25 14:33:24 UTC
golang-github-cpuguy83-go-md2man-1-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-3.fc20

Comment 15 Fedora Update System 2015-02-25 14:33:44 UTC
golang-github-cpuguy83-go-md2man-1-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-3.fc21

Comment 16 Fedora Update System 2015-02-25 14:33:59 UTC
golang-github-cpuguy83-go-md2man-1-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-3.el6

Comment 17 Fedora Update System 2015-02-25 19:35:12 UTC
golang-github-cpuguy83-go-md2man-1-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-4.fc20

Comment 18 Fedora Update System 2015-02-25 19:35:29 UTC
golang-github-cpuguy83-go-md2man-1-4.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-4.fc21

Comment 19 Fedora Update System 2015-02-25 19:35:47 UTC
golang-github-cpuguy83-go-md2man-1-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-4.el6

Comment 20 Fedora Update System 2015-03-15 00:59:56 UTC
golang-github-cpuguy83-go-md2man-1-4.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2015-07-14 08:14:42 UTC
golang-github-cpuguy83-go-md2man-1-5.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/golang-github-cpuguy83-go-md2man-1-5.fc22

Comment 22 Fedora Update System 2015-07-16 02:33:58 UTC
golang-github-cpuguy83-go-md2man-1-4.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 23 Fedora Update System 2015-07-29 01:51:04 UTC
golang-github-cpuguy83-go-md2man-1-5.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2015-08-22 04:19:15 UTC
golang-github-cpuguy83-go-md2man-1-9.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update golang-github-cpuguy83-go-md2man'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-13941

Comment 25 Elliott Sales de Andrade 2019-01-15 09:33:32 UTC
Why tag new updates to this Review Request? This bug should have been closed ages ago.


Note You need to log in before you can comment on or make changes to this bug.