Hide Forgot
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/55921230cf384a2a4601b57a9cf4c6bd952946f5/php-egulias-email-validator.spec SRPM URL: https://siwinski.fedorapeople.org/copr/php-experimental/php-egulias-email-validator-1.2.3-1.fc20.src.rpm Description: A library for validating emails. Fedora Account System Username: siwinski COPR build: http://copr.fedoraproject.org/coprs/siwinski/php-experimental/build/55134/
Updated to 1.2.4 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/5c5b02a59bf0ac3451edfb0b50c81116f546fc24/php-egulias-email-validator.spec SRPM URL: https://siwinski.fedorapeople.org/copr/php-experimental/php-egulias-email-validator-1.2.4-1.fc20.src.rpm COPR build: http://copr.fedoraproject.org/coprs/siwinski/php-experimental/build/56464/
Created attachment 953485 [details] phpci.log phpCompatInfo version 3.5.0 static analyze results in src directory
Created attachment 953486 [details] review.txt Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
No issue detected. === APPROVED ===
Small notice, probably you can drop the sed for colors in phpunit configuration file, as, with latest version, this is automatically detected at runtime.
(In reply to Remi Collet from comment #5) > Small notice, probably you can drop the sed for colors in phpunit > configuration file, as, with latest version, this is automatically detected > at runtime. f20 and el6 still output the color escape codes so I would like to keep it b/c of those dists.
THANKS for the review! New Package SCM Request ======================= Package Name: php-egulias-email-validator Short Description: A library for validating emails Upstream URL: https://github.com/egulias/EmailValidator Owners: siwinski Branches: f20 f21 el6 epel7 InitialCC:
Git done (by process-git-requests).
php-egulias-email-validator-1.2.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-egulias-email-validator-1.2.5-1.fc20
php-egulias-email-validator-1.2.5-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-egulias-email-validator-1.2.5-1.fc21
php-egulias-email-validator-1.2.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-egulias-email-validator-1.2.5-1.el6
php-egulias-email-validator-1.2.5-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-egulias-email-validator-1.2.5-1.el7
php-egulias-email-validator-1.2.5-1.fc20 has been pushed to the Fedora 20 testing repository.
php-egulias-email-validator-1.2.5-1.fc21 has been pushed to the Fedora 21 stable repository.
php-egulias-email-validator-1.2.5-1.fc20 has been pushed to the Fedora 20 stable repository.
php-egulias-email-validator-1.2.5-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
php-egulias-email-validator-1.2.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository.